On 26 August 2013 06:44, Thijs Schreijer <th...@thijsschreijer.nl> wrote: > > > > > -----Original Message----- > > From: Alexey Melnichuk [mailto:mi...@newmail.ru] > > Sent: maandag 26 augustus 2013 11:32 > > To: luarocks-developers@lists.sourceforge.net > > Subject: Re: [Luarocks-developers] Define system specific flags. > > > > Thijs Schreijer <thijs@...> writes: > > > > > > > > > > LR should automatically detect Win version and set the WINVER variable. > > This value should be overrideable > > > by the commandline or the config file. > > > Then including the defines; > > > defines = { "WINVER=$(WINVER)" } > > > is up to the rockspec author. > > > > > > Is this incompatible? Isn't it just another build-in variable? > > > > > > > Well yes. I only concern about current version of luarocks. While luarocks > > does not define WINVER users will receive warnings and luarocks would > > generate not useful compile string. So if there way to detect if variable > > is > > defined from rockspec this is would be very convenient. > > E.g. > > local WINVER = DEFINED"$(WINVER)" and "$(WINVER)" or "0x501" > > ... > > defines = { "WINVER=" .. WINVER } > > > > That would be a simple answer; upgrade LR to a version that does auto set > WINVER, and if you don't want that add "WINVER=0x504" (or whatever win > version suites your needs) to your commandline.
This is technically incompatible, but sounds like a low-impact change. Which brings us to the next question: how to determine the default value of WINVER that should be autoset? This sounds like a task for the Windows installer script. :) (after detecting the Windows version, I suppose it could set LUAROCKS_WINVER in site_config.lua and then we add `defaults.variables.WINVER = LUAROCKS_WINVER or "0x500"` to the appropriate place in luarocks.cfg) -- Hisham ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Luarocks-developers mailing list Luarocks-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/luarocks-developers
