I'd like to suggest a change to the "JavaCC not found" build message. Would it be helpful to mention the build.properties file, where the javacc.home variable is defined? -Lex
>From: Brian Goetz <[EMAIL PROTECTED]> >Reply-To: "Lucene Developers List" <[EMAIL PROTECTED]> >To: Lucene Developers List <[EMAIL PROTECTED]> >Subject: Re: release 1.2 RC3 >Date: Sun, 27 Jan 2002 17:20:58 -0800 > >On Sun, Jan 27, 2002 at 04:49:06PM -0800, Doug Cutting wrote: > > > From: Andrew C. Oliver [mailto:[EMAIL PROTECTED]] > > > > > > Lets create separate targets for building the javacc stuff like this: > > > > > > cleancc - cleans just the javacc stuff > > > allclean - clean + cleancc > > > javacc - does the javacc stuff > > > > > > we'll include pre-compiled (or whatever one calls it) javacc'd stuff. > > > > > > I think this will prevent a lot of "THE BUILD IS BROKEN!!!!" > > > messages on both lists ;-) > >-1 from me. Seems like the wrong solution. Exposes too much of the >internals of the build to the user. > >Besides, most people don't need the sources; the pre-built JAR is fine >for the vast majority. If the problem is the error message, make it >clearer. > >However, what I've done in other projects is this: include the >generated .java files from JavaCC in the CVS repo, in some other part >of the tree (src/generated), and if JavaCC is not found, copy from >there instead of building them. That's easy enough to automate, but >its not clear if that solves the problem -- people without JavaCC might >try to change the query parser and wonder why its not building. > >I think the people who post "THE BUILD IS BROKEN" are going to do so >anyway; the current message is pretty clear that it can't find JavaCC >and what you have to do to fix it. > >-- >To unsubscribe, e-mail: ><mailto:[EMAIL PROTECTED]> >For additional commands, e-mail: ><mailto:[EMAIL PROTECTED]> > _________________________________________________________________ Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp. -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
