> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > > - 'De-finalized' the class per Doug's suggestion to make it > easy to use > different lists of stop words.
Thanks! > - Added a few more words to the stop word list (MS' > contribution via Alan). I don't think we should do that here. This could break any application which is already using this stop list when it upgrades Lucene, since it will no longer be possible to search for these words. What we need is a facility to load stop lists from file-based resources, and to include a new such resource that contains this MS stop list. But I don't think we should change the default stop lists. What do others think? Is that too conservative? > - Re-indented the whole class. I don't think we should re-indent whole files. It makes it hard to figure out what's changed over time. We should try to use a similar indenting style, but if someone has written the code, they have the right to indent it. I generally only re-indent code if I'm committing it for the first time, or for those parts of the code that I change. Doug -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
