Ah, I wish we had a discussion like this when the original suggestions
were made, not now that things have been patched and committed.
I never had a problem with the original Lucene setup, having 2 files
did not bother me, and I think it is easier to edit property=value text
files than Ant's XML.
I do think having defaults in build.xml and not build.properties is
better than having defaults in build.properties and that using
build.properties for overriding defaults instead of changing build.xml
is better (simpler for people to do, less error prone, requires less
knowledge).
It would be good if others could share their opinions and votes, so
that I can move things out of the half-baked state on build in the CVS
repository.
That's my 16 lipas.
Otis
--- Jon Scott Stevens <[EMAIL PROTECTED]> wrote:
> on 2/26/02 5:10 PM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
>
> > - Moved properties from build.properties in here. build.properties
> should be
> > removed and replaced by build.properties.sample.
>
> -1.
>
> A better way to deal with this is to follow what Scarab and other
> projects
> do which is to do this:
>
> <!-- Give user a chance to override without editing this file
> (and without typing -D each time it compiles it -->
> <property file="${user.home}/lucene.build.properties" />
> <property file="${user.home}/build.properties" />
> <property file="${basedir}/build.properties" />
> <property file="${basedir}/default.properties" />
>
> First, rename build.properties to default.properties
>
> Next, a developer can create one or more of the following files:
>
> ~/build.properties
> ~/lucene.build.properties
> lucene/build.properties
>
> That way, developers don't need to rename files in order to make
> things work
> and the 'default' properties don't clutter up the build.xml file.
>
> Thanks,
>
> -jon
>
>
> --
> To unsubscribe, e-mail:
> <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail:
> <mailto:[EMAIL PROTECTED]>
>
__________________________________________________
Do You Yahoo!?
Yahoo! Greetings - Send FREE e-cards for every occasion!
http://greetings.yahoo.com
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
