Nice commit.
I am looking through diffs a bit.
I noticed that fileformats.xml mentions that term vectors store term
positions, but I don't see term positions mentioned in descriptions of
.tv* files. I don't think they are implemented in this version of TV,
although there is TermPositionVector interface.
Shouldn't there be a 'return true' right in that if block below?
+ public boolean hasVectors() {
+ boolean hasVectors = false;
+ for (int i = 0; i < size(); i++) {
+ if (fieldInfo(i).storeTermVector)
+ hasVectors = true;
+ }
+ return hasVectors;
+ }
Otis
P.S.
I noticed that the old ASL was used in some new classes. We should use
the current version of the license (version 2). I believe I put a copy
of it in the root of jakarta-lucene module.
I also believe we will have to replace all ASLs in the code with the
latest version, before releasing 1.4RC1.
--- [EMAIL PROTECTED] wrote:
> cutting 2004/02/20 12:14:56
>
> Modified: . CHANGES.txt
> src/java/org/apache/lucene/document Field.java
> src/java/org/apache/lucene/index
> CompoundFileReader.java
> DocumentWriter.java FieldInfo.java
> FieldInfos.java
> FieldsReader.java FilterIndexReader.java
> IndexReader.java MultiReader.java
> SegmentMerger.java SegmentReader.java
> SegmentTermDocs.java SegmentTermEnum.java
> SegmentTermPositions.java TermDocs.java
> TermEnum.java TermInfosWriter.java
> src/test/org/apache/lucene/index
> TestFilterIndexReader.java
> src/test/org/apache/lucene/search TestBasics.java
> xdocs fileformats.xml
> Added: src/java/org/apache/lucene/index
> SegmentTermVector.java
> TermFreqVector.java TermPositionVector.java
> TermVectorsReader.java TermVectorsWriter.java
> src/java/org/apache/lucene/search QueryTermVector.java
> src/java/org/apache/lucene/util StringHelper.java
> src/test/org/apache/lucene/index DocHelper.java
> TestDocumentWriter.java TestFieldInfos.java
> TestFieldsReader.java TestMultiReader.java
> TestSegmentMerger.java TestSegmentReader.java
> TestSegmentTermDocs.java
> TestTermVectorsReader.java
> TestTermVectorsWriter.java
> src/test/org/apache/lucene/search
> TestQueryTermVector.java
> TestTermVectors.java
> src/test/org/apache/lucene/util StringHelperTest.java
> Log:
> Added term vector support.
>
> Revision Changes Path
> 1.74 +5 -1 jakarta-lucene/CHANGES.txt
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/CHANGES.txt.diff?r1=1.73&r2=1.74
>
>
> 1.12 +69 -7
> jakarta-lucene/src/java/org/apache/lucene/document/Field.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/document/Field.java.diff?r1=1.11&r2=1.12
>
>
> 1.4 +2 -2
>
jakarta-lucene/src/java/org/apache/lucene/index/CompoundFileReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/CompoundFileReader.java.diff?r1=1.3&r2=1.4
>
>
> 1.9 +51 -15
> jakarta-lucene/src/java/org/apache/lucene/index/DocumentWriter.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/DocumentWriter.java.diff?r1=1.8&r2=1.9
>
>
> 1.2 +5 -1
> jakarta-lucene/src/java/org/apache/lucene/index/FieldInfo.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/FieldInfo.java.diff?r1=1.1&r2=1.2
>
>
> 1.5 +110 -33
> jakarta-lucene/src/java/org/apache/lucene/index/FieldInfos.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/FieldInfos.java.diff?r1=1.4&r2=1.5
>
>
> 1.6 +3 -2
> jakarta-lucene/src/java/org/apache/lucene/index/FieldsReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/FieldsReader.java.diff?r1=1.5&r2=1.6
>
>
> 1.7 +26 -4
>
jakarta-lucene/src/java/org/apache/lucene/index/FilterIndexReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/FilterIndexReader.java.diff?r1=1.6&r2=1.7
>
>
> 1.26 +131 -102
> jakarta-lucene/src/java/org/apache/lucene/index/IndexReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/IndexReader.java.diff?r1=1.25&r2=1.26
>
>
> 1.2 +33 -2
> jakarta-lucene/src/java/org/apache/lucene/index/MultiReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/MultiReader.java.diff?r1=1.1&r2=1.2
>
>
> 1.8 +174 -67
> jakarta-lucene/src/java/org/apache/lucene/index/SegmentMerger.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/SegmentMerger.java.diff?r1=1.7&r2=1.8
>
>
> 1.19 +80 -24
> jakarta-lucene/src/java/org/apache/lucene/index/SegmentReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/SegmentReader.java.diff?r1=1.18&r2=1.19
>
>
> 1.6 +27 -27
> jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermDocs.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermDocs.java.diff?r1=1.5&r2=1.6
>
>
> 1.4 +17 -17
> jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermEnum.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermEnum.java.diff?r1=1.3&r2=1.4
>
>
> 1.6 +1 -1
>
jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermPositions.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermPositions.java.diff?r1=1.5&r2=1.6
>
>
> 1.6 +9 -9
> jakarta-lucene/src/java/org/apache/lucene/index/TermDocs.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/TermDocs.java.diff?r1=1.5&r2=1.6
>
>
> 1.4 +23 -0
> jakarta-lucene/src/java/org/apache/lucene/index/TermEnum.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/TermEnum.java.diff?r1=1.3&r2=1.4
>
>
> 1.4 +5 -11
> jakarta-lucene/src/java/org/apache/lucene/index/TermInfosWriter.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/TermInfosWriter.java.diff?r1=1.3&r2=1.4
>
>
> 1.1
>
jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermVector.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/SegmentTermVector.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/java/org/apache/lucene/index/TermFreqVector.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/TermFreqVector.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/java/org/apache/lucene/index/TermPositionVector.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/TermPositionVector.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/java/org/apache/lucene/index/TermVectorsReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/TermVectorsReader.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/java/org/apache/lucene/index/TermVectorsWriter.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/index/TermVectorsWriter.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/java/org/apache/lucene/search/QueryTermVector.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/search/QueryTermVector.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/java/org/apache/lucene/util/StringHelper.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/java/org/apache/lucene/util/StringHelper.java?rev=1.1
>
>
> 1.2 +1 -1
>
jakarta-lucene/src/test/org/apache/lucene/index/TestFilterIndexReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestFilterIndexReader.java.diff?r1=1.1&r2=1.2
>
>
> 1.1
> jakarta-lucene/src/test/org/apache/lucene/index/DocHelper.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/DocHelper.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/test/org/apache/lucene/index/TestDocumentWriter.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestDocumentWriter.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/test/org/apache/lucene/index/TestFieldInfos.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestFieldInfos.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/test/org/apache/lucene/index/TestFieldsReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestFieldsReader.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/test/org/apache/lucene/index/TestMultiReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestMultiReader.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/test/org/apache/lucene/index/TestSegmentMerger.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestSegmentMerger.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/test/org/apache/lucene/index/TestSegmentReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestSegmentReader.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/test/org/apache/lucene/index/TestSegmentTermDocs.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestSegmentTermDocs.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/test/org/apache/lucene/index/TestTermVectorsReader.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestTermVectorsReader.java?rev=1.1
>
>
> 1.1
>
jakarta-lucene/src/test/org/apache/lucene/index/TestTermVectorsWriter.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/index/TestTermVectorsWriter.java?rev=1.1
>
>
> 1.5 +1 -1
> jakarta-lucene/src/test/org/apache/lucene/search/TestBasics.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/search/TestBasics.java.diff?r1=1.4&r2=1.5
>
>
> 1.1
>
jakarta-lucene/src/test/org/apache/lucene/search/TestQueryTermVector.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/search/TestQueryTermVector.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/test/org/apache/lucene/search/TestTermVectors.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/search/TestTermVectors.java?rev=1.1
>
>
> 1.1
> jakarta-lucene/src/test/org/apache/lucene/util/StringHelperTest.java
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/src/test/org/apache/lucene/util/StringHelperTest.java?rev=1.1
>
>
> 1.7 +56 -5 jakarta-lucene/xdocs/fileformats.xml
>
>
>
http://cvs.apache.org/viewcvs/jakarta-lucene/xdocs/fileformats.xml.diff?r1=1.6&r2=1.7
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
