I actually already documented these properties in xdocs format (commit coming). But making things public and using Javadocs is also a good idea.
LOCK_DIR - good catch - changed things. Otis --- Doug Cutting <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > - Added support for setting various Lucene properties via system > properties. > > Otis, > > Thanks for doing this. > > Now we need to get these properties into the documentation. The > easiest > approach is simply to make all of these 'private static final' fields > > into 'public static final' fields which then mention the system > property > which can be used to override their default. > > Also, is Lock.LOCK_DIR actually used? The diff didn't show that. > Since > this is to be used by FSDirectory, the parameter should probably be > in > FSDirectory.java, not Lock.java. It wouldn't be relevant to, e.g., a > > database-based lock implementation. > > And when it is used we should permit it to be relative to the index > directory. So, in FSDirectory, we might have a field like: > > private File lockDir; > > and in FSDirectory ctor, add something like: > > lockDir = new File(LOCK_DIR); > if (!lockDir.isAbsolute()) { > lockDir = new File(directory, LOCK_DIR); > } > > Then use lockDir when creating lock file names. This will permit > someone to simply set org.apache.lucene.lockdir to "." to get the old > > behaviour where lock files are placed alongside indexes. > > Does that makes sense? > > Doug > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]