They'll just creep back in. Plus I generally think reformatting is a bad reason for a commit. It clogs and confuses diffs. Changes should be confined to fixing bugs and adding features. To me, reformatting is more evil than tabs.
http://java.sun.com/docs/codeconv/html/CodeConventions.doc3.html
Tab's are acceptable so long as things indent correctly with 8 space stops.
Doug
Otis Gospodnetic wrote:
Tabs are evil. Does anyone mind me doing s/\t/ /g on *.java?
I'd love to clean up, but am wondering if that will affect our ability to apply patches sitting in Bugzilla.
Does anyone have any experience with this? A quick glance at the man page for patch seems to indicate that this should not be a problem:
-l or --ignore-whitespace Match patterns loosely, in case tabs or spaces have been munged in your files. Any sequence of one or more blanks in the patch file matches any sequence in the original file, and sequences of blanks at the ends of lines are ignored. Normal characters must still match exactly. Each line of the context must still match a line in the original file.
I'll commit my local s/\t/ /g changes, unless somebody speaks up by tomorrow morning, CET.
Thanks, Otis
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
