DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=30736>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=30736 [PATCH] to remove synchronized code from TermVectorsReader ------- Additional Comments From [EMAIL PROTECTED] 2004-08-19 11:47 ------- Bernhard, Thanks for the patch. The unit test requires class o.a.lucene.util.English. This is not in CVS. Is this something that should be in the CVS? What is it? I am also wondering about this piece of code: - termVectorsReader = new TermVectorsReader(cfsDir, segment, fieldInfos); + final Directory dir = cfsDir; + termVectorsLocal = new ThreadLocal() { + protected synchronized Object initialValue() { + try { + return new TermVectorsReader(dir, segment, fieldInfos); + } catch (IOException ioe) { + ioe.printStackTrace(); + return null; + } + } + }; Is is a good thing to 'eat' that IOException and quietly return null? The method where this code is, is already throwing IOException, so why not let the IOException pop up? Finally, it looks like diffs contain tabs. Could you please change tabs to 2 spaces? Thanks, Otis --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
