Looks ok to me. I don't really have a preference between OR or SHOULD.
Erik
On Aug 19, 2004, at 6:48 PM, Daniel Naber wrote:
BooleanQuery.add() currently takes two boolean values. That's difficult to
use as these two parameters can easily be confused. Also, there's a
runtime error if one uses true for both parameters. Thus this method's API
should be redesigned. It has been discussed here already:
http://www.mail-archive.com/lucene-user%40jakarta.apache.org/ msg08479.html
I suggest the attached patch. Instead of Doug's suggestion of "Occur" my
patch uses "Operator" and instead of MUST/MUST_NOT/SHOULD it uses
AND/NOT/OR for the enumeration. I think SHOULD would be difficult to
understand, but I'm not happy with OR either. The problem is that it's
okay to have a BooleanQuery with only one Term, and OR would mean the same
as AND in that case.
Please post your suggestions for better names.
Regards Daniel
--
http://www.danielnaber.de
<boolean.diff>--------------------------------------------------------- ------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
