Doug Cutting wrote:
Back in 1998, when FSDirectory was first written, 'final' did actually make some things faster. It permitted 'javac' to inline more things. It also held the promise that future compilers might do more with it. Well, now here we are in the future, and all we have are a bunch of final declarations!

Note too that a few of Lucene's final declarations are there because classes and/or methods really should not be overridden. I don't think FSDirectory falls into this category. So I support making FSDirectory and its methods non-final.

OK, do you want to write the patch or shall I?

thanks -mike

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to