[ 
http://issues.apache.org/jira/browse/LUCENENET-11?page=comments#action_12444119 
] 
            
T.H. commented on LUCENENET-11:
-------------------------------

I was wondering if anyone has done much testing on this patch or has otherwise 
reviewed it?   We are doing some load testing on our application right now, and 
we are at time seeing up to 1000 .NET exceptions being thrown PER SECOND by the 
Lucene.NET DLL because of  these "thrown on purpose" exceptions.  (We are 
testing under a pretty large load and are doing multiple searches per user.)

Anyway, I was just wondering if anyone has put this patch into production, or 
if some of the more knowledgable members of the project have any serious 
concerns about implementing the patch?

While I understand the need to try to keep the code base close to the Java 
version, it seems like this is a situation where the exceptions may be 
necessary in Java, but are completely unnecessary and otherwise harmful to the 
.NET version.

Any comments would be greatly appreciated!   

And thanks to everyone for their great work on Lucene.NET!

> Avoiding non necessary exceptions
> ---------------------------------
>
>                 Key: LUCENENET-11
>                 URL: http://issues.apache.org/jira/browse/LUCENENET-11
>             Project: Lucene.Net
>          Issue Type: Improvement
>            Reporter: Fabio Buscaroli
>         Attachments: patch.zip, patch2.zip
>
>
> As already said in previous issues, there are few exceptions that are raised 
> for  no reason (apparently).
> I updated  FastCharStream, QueryParserTokenManager, FieldInfos to avoid these 
> kind of exception.
> - FastCharStream.ReadChar() returns '\0' if we are trying to read byond the 
> end of the stream.
> - Updated QueryParserTokenManager to support the previous fix
> - Update FieldInfos.FieldName. No more reading take place if fieldNumber is 
> -1.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to