[
https://issues.apache.org/jira/browse/LUCENENET-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479860
]
George Aroush commented on LUCENENET-30:
----------------------------------------
Hi Joe,
Sorry, my bad. This is fixed; it got in through another commit that I made.
Here is the commit:
http://svn.apache.org/viewvc/incubator/lucene.net/trunk/C%23/src/Lucene.Net/Index/SegmentReader.cs?view=diff&r1=516734&r2=516735&pathrev=516735
Can you confirm and then close this issue?
Thanks!
-- George Aroush
> Unnecessary boxing of bytes
> ---------------------------
>
> Key: LUCENENET-30
> URL: https://issues.apache.org/jira/browse/LUCENENET-30
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Linux, Lucene.Net 2.0
> Reporter: Joe Shaw
> Assigned To: George Aroush
>
> SegmentReader.CreateFakeNorms() unnecessarily boxes bytes:
> byte[] ones = new byte[size];
> byte val = DefaultSimilarity.EncodeNorm(1.0f);
> for (int index = 0; index < size; index++)
> ones.SetValue(val, index);
> Because Array.SetValue() takes an object for the first argument, each byte is
> boxed.
> Changing the SetValue() call to:
> ones [index] = val;
> fixes the problem, because array indexers are type checked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
