I made changes to the source to remove all unused variables (declared exceptions, and a few others in QueryParser and QueryParserTokenManager - I think). They were re-introduced by the time my code was submitted to SVN. I'm not sure if this was on purpose or not - the exception variables might have been re-introduced via code beautification or some other automagic process.
George, can you speak to whether there is a legitimate reason to keep references to the unused variables? -Doug On Thu, Jul 17, 2008 at 10:52 AM, Stephen Voorhees < [EMAIL PROTECTED]> wrote: > All, > > I am working on building Lucene.NET 2.3.1 in Visual Studio 2008 and .NET > 3.5. I have updated solution and project files to support this and plan to > address several code analysis warnings that show up (eg. unused local > variables, etc...) I won't be making any changes that require the .NET 3.0+ > runtime to ensure the code can continue to build and run on VS 2005/.NET > 2.0. > > I'd like to submit my solution/project files to the code base, should I > just create a JIRA defect with a patch? Also, I assume, any code analysis > fixes should be submitted the same way. > > Cheers, > --Steve > > Software Architect > Autodesk Inc. > >
