Hi DIGY, As you can see, I made a small change to your patch of "LUCENENET-106 (Lucene.NET is leaking memory)". I made this change so that the code stands out as a .NET port specific, and not port from Java. I.e.: seeing "cache = new Lucene.Net.Util.WeakHashTable();" suggest "WeakHashTable" also exist in the Java code, since "Lucene.Net.Util" does exist. However, seeing "cache = new SupportClass.WeakHashTable();" makes it clear that this code is specific to Lucene.Net and is a port related code vs. Lucene logic code.
Regards, -- George -----Original Message----- From: aro...@apache.org [mailto:aro...@apache.org] Sent: Tuesday, December 30, 2008 11:58 PM To: lucene-net-comm...@incubator.apache.org Subject: svn commit: r730308 - in /incubator/lucene.net/trunk/C#/src/Lucene.Net: Search/CachingSpanFilter.cs Search/CachingWrapperFilter.cs Search/FieldCacheImpl.cs SupportClass.cs Author: aroush Date: Tue Dec 30 20:57:37 2008 New Revision: 730308 URL: http://svn.apache.org/viewvc?rev=730308&view=rev Log: Moved the new class "WeakHashTable" from the namespace "Lucene.Net.Util" to "SupportClass". Modified: incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingSpanFilter.cs incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingWrapperFilter.cs incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/FieldCacheImpl.cs incubator/lucene.net/trunk/C#/src/Lucene.Net/SupportClass.cs Modified: incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingSpanFilter.cs URL: http://svn.apache.org/viewvc/incubator/lucene.net/trunk/C%23/src/Lucene.Net/ Search/CachingSpanFilter.cs?rev=730308&r1=730307&r2=730308&view=diff ============================================================================ == --- incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingSpanFilter.cs (original) +++ incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingSpanFilte +++ r.cs Tue Dec 30 20:57:37 2008 @@ -55,7 +55,7 @@ SpanFilterResult result = null; if (cache == null) { - cache = new Lucene.Net.Util.WeakHashTable(); + cache = new SupportClass.WeakHashTable(); } lock (cache.SyncRoot) Modified: incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingWrapperFilter.cs URL: http://svn.apache.org/viewvc/incubator/lucene.net/trunk/C%23/src/Lucene.Net/ Search/CachingWrapperFilter.cs?rev=730308&r1=730307&r2=730308&view=diff ============================================================================ == --- incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingWrapperFilter.cs (original) +++ incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/CachingWrapperFi +++ lter.cs Tue Dec 30 20:57:37 2008 @@ -48,7 +48,7 @@ { if (cache == null) { - cache = new Lucene.Net.Util.WeakHashTable(); + cache = new SupportClass.WeakHashTable(); } lock (cache.SyncRoot) Modified: incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/FieldCacheImpl.cs URL: http://svn.apache.org/viewvc/incubator/lucene.net/trunk/C%23/src/Lucene.Net/ Search/FieldCacheImpl.cs?rev=730308&r1=730307&r2=730308&view=diff ============================================================================ == --- incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/FieldCacheImpl.cs (original) +++ incubator/lucene.net/trunk/C#/src/Lucene.Net/Search/FieldCacheImpl.c +++ s Tue Dec 30 20:57:37 2008 @@ -565,7 +565,7 @@ /// <summary>Expert: Internal cache. </summary> internal abstract class Cache { - private System.Collections.IDictionary readerCache = new Lucene.Net.Util.WeakHashTable(); + private System.Collections.IDictionary readerCache = new +SupportClass.WeakHashTable(); protected internal abstract System.Object CreateValue(IndexReader reader, System.Object key); Modified: incubator/lucene.net/trunk/C#/src/Lucene.Net/SupportClass.cs URL: http://svn.apache.org/viewvc/incubator/lucene.net/trunk/C%23/src/Lucene.Net/ SupportClass.cs?rev=730308&r1=730307&r2=730308&view=diff ============================================================================ == --- incubator/lucene.net/trunk/C#/src/Lucene.Net/SupportClass.cs (original) +++ incubator/lucene.net/trunk/C#/src/Lucene.Net/SupportClass.cs Tue Dec +++ 30 20:57:37 2008 @@ -1012,12 +1012,7 @@ } } } -} - - -namespace Lucene.Net.Util -{ #region WEAKHASHTABLE internal class WeakHashTable : System.Collections.IDictionary {
