[ 
https://issues.apache.org/jira/browse/LUCENENET-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679434#action_12679434
 ] 

Ben Martz commented on LUCENENET-172:
-------------------------------------

Hi George,

In your opinion do you think it's worth spending my time to resolve the 
specific demo issues or should I just pursue the API deprecation at the parent 
project level? I don't want to contribute anything for public consumption that 
doesn't properly document the pros and cons of its usage so I want to at least 
consider fixing or documenting the specific demos that break. I can definitely 
appreciate your comment that since these two methods are public than the API 
change could clearly have ramifications outside of the core project source code.

Cheers,
Ben

> This patch fixes the unexceptional exceptions ecountered in FastCharStream 
> and SupportClass
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENENET-172
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-172
>             Project: Lucene.Net
>          Issue Type: Improvement
>            Reporter: Ben Martz
>         Attachments: lucene_2.3.1_exceptions_fix.patch
>
>
> The java version of Lucene handles end-of-file in FastCharStream by throwing 
> an exception. This behavior has been ported to .NET but the behavior carries 
> an unacceptable cost in the .NET environment. This patch is based on the 
> prior work in LUCENENET-8 and LUCENENET-11, which I gratefully acknowledge 
> for the solution. While I understand that this patch is outside of the 
> current project specification in that it deviates from the "pure" nature of 
> the port, I believe that it is very important to make the patch available to 
> any developer looking to leverage Lucene.Net in their project. Thanks for 
> your consideration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to