[ 
https://issues.apache.org/jira/browse/LUCENENET-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Garski updated LUCENENET-218:
-------------------------------------

    Attachment: TestAttributeSource.patch

OK, thanks to Nick's collection I was able to get the tests to pass properly.

I included the collection again in the patch, which moves it into the Util 
subdirectory.  I also had to make one small change to the collection in the 
ContainsKey method as the underlying Dictionary will be null until the first 
item is added, so it just checks for the null condition.

I modified the The return value on the GetAtributeClassesIterator and 
GetAttributeImplsIterator to accomodate the differences in the underlying 
collection.  This did result in requiring a small change to the 
Analysis.TeeSinkTokenFilter class, however the tests for that class still pass. 
 I verified coverage of the change using NCoverExplorer with TestDriven.Net 
(the NUnit integration plugin for VS).

Check it out and let me what you think.

> Lucene.Net.Util.TestAttributeSource.TestCloneAttributes
> -------------------------------------------------------
>
>                 Key: LUCENENET-218
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-218
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: LUCENENET-218.patch, TestAttributeSource.patch
>
>
> The test is failing - I'm working on it :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to