[
https://issues.apache.org/jira/browse/LUCENENET-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780176#action_12780176
]
Nicholas Paldino commented on LUCENENET-285:
--------------------------------------------
Andrei,
Well, not ALL cases =) But most of them, yes, because when writing to an
index, and reading from it, culture formatting shouldn't come into play when
numeric values are read/written to an index. I definitely agree.
To elaborate on the extension method, I would recommend when the code diverges
to write "ToInvariantString()" extension methods for float, double, int, long
which would allow for an easy way to write invariant versions of the numbers
consistently, as opposed to always querying for InvariantCulture at the call
site (better encapsulation of the code), but as mentioned, that's for a future
date.
> Problem with "CurrentCulture"
> -----------------------------
>
> Key: LUCENENET-285
> URL: https://issues.apache.org/jira/browse/LUCENENET-285
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
>
> Hi Folks,
> There is a bug in utilizing Thread.CurrentThread.CurrentCulture.
> A float number such as 2.5 can be converted to string as "2.5" or "2,5"
> depending on the culture.
> if it is converted to "2,5", some of the tests(ex, TestAnalyzerReturningNull)
> under "QueryParser" fails
> _(cause: buffer.Append(minimumSimilarity.ToString()) in FuzzyQuery.cs line
> 204)_
> Since they make string comparison of the queries.
> There can be two solutions to this
> 1- Changing, for ex,
> _buffer.Append(minimumSimilarity.ToString())_
> to
> _buffer.Append(SupportClass.Single.ToString(minimumSimilarity)_
> in Lucene.NET core (there may be many other places)
> or
> 2- Changing the current-culture of the test cases to "en-US".
> Solution-2 is the simplest way, but what is the correct one?
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
