bleh - forgot to update the branch.
And yay for windows hiding those svn files.. I'll give it a day or so and see what others might say then update it and call a new vote. Thanks for taking the time to review ~P ---------------------------------------- > From: bode...@apache.org > To: lucene-net-...@incubator.apache.org > Date: Mon, 31 Oct 2011 07:00:08 +0100 > Subject: Re: [Lucene.Net] [VOTE] Apache Lucene.Net-2.9.4-incubating > > On 2011-10-31, Prescott Nasser wrote: > > > Artifacts are located here: > > http://people.apache.org/~pnasser/Lucene.Net/2.9.4-incubating-RC1/ > > Is there a tag in svn that is supposed to correspond to them? My guess > is <http://people.apache.org/~pnasser/Lucene.Net/2.9.4-incubating-RC1/>. > But then I find > > diff -ur svn/src/contrib/Similarity/Similar/MoreLikeThis.cs > Apache-Lucene.Net-2. > 9.4-incubating-RC1.src/src/contrib/Similarity/Similar/MoreLikeThis.cs > --- svn/src/contrib/Similarity/Similar/MoreLikeThis.cs 2011-04-23 > 01:53:05.3476 > 64000 +0200 > +++ > Apache-Lucene.Net-2.9.4-incubating-RC1.src/src/contrib/Similarity/Similar/Mo > reLikeThis.cs 2011-10-30 19:35:42.000000000 +0100 > @@ -769,7 +769,7 @@ > { > for (int j = 0; j < text.Length; j++) > { > - AddTermFrequencies(new System.IO.StreamReader(text[ > j]), termFreqMap, fieldName); > + AddTermFrequencies(new System.IO.StringReader(text[ > j]), termFreqMap, fieldName); > } > } > } > @@ -820,7 +820,7 @@ > /// </param> > /// <param name="fieldName">Used by analyzer for any special per-field > analysis > /// </param> > - private void AddTermFrequencies(System.IO.StreamReader r, > System.Collections.IDictionary termFreqMap, System.String fieldName) > + private void AddTermFrequencies(System.IO.TextReader r, > System.Collections.IDictionary termFreqMap, System.String fieldName) > { > TokenStream ts = analyzer.TokenStream(fieldName, r); > Lucene.Net.Analysis.Token token; > > so they don't match. > > The src ZIP doesn't contain build.cmd nor the doc and lib folders. Is > this intentional? > > Signatures and checksums match. > > The src ZIP contains .svn folders which I don't think they should. No > biggie just something to fix for the next release or RC. Same for some > .suo files and obj folders. > > The binary distribution needs LICENSE.txt and NOTICE.txt that I can't > seem to find. This forces a -1 from me. > > The only other test I'd perform was running RAT which I'll do shortly > and post the results here. > > Stefan
