[
https://issues.apache.org/jira/browse/LUCY-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782954#action_12782954
]
Marvin Humphrey commented on LUCY-72:
-------------------------------------
> So the .svn dirs had the same s/// applied and so svn diff did not see a
> change.
Ha! Mystery solved.
I probably had it coming after all the nasty little traps you set off while
working up this patch:
{code:none}
#ifdef CHAZ_USE_SHORT_NAMES
- #define VariadicMacros_run chaz_VaradicMacros_run
+ #define VariadicMacros_run chaz_VariadicMacros_run
#endif
{code}
:)
This append_conf() snafu is a perfect illustration of why I hate "perl -pie"
and felt compelled to write predit.
> use short names wherever CHAZ_USE_SHORT_NAMES is in effect
> ----------------------------------------------------------
>
> Key: LUCY-72
> URL: https://issues.apache.org/jira/browse/LUCY-72
> Project: Lucy
> Issue Type: Task
> Components: Charmonizer
> Reporter: Peter Karman
> Attachments: chaz_prefix-cleanup.patch, chaz_prefix-cleanup.patch
>
>
> Function names in .c files always use "short names"
> whenever the "LUCY_USE_SHORT_NAMES" macro is in effect -- e.g. we use
> "Sort_mergesort" rather than "lucy_Sort_mergesort".
>
> Within Charmonizer, we should be consistent about using short names
> everywhere the "CHAZ_USE_SHORT_NAMES" macro is in effect, but currently
> there are lots of places that we don't -- e.g. we use "chaz_Test_plan"
> rather than "Test_plan" within charmonizer/src/Charmonizer/Test.charm:
> void
> -chaz_Test_plan(TestBatch *batch)
> +Test_plan(TestBatch *batch)
> {
> printf("1..%u\n", batch->num_tests);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
