Please don't reply to lustre-devel. Instead, comment in Bugzilla by using the 
following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11271

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9236|review?([EMAIL PROTECTED]|review+
               Flag|m)                          |


(From update of attachment 9236)
>diff -u -p -r1.20.2.47 lustre-lnet.m4
>--- lnet/autoconf/lustre-lnet.m4       11 Dec 2006 11:18:13 -0000      
>1.20.2.47
>+++ lnet/autoconf/lustre-lnet.m4       28 Dec 2006 21:41:58 -0000
>@@ -1071,6 +1071,25 @@ LB_LINUX_TRY_COMPILE([
> ])
> ])
> 
>+#2.6.19 API change
>+#panic_notifier_list use atomic_notifier operations
>+#
>+AC_DEFUN([LN_ATOMIC_PANIC_NOTIFIER],
>+[AC_MSG_CHECKING([panic_notifier_list is atomic])
>+LB_LINUX_TRY_COMPILE([
>+      #include <linux/notifier.h>
>+      #include <linux/kernel.h>       
>+],[
>+      struct atomic_notifier_head panic_notifier_list;
>+],[
>+        AC_MSG_RESULT(yes)
>+      AC_DEFINE(HAVE_ATOMIC_PANIC_NOTIFIER, 1,
>+              [panic_notifier_list is atomic_notifier_head])
>+],[
>+        AC_MSG_RESULT(NO)
>+])
>+])

In fact, we don't really need this at all.  The panic notifier code has been
disabled for ages (under non-existent #ifdef LNET_DUMP_ON_PANIC) because it
causes more problems at node panic than it solves these days (since we changed
to binary debug logs).  I would just remove all of the *panic_notifier code
entirely. 

Looks good otherwise.

_______________________________________________
Lustre-devel mailing list
[email protected]
https://mail.clusterfs.com/mailman/listinfo/lustre-devel

Reply via email to