Please don't reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=11486
(In reply to comment #6) > (This is a diff from b1_5, not b1_4) Yes. All new work needs to be done on b1_5 first and then merged back if appropriate. > In obd_proc_read_version, is there a need to remove the BUILD_VERSION? It's not strictly necessary, but I'd like BUILD_VERSION to die and some of the rest of the patch removes the code that produces it. Do you think it's useful? AFAIK it's never been useful to the support team (but I'll ask the rest of them to be sure.) > init_obdclass uses CDEBUG for the liblustre case - does init_libcfs_module > need > to as well? If you look at the RC check just below my new printk(), printk() is used there to print an error if necessary. Therefore I believe printk() is fine anywhere in init_libcfs_module(). _______________________________________________ Lustre-devel mailing list [email protected] https://mail.clusterfs.com/mailman/listinfo/lustre-devel
