I'm not sure that liblustre has ever been tested on ia64, though of course
it is entirely possible that it works OK.  The value of PAGE_SIZE used by
liblustre is pretty arbitrary I think, a large part of it is just so that
the same code can be used by liblustre and linux.

As for your patch, I haven't looked at it closely, but I'm confused why
you would change PAGE_SIZE -> getpagesize(), and then later make a
#define PAGE_SIZE?  Also, there is no guarantee that the ia64 PAGE_SIZE
is 2^14, though whether liblustre really cares is another matter.

I've been having an on going conversation on lkml about it and they
really say, "use getpagesize()" but lustre uses PAGE_MASK PAGE_SHIFT
and all the other defines in your userspace code as well. So the first
part of the patch is what should be happening and the second part is
fast hack to get it to build with a 'safe' value for the page size.
Really the correct fix would be to obtain the value of PAGE_SIZE via
getpagesize() then create some functions to get PAGE_MASK and
PAGE_SHIFT from the value returned by getpagesize(). At least that's
what I'd do...

Thanks,
- David Brown

_______________________________________________
Lustre-discuss mailing list
[email protected]
https://mail.clusterfs.com/mailman/listinfo/lustre-discuss

Reply via email to