I don't think we need the declaration of ADIOI_LUSTRE_IOContig() immediately before the function declaration.
I seem to recall some history of complaints from certain compilers regarding the missing of prototypes. I don't remember the exact detail now. So I just put it there. If removing it would be find for all cases, I am all for it.
Is there a benefit to have such wrapper functions, or should we just reference ADIOI_GEN_WriteStridedColl() directly in the method table ADIO_LUSTRE_operations?
Right now, no. I wanted to put a different collective IO algorithm there. But it is a little more involved and also needs more testing. So these wrappers are no more than stubs here...
It would be cleaner to put these declarations into ad_lustre.h (which is included in all the lustre .c files so the prototypes can be verified) and then include that header here directly. Having prototypes that are not checked against the actual functions can allow bugs to be introduced silently.
Agreed. I had that thought when I deleted the other ones here. But forgot to move them at the end.
Thanks for your quick comments. --Weikuan
Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.
_______________________________________________ Lustre-discuss mailing list [email protected] https://mail.clusterfs.com/mailman/listinfo/lustre-discuss
