I have to echo some of the comments of Chris Morrone. The in-line comments in Gerrit do not appear in the "expanded" view, and need to be found individually in the various patches. Having 3 lines of context plus the comments is enough for most cases, and if not then a URL to the actual comment would be great.
While the linking from Gerrit back to Jira is good (due to embedded "LU-nnn" link in patch summary line) it is not so easy to find which changes in Gerrit are open from the Jira ticket. Sometimes there are multiple changes open for a single bug, either by accident (forgetting the Change-Id) or on purpose. Having a single comment in Jira for each open change would be good. I also agree that allowing an entire change to be visible on a single page would be helpful. I user to pre-load a bunch of patches from bugzilla into my browser before a flight, but with Gerrit that isn't really practical due to the number of tabs it would create. That said, I like that Gerrit is a "gatekeeper" and ensures that what is inspected is also what is tested and landed, even if it means that patches sometimes have to go through multiple review cycles for trivial changes. Being able to compare patches against previous versions in Gerrit speeds up the process of reviewing new versions of a change, but it is complicated if the "base" version of the patch is changed. At that point it will also show what gas changed between the base versions as if it were part of the patch, which is confusing. It would be better to limit the output to only the code that was modified in the two changes. Cheers, Andreas On 2011-05-23, at 11:06 AM, Chris Gearing <ch...@whamcloud.com> wrote: > We now have a whole kit of tools [Jira, Gerrit, Jenkins and Maloo] used > for tracking, reviewing and testing of code that are being used for the > development of Lustre. A lot of time has been spent integrating and > connecting them appropriately but as with anything the key is to > continuously look for ways to improve what we have and how it works. > > So my question is what do people think of the tools as they stand today > and how can we improve them moving forwards. if people can respond to > lustre-discuss then I'll correlate the outcome of any discussions and > then create a Wiki page that can form some plan for improvement. > > Please be as descriptive as possible in your replies and take into > account that I and others have no experience of Lustre past so if you > liked something prior to the current tools you'll need to help me and > them understand the details. > > Thanks > > Chris > > --- > Chris Gearing > Snr Engineer > Whamcloud. Inc. > > > _______________________________________________ > Lustre-discuss mailing list > Lustre-discuss@lists.lustre.org > http://lists.lustre.org/mailman/listinfo/lustre-discuss _______________________________________________ Lustre-discuss mailing list Lustre-discuss@lists.lustre.org http://lists.lustre.org/mailman/listinfo/lustre-discuss
