For what it is worth since the two issues were already closed I agree with both decisions.
On Saturday, October 4, 2014 11:38:52 AM UTC+2, Martin Croome wrote: > > Hi Tim > > I'll take a look at this. I'm still waiting and really want to get going > on this this week! I've integrated the new luv/libuv into my build so that > I don't waste any time. I see some very small issues which generate > avoidable patches for me: > > 1) Could you support out of tree builds of libuv in your Makefiles? I'm > using a cross compile toolchain and I need to build everything out of tree > to have a little more control on what is going on. > > 2) In utils.c. Could you cast lua_integer to long int in this printf. I > get a warning since lua_integer is defined as ptrdiff_t which is not > necessarily long int: > > case LUA_TNUMBER: > fprintf(stderr, " %d %s %ld\n", i, lua_typename(L, type), *(long > int)* lua_tointeger(L, i)); > break; > > There are a couple of uninitialized variable warning still cropping up but > I guess you are seeing those as well. > > Cheers > > On Friday, October 3, 2014 7:33:22 PM UTC+2, Tim Caswell wrote: >> >> I have a couple questions for the API style in luv. I've recently >> rewrote luv to use the latest version of libuv that's about to be released >> as 1.0. I've settled on a good model for the callbacks and gc lifetimes of >> objects, but I have a couple quick questions about constant casing and >> callback function position. >> >> https://github.com/luvit/luv/issues/66 >> https://github.com/luvit/luv/issues/67 >> >> I'm currently writing automated unit tests and docs for luv and will soon >> release the new version and start integrating it into luvit via the luvi >> project. >> >> -Tim Caswell >> > -- You received this message because you are subscribed to the Google Groups "luvit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
