So, we restore last changes in their original form (number 1)? Do you want I do 
it? 
  
====================================
Frédéric BERNON 
HYMATOM SA 
Chef de projet informatique 
Microsoft Certified Professional 
Tél. : +33 (0)4-67-87-61-10 
Fax. : +33 (0)4-67-70-85-44 
Email : [EMAIL PROTECTED] 
Web Site : http://www.hymatom.fr 
====================================
P Avant d'imprimer, penser à l'environnement
 


-----Message d'origine-----
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Kieran Mansley
Envoyé : mardi 28 août 2007 10:22
À : Mailing list for lwIP users
Objet : Re: [lwip-users] Bug in inet_chksum_pseudo() produces 
badchecksum(Paradigm C++)


On Tue, 2007-08-28 at 10:17 +1200, David Empson wrote:

> Performance issues aside, if I was reading code which did a "greater 
> than
> zero" test I would immediately be wondering what was special about the value 
> being negative, then discover the 'acc' variable was unsigned, then wonder 
> why someone had written it using greater-than instead of not-equal.
> 
> My opinion (for what it is worth) is that LWIP should stick with 
> either the
> original form (number 1) or the more explicit form (number 2) which has 
> already been checked in, but Dave should patch his own copy to work around 
> the bug in his compiler.

I agree.

Kieran



_______________________________________________
lwip-users mailing list
[email protected] http://lists.nongnu.org/mailman/listinfo/lwip-users
BEGIN:VCARD
VERSION:2.1
N:BERNON;Frédéric;;M.
FN:Frédéric BERNON
ORG:HYMATOM SA;Recherche et Développement
TITLE:Chef de projet informatique
TEL;WORK;VOICE:04-67-87-61-10
TEL;WORK;FAX:04-67-70-85-44
ADR;WORK;ENCODING=QUOTED-PRINTABLE:;23;Zone Industrielle=0D=0A175 rue de Massacan;VENDARGUES;;34740;FRANCE;
LABEL;WORK;ENCODING=QUOTED-PRINTABLE:23=0D=0AZone Industrielle=0D=0A175 rue de Massacan=0D=0AVENDARGUES 34740=0D=
=0AFrance
URL;WORK:http://www.hymatom.fr
ROLE:Chef de projet informatique
EMAIL;PREF;INTERNET:[EMAIL PROTECTED]
REV:20020404T083210Z
END:VCARD
_______________________________________________
lwip-users mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/lwip-users

Reply via email to