Art R. wrote:
Just trying to make lwIP as good as it can be.

Don't know if you would consider this, but ...

tcp.c (current 1.3.0)
line 315:   pcb->mss = (TCP_MSS > 536) ? 536 : TCP_MSS;
line 995:   pcb->mss = (TCP_MSS > 536) ? 536 : TCP_MSS;
Both TCP_MSS and 536 are constants. The compare could be done at compile
time in a #if rather than in compiled code at runtime.

Every compiler would optimise away that expression.

Jifl
--
eCosCentric Limited      http://www.eCosCentric.com/     The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK.       Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["The best things in life aren't things."]------      Opinions==mine


_______________________________________________
lwip-users mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/lwip-users

Reply via email to