I suggested once before that before the closing brace of the 'if (pcb == NULL)' in tcp_alloc one could add something like:
if (pcb != NULL) // Timewait PCB was freed above MEMP_STATS_DEC(err, MEMP_TCP_PCB_LISTEN); I think (i.e. IMO) err counts are fatal. In this case we're counting an error that was able to be recovered - is that really fatal? Bill >-----Original Message----- >From: [email protected] >[mailto:[email protected]] On >Behalf Of [email protected] >Sent: Tuesday, July 28, 2009 3:55 PM >To: Mailing list for lwIP users >Subject: Re: [lwip-users] TCP causing out of mem pool [RAW] > >Roger Cover wrote: >> Howdy Folks, >> >> In terms of the message, perhaps a more clear message would be in >order. >> Something like: >> >> No free PCBs. Using a TIME_WAIT PCB. >> > >That's what I thought of. The problem (and why it won't make it into >1.3.1) is that the current message is a generic message emitted in >memp_malloc(), which doesn't know that the failure isn't fatal to TCP. >Nevertheless, it's confusing users. > >Simon > > >_______________________________________________ >lwip-users mailing list >[email protected] >http://lists.nongnu.org/mailman/listinfo/lwip-users _______________________________________________ lwip-users mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/lwip-users
