On Tue, Jan 21, 2014 at 11:38 PM, Serge Hallyn <[email protected]> wrote: > Quoting Stéphane Graber ([email protected]): >> On Tue, Jan 21, 2014 at 09:36:06PM -0500, S.Çağlar Onur wrote: >> > On Tue, Jan 21, 2014 at 6:41 PM, Serge Hallyn <[email protected]> >> > wrote: >> > > Quoting S.Çağlar Onur ([email protected]): >> > >> Based on Stéphane's suggestion, those two API methods now; >> > >> >> > >> * fork a new process, >> > >> * switch to appropriate namespace(s), >> > >> * do what we want, >> > >> * return the data over a pipe to the parent which returns the result to >> > >> the original caller. >> > >> >> > >> For the whole thread please see; >> > >> >> > >> >> > >> https://lists.linuxcontainers.org/pipermail/lxc-devel/2014-January/007362.html >> > >> >> > >> This patch also makes lxc-ls and lxc-info call those functions. >> > >> >> > >> I'm adding Stéphane as an author here since both the idea as well as >> > >> the initial setns code come from him. >> > >> >> > >> Author: S.Çağlar Onur <[email protected]> >> > >> Author: Stéphane Graber <[email protected]> >> > >> Signed-off-by: S.Çağlar Onur <[email protected]> >> > > >> > > Thanks, looks good except for two issues below. With those fixed, >> > > >> > > Acked-by: Serge E. Hallyn <[email protected]> >> > >> > I believe Stéphane fixed them while pushing :) >> >> I did indeed and also updated the ERROR messages to be a bit more >> relevant (they were mentioning template creation). > > Great, thanks guys. I"ll figure out what's going on with > unprivileged lxc-start using cgmanager tomorrow.
Thanks Serge, if it helps it looks like cgroup_settings variable in setup_limits@src/lxc/cgmanager.c fails at lxc_list_empty test but I couldn't figured out why. > -serge > _______________________________________________ > lxc-devel mailing list > [email protected] > http://lists.linuxcontainers.org/listinfo/lxc-devel -- S.Çağlar Onur <[email protected]> _______________________________________________ lxc-devel mailing list [email protected] http://lists.linuxcontainers.org/listinfo/lxc-devel
