If the user explicitly asks for a snapshot clone (in which case maybe_snap is not set), we cannot abide this currently. Rather than exit later with more cryptic error messages, exit out early.
Signed-off-by: Serge Hallyn <[email protected]> --- src/lxc/bdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 2c3388f..09b7ca7 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -2101,6 +2101,11 @@ struct bdev *bdev_copy(struct lxc_container *c0, const char *cname, /* check for privilege */ if (am_unpriv()) { + if (snap && !maybe_snap) { + ERROR("Unprivileged users cannot snapshot"); + bdev_put(orig); + return NULL; + } if (bdevtype && strcmp(bdevtype, "dir") != 0) { ERROR("Unprivileged users can only make dir copy-clones"); bdev_put(orig); -- 1.8.5.3 _______________________________________________ lxc-devel mailing list [email protected] http://lists.linuxcontainers.org/listinfo/lxc-devel
