On Wed, Aug 06, 2014 at 10:10:44PM +0000, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On Wed, Aug 06, 2014 at 05:30:58PM +0000, Serge Hallyn wrote: > > > Some time ago, lxc.console was changed to require a device. lxc-start > > > gained an lxc console logfile argument, but this was not supported > > > through the container config. > > > > > > This patch adds the option through container config as > > > 'lxc.console.logfile'. > > > This allows for instance cloud providers to configure all containers to > > > log the consoles. > > > > > > > The patch seems incomplete to me, you're missing clear_config_item, > > get_config_item and save_config support at least. > > Yeah - though we don't need save_config for it.
Why not? What if I set it in my container's config, then call save_config() over the API, won't I loose the setting then? Same thing if I clone a container that has the key set. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com
signature.asc
Description: Digital signature
_______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel
