Hi, thanks.
the trivial ones look almost all correct to me - the only worry I have is about adding -p to the help output. -p is not meant to be used by users, only by lxc-create in calling the templates. It looks like you only added that to the ubuntu template (so that's the only part of those that I object to). Actually a patch to remove '-p|--path' from the help statement in all other templates would be appreciated. The less controversial one is adding mask-tmp to the fedora template. It looks fine to me, but that should go separately to mwarfield, our fedora template maintainer :) -serge Quoting Michael Adam ([email protected]): > For those who prefer it, the patches can also be > fetched via git from branch master of > https://github.com/obnoxxx/lxc.git > > Cheers - Michael > > On 2015-01-08 at 11:05 +0100, Michael Adam wrote: > > > > Hi, > > > > below find the output of "git format-patch --stdout " > > of a series of trivial patches to fix some minor issues > > in the template scripts. > > > > The final patch adds a new parameter to the fedora > > template: "--mask-tmp". This is what I actually only > > wanted to do, but I found some issues in the parsing of > > options and help text, fixed them while at it and > > was careless enough to check several other templates > > for similar flaws. > > > > The reason for the --mask-tmp is to be able to prevent > > systemd from over-mounting /tmp with tmpfs in the container. > > My current use-case is that I want to be able to use > > vagrant-cachier with vagrant-lxc. > > > > Thanks for review / comments / push, ... > > > > Cheers - Michael > _______________________________________________ > lxc-devel mailing list > [email protected] > http://lists.linuxcontainers.org/listinfo/lxc-devel _______________________________________________ lxc-devel mailing list [email protected] http://lists.linuxcontainers.org/listinfo/lxc-devel
