On Mon, Jan 19, 2015 at 09:44:09PM +0100, Michael Adam wrote: > On 2015-01-19 at 15:33 -0500, Stéphane Graber wrote: > > On Mon, Jan 19, 2015 at 09:25:48PM +0100, Michael Adam wrote: > > > Hi, > > > > > > just two minor comments inline below, > > > looks good to me, otherwise. > > > > > > Cheers - Michael > > > > > > On 2015-01-19 at 15:16 -0500, Stéphane Graber wrote: > > > > > > > @@ -0,0 +1,6 @@ > > > > +This directory can be used by packages and users to dump LXC > > > > > > Do you mean packages or packagers? > > > > Packages as in the result of the packager's work. > > Ok makes sense. :-) > > > > > +configuration snippets which will then be used by all containers using > > > > +the common.conf configuration file (directlry or indirectly). > > > > > > directly > > > > Oops, indeed. > > > > I'll fix that one on apply. > > Ok. > > While we are at it: > How does the review process work for lxc? > (I did not find it written down in the tree > but maybe that was just me..) > From what I've seen so far each patch needs Ack > by one maintainer (other than the author), or > are there other policies? Is the MAINTAINERS file > up-to-date?
So we are currently 4 people with commit rights: - Daniel Lezcano (original author of LXC) - Serge Hallyn - Dwight Engen - me We don't strictly require an ack by one of the other committers though we've been trying to stick to this in the past. MAINTAINERS should probably be updated to include Dwight, I'll do that now. > > Thanks - Michael -- Stéphane Graber Ubuntu developer http://www.ubuntu.com
signature.asc
Description: Digital signature
_______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel
