The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/919

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Currently, LXC successfully builds out-of-tree (at least it looks so), but `make install` fails, because it tries to install some non-generated files without full path. Prepending "$(srcdir)/" fixes it, and also doesn't break in-source build.

Signed-off-by: Aleksandr Mezin <[email protected]>
From a5c28c86f56835fa3e0915558e05390dd0a79580 Mon Sep 17 00:00:00 2001
From: Aleksandr Mezin <[email protected]>
Date: Fri, 25 Mar 2016 19:30:49 +0600
Subject: [PATCH] Fix installation of out-of-tree (VPATH) builds

Signed-off-by: Aleksandr Mezin <[email protected]>
---
 config/apparmor/Makefile.am     | 16 ++++++++--------
 config/init/upstart/Makefile.am |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/config/apparmor/Makefile.am b/config/apparmor/Makefile.am
index 887d16c..71dbe15 100644
--- a/config/apparmor/Makefile.am
+++ b/config/apparmor/Makefile.am
@@ -18,14 +18,14 @@ install-apparmor:
        $(MKDIR_P) $(DESTDIR)$(sysconfdir)/apparmor.d/
        $(MKDIR_P) $(DESTDIR)$(sysconfdir)/apparmor.d/abstractions/lxc/
        $(MKDIR_P) $(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
-       $(INSTALL_DATA) abstractions/container-base 
$(DESTDIR)$(sysconfdir)/apparmor.d/abstractions/lxc/
-       $(INSTALL_DATA) abstractions/start-container 
$(DESTDIR)$(sysconfdir)/apparmor.d/abstractions/lxc/
-       $(INSTALL_DATA) profiles/lxc-default 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
-       $(INSTALL_DATA) profiles/lxc-default-cgns 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
-       $(INSTALL_DATA) profiles/lxc-default-with-mounting 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
-       $(INSTALL_DATA) profiles/lxc-default-with-nesting 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
-       $(INSTALL_DATA) lxc-containers $(DESTDIR)$(sysconfdir)/apparmor.d/
-       $(INSTALL_DATA) usr.bin.lxc-start $(DESTDIR)$(sysconfdir)/apparmor.d/
+       $(INSTALL_DATA) $(srcdir)/abstractions/container-base 
$(DESTDIR)$(sysconfdir)/apparmor.d/abstractions/lxc/
+       $(INSTALL_DATA) $(srcdir)/abstractions/start-container 
$(DESTDIR)$(sysconfdir)/apparmor.d/abstractions/lxc/
+       $(INSTALL_DATA) $(srcdir)/profiles/lxc-default 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
+       $(INSTALL_DATA) $(srcdir)/profiles/lxc-default-cgns 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
+       $(INSTALL_DATA) $(srcdir)/profiles/lxc-default-with-mounting 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
+       $(INSTALL_DATA) $(srcdir)/profiles/lxc-default-with-nesting 
$(DESTDIR)$(sysconfdir)/apparmor.d/lxc/
+       $(INSTALL_DATA) $(srcdir)/lxc-containers 
$(DESTDIR)$(sysconfdir)/apparmor.d/
+       $(INSTALL_DATA) $(srcdir)/usr.bin.lxc-start 
$(DESTDIR)$(sysconfdir)/apparmor.d/
 
 uninstall-apparmor:
        rm -f $(DESTDIR)$(sysconfdir)/apparmor.d/usr.bin.lxc-start
diff --git a/config/init/upstart/Makefile.am b/config/init/upstart/Makefile.am
index 916b850..5552d32 100644
--- a/config/init/upstart/Makefile.am
+++ b/config/init/upstart/Makefile.am
@@ -4,7 +4,7 @@ if INIT_SCRIPT_UPSTART
 install-upstart: lxc.conf lxc-instance.conf lxc-net.conf
        $(MKDIR_P) $(DESTDIR)$(sysconfdir)/init/
        $(INSTALL_DATA) lxc.conf $(DESTDIR)$(sysconfdir)/init/
-       $(INSTALL_DATA) lxc-instance.conf $(DESTDIR)$(sysconfdir)/init/
+       $(INSTALL_DATA) $(srcdir)/lxc-instance.conf 
$(DESTDIR)$(sysconfdir)/init/
        $(INSTALL_DATA) lxc-net.conf $(DESTDIR)$(sysconfdir)/init/
 
 uninstall-upstart:
_______________________________________________
lxc-devel mailing list
[email protected]
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to