The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxd/pull/4515
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
When one selects the `no` option when setting up MAAS and then selects the option to set up a custom bridge, the prompt still appears to ask if the interface is connected to MAAS. This is due to the value `config.Config["maas.api.url"]` is set to nil and not to `""`.
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<link rel="dns-prefetch" href="https://assets-cdn.github.com";>
<link rel="dns-prefetch" href="https://avatars0.githubusercontent.com";>
<link rel="dns-prefetch" href="https://avatars1.githubusercontent.com";>
<link rel="dns-prefetch" href="https://avatars2.githubusercontent.com";>
<link rel="dns-prefetch" href="https://avatars3.githubusercontent.com";>
<link rel="dns-prefetch" href="https://github-cloud.s3.amazonaws.com";>
<link rel="dns-prefetch" href="https://user-images.githubusercontent.com/";>
<link crossorigin="anonymous" media="all" rel="stylesheet"
href="https://assets-cdn.github.com/assets/frameworks-482d575624bca06cd70dd916252519ab.css";
/>
<link crossorigin="anonymous" media="all" rel="stylesheet"
href="https://assets-cdn.github.com/assets/github-98f0e9b94fdbb019dde1c304f706c1a4.css";
/>
<link crossorigin="anonymous" media="all" rel="stylesheet"
href="https://assets-cdn.github.com/assets/site-f6ae432608e23ad57af9343d2ea3d19d.css";
/>
<meta name="viewport" content="width=device-width">
<title>lxd init: fix maas.api.url check when setting up existing bridge by
dnegreira · Pull Request #4515 · lxc/lxd · GitHub</title>
<meta name="description" content="When one selects the no option when
setting up MAAS and then selects the option to set up a custom bridge, the
prompt still appears to ask if the interface is connected to MAAS. This is due
to the value config.Config["maas.api.url"] is set to nil and not to
"".">
<link rel="search" type="application/opensearchdescription+xml"
href="/opensearch.xml" title="GitHub">
<link rel="fluid-icon" href="https://github.com/fluidicon.png"; title="GitHub">
<meta property="fb:app_id" content="1401488693436528">
<meta property="og:image"
content="https://avatars2.githubusercontent.com/u/5215383?s=400&v=4";
/><meta property="og:site_name" content="GitHub" /><meta property="og:type"
content="object" /><meta property="og:title" content="lxd init: fix
maas.api.url check when setting up existing bridge by dnegreira · Pull Request
#4515 · lxc/lxd" /><meta property="og:url"
content="https://github.com/lxc/lxd/pull/4515"; /><meta
property="og:description" content="When one selects the no option when setting
up MAAS and then selects the option to set up a custom bridge, the prompt still
appears to ask if the interface is connected to MAAS. This is due to the ..." />
<link rel="assets" href="https://assets-cdn.github.com/";>
<meta name="pjax-timeout" content="1000">
<meta name="request-id" content="9D64:6DAD:43487E:83ACA5:5AE76D40"
data-pjax-transient>
<meta name="hovercard-subject-tag" content="pull_request:185041540"
data-pjax-transient>
<meta name="selected-link" value="repo_pulls" data-pjax-transient>
<meta name="google-site-verification"
content="KT5gs8h0wvaagLKAVWq8bbeNwnZZK1r1XQysX3xurLU">
<meta name="google-site-verification"
content="ZzhVyEFwb7w3e0-uOTltm8Jsck2F5StVihD0exw2fsA">
<meta name="google-site-verification"
content="GXs5KoUUkNCoaAZn7wPN-t01Pywp9M3sEjnt_3_ZWPc">
<meta name="google-analytics" content="UA-3769691-2">
<meta name="octolytics-host" content="collector.githubapp.com" /><meta
name="octolytics-app-id" content="github" /><meta name="octolytics-event-url"
content="https://collector.githubapp.com/github-external/browser_event"; /><meta
name="octolytics-dimension-request_id"
content="9D64:6DAD:43487E:83ACA5:5AE76D40" /><meta
name="octolytics-dimension-region_edge" content="iad" /><meta
name="octolytics-dimension-region_render" content="iad" />
<meta name="analytics-location"
content="/<user-name>/<repo-name>/pull_requests/show"
data-pjax-transient="true" />
<meta class="js-ga-set" name="dimension1" content="Logged Out">
<meta name="hostname" content="github.com">
<meta name="user-login" content="">
<meta name="expected-hostname" content="github.com">
<meta name="js-proxy-site-detection-payload"
content="N2ViZDE0N2M4ZWQyOTNiMTI0YTM1ZGZhZDcwNmNlZGRmOGE0OGVkNGJjNDlkNjJkZjk3ZmNjMTY0NzYxZjJkY3x7InJlbW90ZV9hZGRyZXNzIjoiMTQ5LjU2LjE0OC4wIiwicmVxdWVzdF9pZCI6IjlENjQ6NkRBRDo0MzQ4N0U6ODNBQ0E1OjVBRTc2RDQwIiwidGltZXN0YW1wIjoxNTI1MTE2MjI1LCJob3N0IjoiZ2l0aHViLmNvbSJ9">
<meta name="enabled-features"
content="UNIVERSE_BANNER,FREE_TRIALS,MARKETPLACE_INSIGHTS,MARKETPLACE_SELF_SERVE,MARKETPLACE_FREE_APPS,MARKETPLACE_INSIGHTS_CONVERSION_PERCENTAGES">
<meta name="html-safe-nonce"
content="6ab79fa07c08d68fa8120f35be521efbadb1e1a8">
<meta http-equiv="x-pjax-version" content="d51c597727e16d5ba3bc9367e3098ab5">
<style type="text/css" media="screen" id="issue-labels-style">
span.labelstyle-0052cc, .linked-labelstyle-0052cc { background-color:
#0052cc !important; color: #ffffff !important;}.labelstyle-0052cc.selected {
background-color: #0052cc !important; color: #ffffff
!important;}.label-select-menu .labelstyle-0052cc.selected { background:
rgba(0, 82, 204, 0.12) !important; color: #003d99 !important;}
span.labelstyle-006b75, .linked-labelstyle-006b75 { background-color: #006b75
!important; color: #ffffff !important;}.labelstyle-006b75.selected {
background-color: #006b75 !important; color: #ffffff
!important;}.label-select-menu .labelstyle-006b75.selected { background:
rgba(0, 107, 117, 0.12) !important; color: #008b99 !important;}
span.labelstyle-eb6420, .linked-labelstyle-eb6420 { background-color: #eb6420
!important; color: #000000 !important;}.labelstyle-eb6420.selected {
background-color: #eb6420 !important; color: #000000
!important;}.label-select-menu .labelstyle-eb6420.selected { background:
rgba(235, 100, 32, 0.12) !important; color: #994114 !important;}
span.labelstyle-fbca04, .linked-labelstyle-fbca04 { background-color: #fbca04
!important; color: #000000 !important;}.labelstyle-fbca04.selected {
background-color: #fbca04 !important; color: #000000
!important;}.label-select-menu .labelstyle-fbca04.selected { background:
rgba(251, 202, 4, 0.12) !important; color: #997b02 !important;}
span.labelstyle-009800, .linked-labelstyle-009800 { background-color: #009800
!important; color: #000000 !important;}.labelstyle-009800.selected {
background-color: #009800 !important; color: #000000
!important;}.label-select-menu .labelstyle-009800.selected { background:
rgba(0, 152, 0, 0.12) !important; color: #009900 !important;}
span.labelstyle-000000, .linked-labelstyle-000000 { background-color: #000000
!important; color: #ffffff !important;}.labelstyle-000000.selected {
background-color: #000000 !important; color: #ffffff
!important;}.label-select-menu .labelstyle-000000.selected { background:
rgba(247, 247, 247, 1.0) !important; color: #666666 !important;}
span.labelstyle-84b6eb, .linked-labelstyle-84b6eb { background-color: #84b6eb
!important; color: #000000 !important;}.labelstyle-84b6eb.selected {
background-color: #84b6eb !important; color: #000000
!important;}.label-select-menu .labelstyle-84b6eb.selected { background:
rgba(132, 182, 235, 0.12) !important; color: #557699 !important;}
span.labelstyle-5319e7, .linked-labelstyle-5319e7 { background-color: #5319e7
!important; color: #ffffff !important;}.labelstyle-5319e7.selected {
background-color: #5319e7 !important; color: #ffffff
!important;}.label-select-menu .labelstyle-5319e7.selected { background:
rgba(83, 25, 231, 0.12) !important; color: #361099 !important;}
span.labelstyle-d4c5f9, .linked-labelstyle-d4c5f9 { background-color: #d4c5f9
!important; color: #000000 !important;}.labelstyle-d4c5f9.selected {
background-color: #d4c5f9 !important; color: #000000
!important;}.label-select-menu .labelstyle-d4c5f9.selected { background:
rgba(212, 197, 249, 0.12) !important; color: #827999 !important;}
span.labelstyle-fef2c0, .linked-labelstyle-fef2c0 { background-color: #fef2c0
!important; color: #000000 !important;}.labelstyle-fef2c0.selected {
background-color: #fef2c0 !important; color: #000000
!important;}.label-select-menu .labelstyle-fef2c0.selected { background:
rgba(254, 242, 192, 0.12) !important; color: #989173 !important;}
</style>
<link href="https://github.com/lxc/lxd/commits/init_maas_option.atom";
rel="alternate" title="Recent Commits to lxd:init_maas_option"
type="application/atom+xml">
<meta name="description" content="When one selects the no option when setting
up MAAS and then selects the option to set up a custom bridge, the prompt still
appears to ask if the interface is connected to MAAS. This is due to the value
config.Config["maas.api.url"] is set to nil and not to "".">
<meta name="go-import" content="github.com/lxc/lxd git
https://github.com/lxc/lxd.git";>
<meta name="octolytics-dimension-user_id" content="2301756" /><meta
name="octolytics-dimension-user_login" content="lxc" /><meta
name="octolytics-dimension-repository_id" content="26192117" /><meta
name="octolytics-dimension-repository_nwo" content="lxc/lxd" /><meta
name="octolytics-dimension-repository_public" content="true" /><meta
name="octolytics-dimension-repository_is_fork" content="false" /><meta
name="octolytics-dimension-repository_network_root_id" content="26192117"
/><meta name="octolytics-dimension-repository_network_root_nwo"
content="lxc/lxd" /><meta
name="octolytics-dimension-repository_explore_github_marketplace_ci_cta_shown"
content="false" />
<meta name="browser-stats-url"
content="https://api.github.com/_private/browser/stats";>
<meta name="browser-errors-url"
content="https://api.github.com/_private/browser/errors";>
<link rel="mask-icon" href="https://assets-cdn.github.com/pinned-octocat.svg";
color="#000000">
<link rel="icon" type="image/x-icon" class="js-site-favicon"
href="https://assets-cdn.github.com/favicon.ico";>
<meta name="theme-color" content="#1e2327">
<link rel="manifest" href="/manifest.json" crossOrigin="use-credentials">
</head>
<body class="logged-out env-production">
<div class="position-relative js-header-wrapper ">
<a href="#start-of-content" tabindex="1" class="px-2 py-4 bg-blue
text-white show-on-focus js-skip-to-content">Skip to content</a>
<div id="js-pjax-loader-bar" class="pjax-loader-bar"><div
class="progress"></div></div>
<header class="Header header-logged-out position-relative f4 py-3"
role="banner">
<div class="container-lg d-flex px-3">
<div class="d-flex flex-justify-between flex-items-center">
<a class="header-logo-invertocat my-0" href="https://github.com/";
aria-label="Homepage" data-ga-click="(Logged out) Header, go to homepage,
icon:logo-wordmark">
<svg height="32" class="octicon octicon-mark-github" viewBox="0 0 16
16" version="1.1" width="32" aria-hidden="true"><path fill-rule="evenodd" d="M8
0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38
0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01
1.08.58 1.23.82.72 1.21 1.87.87
2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95
0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18
1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08
2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0
1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0 0 16
8c0-4.42-3.58-8-8-8z"/></svg>
</a>
</div>
<div class="HeaderMenu HeaderMenu--bright d-flex flex-justify-between
flex-auto">
<nav class="mt-0">
<ul class="d-flex list-style-none">
<li class="ml-2">
<a class="js-selected-navigation-item HeaderNavlink px-0 py-2
m-0" data-ga-click="Header, click, Nav menu - item:features"
data-selected-links="/features /features/project-management
/features/code-review /features/project-management /features/integrations
/features" href="/features">
Features
</a> </li>
<li class="ml-4">
<a class="js-selected-navigation-item HeaderNavlink px-0 py-2
m-0" data-ga-click="Header, click, Nav menu - item:business"
data-selected-links="/business /business/security /business/customers
/business" href="/business">
Business
</a> </li>
<li class="ml-4">
<a class="js-selected-navigation-item HeaderNavlink px-0 py-2
m-0" data-ga-click="Header, click, Nav menu - item:explore"
data-selected-links="/explore /trending /trending/developers /integrations
/integrations/feature/code /integrations/feature/collaborate
/integrations/feature/ship showcases showcases_search showcases_landing
/explore" href="/explore">
Explore
</a> </li>
<li class="ml-4">
<a class="js-selected-navigation-item HeaderNavlink px-0
py-2 m-0" data-ga-click="Header, click, Nav menu - item:marketplace"
data-selected-links=" /marketplace" href="/marketplace">
Marketplace
</a> </li>
<li class="ml-4">
<a class="js-selected-navigation-item HeaderNavlink px-0 py-2
m-0" data-ga-click="Header, click, Nav menu - item:pricing"
data-selected-links="/pricing /pricing/developer /pricing/team
/pricing/business-hosted /pricing/business-enterprise /pricing" href="/pricing">
Pricing
</a> </li>
</ul>
</nav>
<div class="d-flex">
<div class="d-lg-flex flex-items-center mr-3">
<div class="header-search scoped-search site-scoped-search
js-site-search" role="search">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form
class="js-site-search-form" data-scope-type="Repository"
data-scope-id="26192117" data-scoped-search-url="/lxc/lxd/search"
data-unscoped-search-url="/search" action="/lxc/lxd/search"
accept-charset="UTF-8" method="get"><input name="utf8" type="hidden"
value="✓" />
<label class="form-control header-search-wrapper
js-chromeless-input-container">
<a class="header-search-scope no-underline"
href="/lxc/lxd/pull/4515">This repository</a>
<input type="text"
class="form-control header-search-input js-site-search-focus
js-site-search-field is-clearable"
data-hotkey="s,/"
name="q"
value=""
placeholder="Search"
aria-label="Search this repository"
data-unscoped-placeholder="Search GitHub"
data-scoped-placeholder="Search"
autocapitalize="off"
>
<input type="hidden" class="js-site-search-type-field" name="type" >
</label>
</form></div>
</div>
<span class="d-inline-block">
<div class="HeaderNavlink px-0 py-2 m-0">
<a class="text-bold text-white no-underline"
href="/login?return_to=%2Flxc%2Flxd%2Fpull%2F4515" data-ga-click="(Logged out)
Header, clicked Sign in, text:sign-in">Sign in</a>
<span class="text-gray">or</span>
<a class="text-bold text-white no-underline"
href="/join?source=header-repo" data-ga-click="(Logged out) Header, clicked
Sign up, text:sign-up">Sign up</a>
</div>
</span>
</div>
</div>
</div>
</header>
</div>
<div id="start-of-content" class="show-on-focus"></div>
<div id="js-flash-container">
</div>
<div role="main" class="application-main ">
<div itemscope itemtype="http://schema.org/SoftwareSourceCode"; class="">
<div id="js-repo-pjax-container" data-pjax-container >
<!-- base sha1: "5ee77d94e3244a6d95f6f63903093819cf2dc90e" -->
<!-- head sha1: "65a77b6f2f08eb8f8f9a6c7cb21fd4e4a0110731" -->
<div class="pagehead repohead instapaper_ignore readability-menu
experiment-repo-nav ">
<div class="repohead-details-container clearfix container">
<ul class="pagehead-actions">
<li>
<a href="/login?return_to=%2Flxc%2Flxd"
class="btn btn-sm btn-with-count tooltipped tooltipped-n"
aria-label="You must be signed in to watch a repository" rel="nofollow">
<svg class="octicon octicon-eye" viewBox="0 0 16 16" version="1.1"
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M8.06
2C3 2 0 8 0 8s3 6 8.06 6C13 14 16 8 16 8s-3-6-7.94-6zM8 12c-2.2 0-4-1.78-4-4
0-2.2 1.8-4 4-4 2.22 0 4 1.8 4 4 0 2.22-1.78 4-4 4zm2-4c0 1.11-.89 2-2 2-1.11
0-2-.89-2-2 0-1.11.89-2 2-2 1.11 0 2 .89 2 2z"/></svg>
Watch
</a>
<a class="social-count" href="/lxc/lxd/watchers"
aria-label="179 users are watching this repository">
179
</a>
</li>
<li>
<a href="/login?return_to=%2Flxc%2Flxd"
class="btn btn-sm btn-with-count tooltipped tooltipped-n"
aria-label="You must be signed in to star a repository" rel="nofollow">
<svg class="octicon octicon-star" viewBox="0 0 14 16" version="1.1"
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M14
6l-4.9-.64L7 1 4.9 5.36 0 6l3.6 3.26L2.67 14 7 11.67 11.33
14l-.93-4.74z"/></svg>
Star
</a>
<a class="social-count js-social-count" href="/lxc/lxd/stargazers"
aria-label="1750 users starred this repository">
1,750
</a>
</li>
<li>
<a href="/login?return_to=%2Flxc%2Flxd"
class="btn btn-sm btn-with-count tooltipped tooltipped-n"
aria-label="You must be signed in to fork a repository" rel="nofollow">
<svg class="octicon octicon-repo-forked" viewBox="0 0 10 16"
version="1.1" width="10" height="16" aria-hidden="true"><path
fill-rule="evenodd" d="M8 1a1.993 1.993 0 0 0-1 3.72V6L5 8 3 6V4.72A1.993 1.993
0 0 0 2 1a1.993 1.993 0 0 0-1 3.72V6.5l3 3v1.78A1.993 1.993 0 0 0 5 15a1.993
1.993 0 0 0 1-3.72V9.5l3-3V4.72A1.993 1.993 0 0 0 8 1zM2 4.2C1.34 4.2.8 3.65.8
3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zm3 10c-.66
0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2
1.2zm3-10c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0
.65-.55 1.2-1.2 1.2z"/></svg>
Fork
</a>
<a href="/lxc/lxd/network" class="social-count"
aria-label="430 users forked this repository">
430
</a>
</li>
</ul>
<h1 class="public ">
<svg class="octicon octicon-repo" viewBox="0 0 12 16" version="1.1"
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M4
9H3V8h1v1zm0-3H3v1h1V6zm0-2H3v1h1V4zm0-2H3v1h1V2zm8-1v12c0 .55-.45 1-1
1H6v2l-1.5-1.5L3 16v-2H1c-.55 0-1-.45-1-1V1c0-.55.45-1 1-1h10c.55 0 1 .45 1
1zm-1 10H1v2h2v-1h3v1h5v-2zm0-10H2v9h9V1z"/></svg>
<span class="author" itemprop="author"><a class="url fn" rel="author"
href="/lxc">lxc</a></span><!--
--><span class="path-divider">/</span><!--
--><strong itemprop="name"><a data-pjax="#js-repo-pjax-container"
href="/lxc/lxd">lxd</a></strong>
</h1>
</div>
<nav class="reponav js-repo-nav js-sidenav-container-pjax container"
itemscope
itemtype="http://schema.org/BreadcrumbList";
role="navigation"
data-pjax="#js-repo-pjax-container">
<span itemscope itemtype="http://schema.org/ListItem";
itemprop="itemListElement">
<a class="js-selected-navigation-item reponav-item" itemprop="url"
data-hotkey="g c" data-selected-links="repo_source repo_downloads repo_commits
repo_releases repo_tags repo_branches repo_packages /lxc/lxd" href="/lxc/lxd">
<svg class="octicon octicon-code" viewBox="0 0 14 16" version="1.1"
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M9.5 3L8
4.5 11.5 8 8 11.5 9.5 13 14 8 9.5 3zm-5 0L0 8l4.5 5L6 11.5 2.5 8 6 4.5 4.5
3z"/></svg>
<span itemprop="name">Code</span>
<meta itemprop="position" content="1">
</a> </span>
<span itemscope itemtype="http://schema.org/ListItem";
itemprop="itemListElement">
<a itemprop="url" data-hotkey="g i" class="js-selected-navigation-item
reponav-item" data-selected-links="repo_issues repo_labels repo_milestones
/lxc/lxd/issues" href="/lxc/lxd/issues">
<svg class="octicon octicon-issue-opened" viewBox="0 0 14 16"
version="1.1" width="14" height="16" aria-hidden="true"><path
fill-rule="evenodd" d="M7 2.3c3.14 0 5.7 2.56 5.7 5.7s-2.56 5.7-5.7 5.7A5.71
5.71 0 0 1 1.3 8c0-3.14 2.56-5.7 5.7-5.7zM7 1C3.14 1 0 4.14 0 8s3.14 7 7 7
7-3.14 7-7-3.14-7-7-7zm1 3H6v5h2V4zm0 6H6v2h2v-2z"/></svg>
<span itemprop="name">Issues</span>
<span class="Counter">48</span>
<meta itemprop="position" content="2">
</a> </span>
<span itemscope itemtype="http://schema.org/ListItem";
itemprop="itemListElement">
<a data-hotkey="g p" itemprop="url" class="js-selected-navigation-item
selected reponav-item" data-selected-links="repo_pulls checks /lxc/lxd/pulls"
href="/lxc/lxd/pulls">
<svg class="octicon octicon-git-pull-request" viewBox="0 0 12 16"
version="1.1" width="12" height="16" aria-hidden="true"><path
fill-rule="evenodd" d="M11 11.28V5c-.03-.78-.34-1.47-.94-2.06C9.46 2.35 8.78
2.03 8 2H7V0L4 3l3 3V4h1c.27.02.48.11.69.31.21.2.3.42.31.69v6.28A1.993 1.993 0
0 0 10 15a1.993 1.993 0 0 0 1-3.72zm-1 2.92c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2
1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zM4 3c0-1.11-.89-2-2-2a1.993
1.993 0 0 0-1 3.72v6.56A1.993 1.993 0 0 0 2 15a1.993 1.993 0 0 0
1-3.72V4.72c.59-.34 1-.98 1-1.72zm-.8 10c0 .66-.55 1.2-1.2 1.2-.65
0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2zM2 4.2C1.34 4.2.8
3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2
1.2z"/></svg>
<span itemprop="name">Pull requests</span>
<span class="Counter">3</span>
<meta itemprop="position" content="3">
</a> </span>
<a class="js-selected-navigation-item reponav-item"
data-selected-links="repo_graphs repo_contributors dependency_graph pulse
/lxc/lxd/pulse" href="/lxc/lxd/pulse">
<svg class="octicon octicon-graph" viewBox="0 0 16 16" version="1.1"
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M16
14v1H0V0h1v14h15zM5 13H3V8h2v5zm4 0H7V3h2v10zm4 0h-2V6h2v7z"/></svg>
Insights
</a>
</nav>
</div>
<div class="container new-discussion-timeline experiment-repo-nav ">
<div class="repository-content ">
<div class="issues-listing" data-pjax>
<div class="signup-prompt-bg rounded-1">
<div class="signup-prompt p-4 text-center mb-4 rounded-1">
<div class="position-relative">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form
action="/site/dismiss_signup_prompt" accept-charset="UTF-8"
method="post"><input name="utf8" type="hidden" value="✓" /><input
type="hidden" name="authenticity_token"
value="mlhzTzZ7u51ETfamfDKOQA4SsPdvbmX5Jh1/wbshz+8kcHGJuSyw/WuzPITKYymnvmS8Cpne39ooTHrNGoNF6w=="
/>
<button type="submit" class="position-absolute top-0 right-0
btn-link link-gray" data-ga-click="(Logged out) Sign up prompt, clicked
Dismiss, text:dismiss">
Dismiss
</button>
</form>
<h3 class="pt-2">Join GitHub today</h3>
<p class="col-6 mx-auto">GitHub is home to over 20 million developers
working together to host and review code, manage projects, and build software
together.</p>
<p class="pb-2">
<a class="btn btn-blue" href="/join?source=prompt-pr-show"
data-ga-click="(Logged out) Sign up prompt, clicked Sign up, text:sign-up">Sign
up</a>
</p>
</div>
</div>
</div>
<div class="clearfix js-issues-results">
<div
id="partial-discussion-header"
class="gh-header js-details-container Details js-socket-channel
js-updatable-content pull request"
data-channel="pull_request:185041540"
data-url="/lxc/lxd/pull/4515/show_partial?partial=pull_requests%2Ftitle">
<div class="gh-header-show ">
<div class="gh-header-actions">
<button type="button" data-facebox="#new_issue_modal" class="btn
btn-sm btn-primary float-right" data-hotkey="c" aria-haspopup="true"
data-ga-click="Issues, create new issue, view:issue_show location:issue_header
style:button logged_in:false">New issue</button>
<div id="new_issue_modal" style="display:none;">
<div class="mt-3 mb-2 text-center">
<svg height="60" class="octicon octicon-comment-discussion text-blue"
viewBox="0 0 16 16" version="1.1" width="60" aria-hidden="true"><path
fill-rule="evenodd" d="M15 1H6c-.55 0-1 .45-1 1v2H1c-.55 0-1 .45-1 1v6c0 .55.45
1 1 1h1v3l3-3h4c.55 0 1-.45 1-1V9h1l3 3V9h1c.55 0 1-.45
1-1V2c0-.55-.45-1-1-1zM9 11H4.5L3 12.5V11H1V5h4v3c0 .55.45 1 1
1h3v2zm6-3h-2v1.5L11.5 8H6V2h9v6z"/></svg>
</div>
<div class="px-4">
<p class="text-center mb-4">
<strong>Have a question about this project?</strong> Sign up for a free
GitHub account to open an issue and contact its maintainers and the community.
</p>
<form class="js-signup-form" autocomplete="off"
action="/join?return_to=%2Flxc%2Flxd%2Fissues%2Fnew" accept-charset="UTF-8"
method="post"><input name="utf8" type="hidden" value="✓" /><input
type="hidden" name="authenticity_token"
value="q+FtcFFpRi3ipMipGHmQr2c2FuWVSXhEXJSsAi1l/Ysp3pRUoyupJc9YJzARaO6vfS/Z+CiWE2kbRDpOkyv7/g=="
/> <auto-check src="/signup_check/username"
csrf="IIUSifnStcui264zVrTPPI5CSK5fb9pEFc9CoQSoOB02nuu7jeduZHMXiuEgkpiHAn7nv7fgmVg9z0Ghykx04Q==">
<dl class="form-group"><dt class="input-label"><label
name="user[login]" data-facebox-id="user-login-issues" autocapitalize="off"
autofocus="autofocus" for="user_login_issues">Pick a
username</label></dt><dd><input name="user[login]"
data-facebox-id="user-login-issues" autocapitalize="off" autofocus="autofocus"
class="form-control" type="text" id="user_login_issues" /></dd></dl>
</auto-check>
<auto-check src="/signup_check/email"
csrf="G8v5eF9LM8ROtvsbJeCmvLzG19hht70K00sbXQNBl1c97qexC4M3KMY8B6PdvE8zy4vRE5BjQa0kiElq2nFl+Q==">
<dl class="form-group"><dt class="input-label"><label
name="user[email]" data-facebox-id="user-email-issues" autocapitalize="off"
for="user_email_issues">Email Address</label></dt><dd><input name="user[email]"
data-facebox-id="user-email-issues" autocapitalize="off" class="form-control"
type="text" id="user_email_issues" /></dd></dl>
</auto-check>
<auto-check src="/signup_check/password"
csrf="PU0av7QnYvE9tjCAE2BbI10DLvgjgtWK2gi24IMOj0Y6RbJ1PKZq0Y/zVODs08btUkbKJDfz+iqhWoMYYrfQaQ==">
<dl class="form-group"><dt class="input-label"><label
name="user[password]" data-facebox-id="user-password-issues"
for="user_password_issues">Password</label></dt><dd><input
name="user[password]" data-facebox-id="user-password-issues"
class="form-control" type="password" id="user_password_issues" /></dd></dl>
</auto-check>
<input type="hidden" name="source" class="js-signup-source"
value="modal-issues">
<input type="text" name="required_field_2b22" id="required_field_2b22"
style="display: none" class="form-control" />
<input type="hidden" name="timestamp" value="1525116225528"
class="form-control" />
<input type="hidden" name="timestamp_secret"
value="f5e3116c31b9cadcbac410aa995dd55a36b56b8998007a31d9f4a0786d8558cc"
class="form-control" />
<button class="btn btn-primary mt-2 btn-block" type="submit"
data-ga-click="(Logged out) New issue modal, clicked Sign up,
text:sign-up">Sign up for GitHub</button>
</form>
<p class="mt-4 text-gray text-center">By clicking “Sign up for
GitHub”, you agree to our <a href="https://help.github.com/terms";
target="_blank">terms of service</a> and
<a href="https://help.github.com/privacy"; target="_blank">privacy
statement</a>. We’ll occasionally send you account related emails.</p>
<p class="mt-4 text-gray text-center">Already on GitHub? <a
href="/login?return_to=%2Flxc%2Flxd%2Fissues%2Fnew" data-ga-click="(Logged out)
New issue modal, clicked Sign in, text:sign-in">Sign in</a> to your account</p>
</div>
</div>
</div>
<h1 class="gh-header-title">
<span class="js-issue-title">
lxd init: fix maas.api.url check when setting up existing bridge
</span>
<span class="gh-header-number">#4515</span>
</h1>
</div>
<div class="TableObject gh-header-meta">
<div class="TableObject-item">
<div class="State State--green">
<svg class="octicon octicon-git-pull-request" viewBox="0 0 12 16"
version="1.1" width="12" height="16" aria-hidden="true"><path
fill-rule="evenodd" d="M11 11.28V5c-.03-.78-.34-1.47-.94-2.06C9.46 2.35 8.78
2.03 8 2H7V0L4 3l3 3V4h1c.27.02.48.11.69.31.21.2.3.42.31.69v6.28A1.993 1.993 0
0 0 10 15a1.993 1.993 0 0 0 1-3.72zm-1 2.92c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2
1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zM4 3c0-1.11-.89-2-2-2a1.993
1.993 0 0 0-1 3.72v6.56A1.993 1.993 0 0 0 2 15a1.993 1.993 0 0 0
1-3.72V4.72c.59-.34 1-.98 1-1.72zm-.8 10c0 .66-.55 1.2-1.2 1.2-.65
0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2zM2 4.2C1.34 4.2.8
3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2
1.2z"/></svg>
Open
</div>
</div>
<div class="TableObject-item TableObject-item--primary">
<a class="author pull-header-username css-truncate
css-truncate-target expandable" data-hovercard-user-id="5215383"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/dnegreira">dnegreira</a>
wants to merge 1 commit into
<span title="lxc/lxd:master" class="commit-ref css-truncate
user-select-contain expandable base-ref"><span class="css-truncate-target
user">lxc</span>:<span class="css-truncate-target">master</span></span>
<div class="commit-ref-dropdown">
<div class="select-menu js-menu-container js-select-menu
commitish-suggester js-load-contents"
data-contents-url="/lxc/lxd/pull/4515/show_partial?partial=pull_requests%2Fdescription_branches_dropdown">
<button class="btn btn-sm select-menu-button js-menu-target branch"
type="button" aria-label="Choose a base branch" aria-haspopup="true"
aria-expanded="false">
<i>base:</i>
<span class="js-select-button css-truncate css-truncate-target"
title="base: master">master</span>
</button>
<div class="select-menu-modal-holder js-menu-content
js-navigation-container">
<div class="select-menu-modal">
<div class="js-select-menu-deferred-content"></div>
<div class="select-menu-loading-overlay anim-pulse">
<svg height="32" class="octicon octicon-octoface" viewBox="0 0 16
16" version="1.1" width="32" aria-hidden="true"><path fill-rule="evenodd"
d="M14.7 5.34c.13-.32.55-1.59-.13-3.31 0 0-1.05-.33-3.44
1.3-1-.28-2.07-.32-3.13-.32s-2.13.04-3.13.32c-2.39-1.64-3.44-1.3-3.44-1.3-.68
1.72-.26 2.99-.13 3.31C.49 6.21 0 7.33 0 8.69 0 13.84 3.33 15 7.98 15S16 13.84
16 8.69c0-1.36-.49-2.48-1.3-3.35zM8 14.02c-3.3 0-5.98-.15-5.98-3.35
0-.76.38-1.48 1.02-2.07 1.07-.98 2.9-.46 4.96-.46 2.07 0 3.88-.52 4.96.46.65.59
1.02 1.3 1.02 2.07 0 3.19-2.68 3.35-5.98 3.35zM5.49 9.01c-.66 0-1.2.8-1.2
1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8 1.2-1.79s-.54-1.78-1.2-1.78zm5.02 0c-.66
0-1.2.79-1.2 1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8
1.2-1.79s-.53-1.78-1.2-1.78z"/></svg>
</div>
</div>
</div>
</div>
</div>
from
<span title="dnegreira/lxd:init_maas_option" class="commit-ref css-truncate
user-select-contain expandable head-ref"><span class="css-truncate-target
user">dnegreira</span>:<span
class="css-truncate-target">init_maas_option</span></span>
</div>
</div>
</div>
<div class="tabnav tabnav-pr">
<div class="tabnav-extra float-right">
<span class="diffstat" id="diffstat">
<span class="text-green">
+1
</span>
<span class="text-red">
−1
</span>
<span class="tooltipped tooltipped-s" aria-label="2 lines changed">
<span class="block-diff-added"></span><span
class="block-diff-deleted"></span><span class="block-diff-neutral"></span><span
class="block-diff-neutral"></span><span class="block-diff-neutral"></span>
</span>
</span>
</div>
<nav class="tabnav-tabs">
<a href="/lxc/lxd/pull/4515" class="tabnav-tab selected
js-pjax-history-navigate">
<svg class="octicon octicon-comment-discussion" viewBox="0 0 16 16"
version="1.1" width="16" height="16" aria-hidden="true"><path
fill-rule="evenodd" d="M15 1H6c-.55 0-1 .45-1 1v2H1c-.55 0-1 .45-1 1v6c0 .55.45
1 1 1h1v3l3-3h4c.55 0 1-.45 1-1V9h1l3 3V9h1c.55 0 1-.45
1-1V2c0-.55-.45-1-1-1zM9 11H4.5L3 12.5V11H1V5h4v3c0 .55.45 1 1
1h3v2zm6-3h-2v1.5L11.5 8H6V2h9v6z"/></svg>
Conversation
<span id="conversation_tab_counter" class="Counter">
1
</span>
</a>
<a href="/lxc/lxd/pull/4515/commits" class="tabnav-tab
js-pjax-history-navigate">
<svg class="octicon octicon-git-commit" viewBox="0 0 14 16" version="1.1"
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M10.86
7c-.45-1.72-2-3-3.86-3-1.86 0-3.41 1.28-3.86 3H0v2h3.14c.45 1.72 2 3 3.86 3
1.86 0 3.41-1.28 3.86-3H14V7h-3.14zM7 10.2c-1.22 0-2.2-.98-2.2-2.2
0-1.22.98-2.2 2.2-2.2 1.22 0 2.2.98 2.2 2.2 0 1.22-.98 2.2-2.2 2.2z"/></svg>
Commits
<span id="commits_tab_counter" class="Counter">
1
</span>
</a>
<link rel="pjax-prefetch" href="/lxc/lxd/pull/4515/files">
<a href="/lxc/lxd/pull/4515/files" class="tabnav-tab
js-pjax-history-navigate">
<svg class="octicon octicon-diff" viewBox="0 0 13 16" version="1.1"
width="13" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M6
7h2v1H6v2H5V8H3V7h2V5h1v2zm-3 6h5v-1H3v1zM7.5 2L11 5.5V15c0 .55-.45 1-1
1H1c-.55 0-1-.45-1-1V3c0-.55.45-1 1-1h6.5zM10 6L7 3H1v12h9V6zM8.5 0H3v1h5l4
4v8h1V4.5L8.5 0z"/></svg>
Files changed
<span id="files_tab_counter" class="Counter">
1
</span>
</a>
</nav>
</div>
<h2 class="sr-only">Conversation</h2>
<div id="discussion_bucket" class="clearfix pull-request-tab-content
is-visible">
<div class="discussion-sidebar">
<div id="partial-discussion-sidebar"
class="js-socket-channel js-updatable-content"
data-channel="pull_request:185041540"
data-url="/lxc/lxd/issues/4515/show_partial?partial=issues%2Fsidebar">
<div class="discussion-sidebar-item sidebar-assignee
js-discussion-sidebar-item position-relative">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form
data-remote="true" class="js-issue-sidebar-form"
action="/lxc/lxd/pull/4515/review-requests?pr_global_id=MDExOlB1bGxSZXF1ZXN0MTg1MDQxNTQw"
accept-charset="UTF-8" method="post"><input name="utf8" type="hidden"
value="✓" /><input type="hidden" name="authenticity_token"
value="Bh9FD4KFfLAo4a0cODFHt+xAQKTzrNN6uhRLA15flUNdzqeZvn8G00VITz1heWysm3KR43ab0U4pyDDg36JQYA=="
/>
<div class="discussion-sidebar-heading text-bold">
Reviewers
</div>
<span class="css-truncate">
No reviews
</span>
</form></div>
<div class="discussion-sidebar-item sidebar-assignee
js-discussion-sidebar-item">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form
data-remote="true" class="js-issue-sidebar-form"
action="/lxc/lxd/issues/4515?partial=issues%2Fsidebar%2Fshow%2Fassignees"
accept-charset="UTF-8" method="post"><input name="utf8" type="hidden"
value="✓" /><input type="hidden" name="_method" value="put" /><input
type="hidden" name="authenticity_token"
value="SGRvZf+JxB57061hFHQXHle0MVCivpYTC2atYtZ6KA1u9xPXinkpGOaBnS3CY4FiXfU80LsAXgEODy8W4nqKbw=="
/>
<div class="discussion-sidebar-heading text-bold">
Assignees
</div>
<span class="css-truncate">
No one assigned
</span>
</form></div>
<div class="discussion-sidebar-item sidebar-labels
js-discussion-sidebar-item">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form
data-remote="true" class="js-issue-sidebar-form"
action="/lxc/lxd/issues/4515?partial=issues%2Fsidebar%2Fshow%2Flabels"
accept-charset="UTF-8" method="post"><input name="utf8" type="hidden"
value="✓" /><input type="hidden" name="_method" value="put" /><input
type="hidden" name="authenticity_token"
value="uOEi++kmBCVjKHoZKAUBAh9570jpncE/f2oSBpSDDrGecl5JnNbpI/56SlX+Epd+FTjiyPAjCS16A5ByoIOs0w=="
/>
<div class="js-issue-labels-container">
<div class="discussion-sidebar-heading text-bold">
Labels
</div>
</div>
<div aria-live="polite" aria-label="Labels">
<div class="labels css-truncate">
None yet
</div>
</div>
</form></div>
<div class="discussion-sidebar-item js-discussion-sidebar-item">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form
data-remote="true" class="js-issue-sidebar-form"
action="/lxc/lxd/projects/issues/4515" accept-charset="UTF-8"
method="post"><input name="utf8" type="hidden" value="✓" /><input
type="hidden" name="_method" value="put" /><input type="hidden"
name="authenticity_token"
value="qg4E8p+PDu3KFGEcgpJtRRcBfCTf5mgG0P9xYeOsKDkhWh9EofVxaE4ex5y7H5vgQMpzhsKgFDc4O9ZuhThfTg=="
/>
<div class="discussion-sidebar-heading text-bold">
Projects
</div>
<span class="css-truncate sidebar-projects">
None yet
</span>
</form></div>
<div class="discussion-sidebar-item sidebar-milestone
js-discussion-sidebar-item">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form
class="js-issue-sidebar-form" data-remote="true"
action="/lxc/lxd/issues/4515/set_milestone?partial=issues%2Fsidebar%2Fshow%2Fmilestone"
accept-charset="UTF-8" method="post"><input name="utf8" type="hidden"
value="✓" /><input type="hidden" name="_method" value="put" /><input
type="hidden" name="authenticity_token"
value="GyDkiA6jPpRFfnU7e49jRQEpC3PD8vZWJa5moMIoghy+yDM0Y7eZyP5yhow20auAS4bs89bc+0O7Kgzo5ftZxg=="
/>
<div class="discussion-sidebar-heading text-bold">
Milestone
</div>
No milestone
</form></div>
<div id="partial-users-participants" class="discussion-sidebar-item">
<div class="participation">
<div class="discussion-sidebar-heading text-bold">
2 participants
</div>
<div class="participation-avatars d-flex flex-wrap">
<a class="participant-avatar" data-hovercard-user-id="5215383"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/dnegreira">
<img class="avatar"
src="https://avatars1.githubusercontent.com/u/5215383?s=52&v=4"; width="26"
height="26" alt="@dnegreira" />
</a> <a class="participant-avatar" data-hovercard-user-id="16600993"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/lxc-jenkins">
<img class="avatar"
src="https://avatars2.githubusercontent.com/u/16600993?s=52&v=4"; width="26"
height="26" alt="@lxc-jenkins" />
</a> </div>
</div>
</div>
</div>
</div>
<div class="discussion-timeline pull-discussion-timeline
js-pull-discussion-timeline js-quote-selection-container
js-review-state-classes ">
<div class="js-discussion js-socket-channel"
data-channel="marked-as-read:pull-request:185041540">
<div class="timeline-comment-wrapper js-comment-container mt-0">
<div class="avatar-parent-child timeline-comment-avatar">
<a class="d-inline-block" data-hovercard-user-id="5215383"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/dnegreira"><img class="avatar rounded-1" height="44" width="44"
alt="@dnegreira"
src="https://avatars2.githubusercontent.com/u/5215383?s=88&v=4"; /></a>
</div>
<div class="js-minimizable-comment-group">
<div id="issue-185041540"
class="unminimized-comment comment previewable-edit js-comment
js-task-list-container timeline-comment "
data-body-version="5b96da5f7db4977cd511bab4d6d5c426">
<div class="timeline-comment-header clearfix">
<div class="timeline-comment-actions">
<!-- Closes div if we are showing the kebab menu -->
</div>
<span class="timeline-comment-label tooltipped tooltipped-multiline
tooltipped-s" aria-label="This user has been invited to collaborate on the lxd
repository.">
Collaborator
</span>
<h3 class="timeline-comment-header-text f5 text-normal">
<strong>
<a class="author text-inherit" data-hovercard-user-id="5215383"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/dnegreira">dnegreira</a>
</strong>
commented
<a href="#issue-185041540" class="timestamp"><relative-time
datetime="2018-04-30T19:23:43Z">Apr 30, 2018</relative-time></a>
</h3>
</div>
<div class="edit-comment-hide">
<task-lists disabled>
<table class="d-block">
<tbody class="d-block">
<tr class="d-block">
<td class="d-block comment-body markdown-body js-comment-body">
<p>When one selects the <code>no</code> option when setting up MAAS
and then selects the option to set up a custom bridge, the prompt still appears
to ask if the interface is connected to MAAS. This is due to the value
<code>config.Config["maas.api.url"]</code> is set to nil and not to
<code>""</code>.</p>
</td>
</tr>
</tbody>
</table>
</task-lists>
<div class="comment-reactions js-reactions-container "
>
</div>
</div>
</div>
</div>
</div>
<div id="js-timeline-progressive-loader"
data-timeline-item-src="lxc/lxd/timeline?id=MDExOlB1bGxSZXF1ZXN0MTg1MDQxNTQw&variables%5Bafter%5D=Y3Vyc29yOnYyOpPPAAABYxgCwgAAqTM4NTUwMjExNA%3D%3D&variables%5Bfirst%5D=80"
></div>
<div class="js-timeline-item js-timeline-progressive-focus-container"
data-gid="MDE3OlB1bGxSZXF1ZXN0Q29tbWl0MTg1MDQxNTQwOjY1YTc3YjZmMmYwOGViOGY4ZjlhNmM3Y2IyMWZkNGU0YTAxMTA3MzE=">
<div class="discussion-item discussion-commits" id="commits-pushed-65a77b6">
<div class="discussion-item-body">
<div class="timeline-commits ">
<div class="commit js-details-container Details js-socket-channel
js-updatable-content no-wrap d-flex mb-2"
data-channel="repo:26192117:commit:65a77b6f2f08eb8f8f9a6c7cb21fd4e4a0110731"
data-url="/_render_node/MDE3OlB1bGxSZXF1ZXN0Q29tbWl0MTg1MDQxNTQwOjY1YTc3YjZmMmYwOGViOGY4ZjlhNmM3Y2IyMWZkNGU0YTAxMTA3MzE=/commit/pull_condensed">
<div class="commit-icon mr-3">
<svg class="octicon octicon-git-commit" viewBox="0 0 14 16" version="1.1"
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M10.86
7c-.45-1.72-2-3-3.86-3-1.86 0-3.41 1.28-3.86 3H0v2h3.14c.45 1.72 2 3 3.86 3
1.86 0 3.41-1.28 3.86-3H14V7h-3.14zM7 10.2c-1.22 0-2.2-.98-2.2-2.2
0-1.22.98-2.2 2.2-2.2 1.22 0 2.2.98 2.2 2.2 0 1.22-.98 2.2-2.2 2.2z"/></svg>
</div>
<div class="AvatarStack flex-self-start ">
<div class="AvatarStack-body" aria-label="dnegreira">
<a class="avatar" data-skip-pjax="true"
data-hovercard-user-id="5215383" data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self" href="/dnegreira">
<img height="20" width="20" alt="@dnegreira"
src="https://avatars3.githubusercontent.com/u/5215383?s=60&v=4"; />
</a> </div>
</div>
<div class="commit-message pr-1">
<code>
<a title="lxd init: fix maas.api.url check when setting up existing bridge
Signed-off-by: David Negreira <[email protected]>" data-pjax="true"
class="message"
href="/lxc/lxd/pull/4515/commits/65a77b6f2f08eb8f8f9a6c7cb21fd4e4a0110731">lxd
init: fix maas.api.url check when setting up existing bridge</a>
</code>
<span class="hidden-text-expander inline">
<button type="button" class="ellipsis-expander js-details-target"
aria-expanded="false">…</button>
</span>
<div class="commit-desc"><pre>Signed-off-by: David Negreira
<[email protected]></pre></div>
</div>
<div class="commit-sig-status text-right pr-1">
</div>
<div class="commit-ci-status pr-1">
</div>
<div class="commit-meta text-right">
<code>
<a
href="/lxc/lxd/pull/4515/commits/65a77b6f2f08eb8f8f9a6c7cb21fd4e4a0110731"
class="commit-id">65a77b6</a>
</code>
</div>
</div>
</div>
</div>
</div>
</div>
<div class="js-timeline-item js-timeline-progressive-focus-container"
data-gid="MDEyOklzc3VlQ29tbWVudDM4NTUwMjExNA==">
<div class="timeline-comment-wrapper">
<div class="avatar-parent-child timeline-comment-avatar">
<a class="d-inline-block" data-hovercard-user-id="16600993"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/lxc-jenkins"><img class="avatar rounded-1" height="44" width="44"
alt="@lxc-jenkins"
src="https://avatars1.githubusercontent.com/u/16600993?s=88&v=4"; /></a>
</div>
<div class="js-minimizable-comment-group">
<div class="minimized-comment d-none ">
<details class="Details-element details-reset border rounded-1 bg-white"
data-body-version="c91965c93651e387c2b2be3975a57213">
<summary class="bg-gray border-bottom-0 py-0 px-2">
<div class="d-flex flex-justify-between flex-items-center">
<h3 class="timeline-comment-header-text f5 text-gray text-normal
text-italic">
This comment has been minimized.
</h3>
<span class="Details-content--closed text-gray f6"><svg class="octicon
octicon-unfold position-relative mr-1" viewBox="0 0 14 16" version="1.1"
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M11.5
7.5L14 10c0 .55-.45 1-1 1H9v-1h3.5l-2-2h-7l-2 2H5v1H1c-.55
0-1-.45-1-1l2.5-2.5L0 5c0-.55.45-1 1-1h4v1H1.5l2 2h7l2-2H9V4h4c.55 0 1 .45 1
1l-2.5 2.5zM6 6h2V3h2L7 0 4 3h2v3zm2 3H6v3H4l3 3 3-3H8V9z"/></svg>Show
comment</span>
<span class="Details-content--open text-gray f6"><svg class="octicon
octicon-fold position-relative mr-1" viewBox="0 0 14 16" version="1.1"
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7 9l3
3H8v3H6v-3H4l3-3zm3-6H8V0H6v3H4l3 3 3-3zm4 2c0-.55-.45-1-1-1h-2.5l-1 1h3l-2
2h-7l-2-2h3l-1-1H1c-.55 0-1 .45-1 1l2.5 2.5L0 10c0 .55.45 1 1
1h2.5l1-1h-3l2-2h7l2 2h-3l1 1H13c.55 0 1-.45 1-1l-2.5-2.5L14 5z"/></svg>Hide
comment</span>
</div>
</summary>
<div class="border-top">
<div class="review-comment previewable-edit js-task-list-container ">
<div class="edit-comment-hide">
<div class="timeline-comment-actions">
<!-- Closes div if we are showing the kebab menu -->
</div>
<a class="float-left mt-1" data-hovercard-user-id="16600993"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/lxc-jenkins"><img class="avatar" height="28" width="28"
alt="@lxc-jenkins"
src="https://avatars0.githubusercontent.com/u/16600993?s=60&v=4"; /></a>
<div class="review-comment-contents">
<h4 class="f5 text-normal d-inline text-gray-dark">
<strong class="text-gray">
<a class="author text-inherit" data-hovercard-user-id="16600993"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/lxc-jenkins">lxc-jenkins</a>
</strong>
<span class="text-gray">
<relative-time datetime="2018-04-30T19:23:44Z">Apr 30,
2018</relative-time>
</span>
</h4>
<task-lists disabled>
<div class="comment-body markdown-body p-0 pt-1 js-comment-body">
<p>This pull request didn't trigger Jenkins as its author
isn't in the whitelist.</p>
<p>An organization member must perform one of the following:</p>
<ul>
<li>To have this branch tested by Jenkins, use the "ok to test" command.</li>
<li>To have a one time test done, use the "test this please" command.</li>
</ul>
<p>Those commands are simple Github comments of the format: "jenkins:
COMMAND"</p>
</div>
</task-lists>
</div>
</div>
</div>
</div>
</details>
</div>
<div id="issuecomment-385502114"
class="unminimized-comment comment previewable-edit js-comment
js-task-list-container timeline-comment "
data-body-version="c91965c93651e387c2b2be3975a57213">
<div class="timeline-comment-header clearfix">
<div class="timeline-comment-actions">
<!-- Closes div if we are showing the kebab menu -->
</div>
<h3 class="timeline-comment-header-text f5 text-normal">
<strong>
<a class="author text-inherit" data-hovercard-user-id="16600993"
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self"
href="/lxc-jenkins">lxc-jenkins</a>
</strong>
commented
<a href="#issuecomment-385502114" class="timestamp"><relative-time
datetime="2018-04-30T19:23:44Z">Apr 30, 2018</relative-time></a>
</h3>
</div>
<div class="edit-comment-hide">
<task-lists disabled>
<table class="d-block">
<tbody class="d-block">
<tr class="d-block">
<td class="d-block comment-body markdown-body js-comment-body">
<p>This pull request didn't trigger Jenkins as its author isn't in
the whitelist.</p>
<p>An organization member must perform one of the following:</p>
<ul>
<li>To have this branch tested by Jenkins, use the "ok to test" command.</li>
<li>To have a one time test done, use the "test this please" command.</li>
</ul>
<p>Those commands are simple Github comments of the format: "jenkins:
COMMAND"</p>
</td>
</tr>
</tbody>
</table>
</task-lists>
<div class="comment-reactions js-reactions-container "
>
</div>
</div>
</div>
</div>
</div>
</div>
<!-- Rendered timeline since 2018-04-30 12:23:44 -->
<div id="partial-timeline"
class="js-timeline-marker js-socket-channel js-updatable-content"
data-channel="pull_request:185041540"
data-url="/_render_node/MDExOlB1bGxSZXF1ZXN0MTg1MDQxNTQw/pull_requests/timeline?variables%5BhasFocusedReviewComment%5D=false&variables%5BhasFocusedReviewThread%5D=false&variables%5BsyntaxHighlightingEnabled%5D=true&variables%5BtimelinePageSize%5D=40&variables%5BtimelineSince%5D=2018-04-30T19%3A23%3A44Z"
data-last-modified="Mon, 30 Apr 2018 19:23:44 GMT">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form class="d-none
js-timeline-marker-form" action="/_graphql/MarkNotificationThreadAsRead"
accept-charset="UTF-8" data-remote="true" method="post"><input name="utf8"
type="hidden" value="✓" /><input type="hidden" name="authenticity_token"
value="+v4CoqtZVZ4li0v7QpOORCvCI4nC/fhFCMrGY5AmtfEeuiE9I/em8tgobGppeiVTyrvXW9y91wr000KjGyX9Dg=="
/>
<input type="hidden" name="variables[id]"
value="MDExOlB1bGxSZXF1ZXN0MTg1MDQxNTQw">
</form></div>
</div>
<div class="discussion-timeline-actions">
<div class="flash flash-warn mt-3">
<a rel="nofollow" class="btn btn-primary"
href="/join?source=comment-repo">Sign up for free</a>
<strong>to join this conversation on GitHub</strong>.
Already have an account?
<a rel="nofollow"
href="/login?return_to=https%3A%2F%2Fgithub.com%2Flxc%2Flxd%2Fpull%2F4515">Sign
in to comment</a>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div class="modal-backdrop js-touch-events"></div>
</div>
</div>
</div>
</div>
<div class="footer container-lg px-3" role="contentinfo">
<div class="position-relative d-flex flex-justify-between pt-6 pb-2 mt-6 f6
text-gray border-top border-gray-light ">
<ul class="list-style-none d-flex flex-wrap ">
<li class="mr-3">© 2018 <span title="0.68336s from
unicorn-2276367406-896zf">GitHub</span>, Inc.</li>
<li class="mr-3"><a data-ga-click="Footer, go to terms, text:terms"
href="https://github.com/site/terms";>Terms</a></li>
<li class="mr-3"><a data-ga-click="Footer, go to privacy, text:privacy"
href="https://github.com/site/privacy";>Privacy</a></li>
<li class="mr-3"><a
href="https://help.github.com/articles/github-security/"; data-ga-click="Footer,
go to security, text:security">Security</a></li>
<li class="mr-3"><a href="https://status.github.com/";
data-ga-click="Footer, go to status, text:status">Status</a></li>
<li><a data-ga-click="Footer, go to help, text:help"
href="https://help.github.com";>Help</a></li>
</ul>
<a aria-label="Homepage" title="GitHub" class="footer-octicon"
href="https://github.com";>
<svg height="24" class="octicon octicon-mark-github" viewBox="0 0 16 16"
version="1.1" width="24" aria-hidden="true"><path fill-rule="evenodd" d="M8
0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38
0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01
1.08.58 1.23.82.72 1.21 1.87.87
2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95
0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18
1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08
2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0
1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0 0 16
8c0-4.42-3.58-8-8-8z"/></svg>
</a>
<ul class="list-style-none d-flex flex-wrap ">
<li class="mr-3"><a data-ga-click="Footer, go to contact, text:contact"
href="https://github.com/contact";>Contact GitHub</a></li>
<li class="mr-3"><a href="https://developer.github.com";
data-ga-click="Footer, go to api, text:api">API</a></li>
<li class="mr-3"><a href="https://training.github.com";
data-ga-click="Footer, go to training, text:training">Training</a></li>
<li class="mr-3"><a href="https://shop.github.com"; data-ga-click="Footer,
go to shop, text:shop">Shop</a></li>
<li class="mr-3"><a href="https://blog.github.com";
data-ga-click="Footer, go to blog, text:blog">Blog</a></li>
<li><a data-ga-click="Footer, go to about, text:about"
href="https://github.com/about";>About</a></li>
</ul>
</div>
<div class="d-flex flex-justify-center pb-6">
<span class="f6 text-gray-light"></span>
</div>
</div>
<div id="ajax-error-message" class="ajax-error-message flash flash-error">
<svg class="octicon octicon-alert" viewBox="0 0 16 16" version="1.1"
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M8.865
1.52c-.18-.31-.51-.5-.87-.5s-.69.19-.87.5L.275 13.5c-.18.31-.18.69 0 1
.19.31.52.5.87.5h13.7c.36 0 .69-.19.86-.5.17-.31.18-.69.01-1L8.865 1.52zM8.995
13h-2v-2h2v2zm0-3h-2V6h2v4z"/></svg>
<button type="button" class="flash-close js-ajax-error-dismiss"
aria-label="Dismiss error">
<svg class="octicon octicon-x" viewBox="0 0 12 16" version="1.1"
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.48
8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6
6.52l3.75-3.75 1.48 1.48z"/></svg>
</button>
You can’t perform that action at this time.
</div>
<script crossorigin="anonymous" type="application/javascript"
src="https://assets-cdn.github.com/assets/compat-bb7abfb15ed4ffb0da9056d4c980fba5.js";></script>
<script crossorigin="anonymous" type="application/javascript"
src="https://assets-cdn.github.com/assets/frameworks-8e1df5ef753f74d23d26e500300805ce.js";></script>
<script crossorigin="anonymous" async="async" type="application/javascript"
src="https://assets-cdn.github.com/assets/github-185a3d49fd3146b3003cfdf26f787db9.js";></script>
<div class="js-stale-session-flash stale-session-flash flash flash-warn
flash-banner d-none">
<svg class="octicon octicon-alert" viewBox="0 0 16 16" version="1.1"
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M8.865
1.52c-.18-.31-.51-.5-.87-.5s-.69.19-.87.5L.275 13.5c-.18.31-.18.69 0 1
.19.31.52.5.87.5h13.7c.36 0 .69-.19.86-.5.17-.31.18-.69.01-1L8.865 1.52zM8.995
13h-2v-2h2v2zm0-3h-2V6h2v4z"/></svg>
<span class="signed-in-tab-flash">You signed in with another tab or window.
<a href="">Reload</a> to refresh your session.</span>
<span class="signed-out-tab-flash">You signed out in another tab or window.
<a href="">Reload</a> to refresh your session.</span>
</div>
<div class="facebox" id="facebox" style="display:none;">
<div class="facebox-popup">
<div class="facebox-content" role="dialog" aria-labelledby="facebox-header"
aria-describedby="facebox-description">
</div>
<button type="button" class="facebox-close js-facebox-close"
aria-label="Close modal">
<svg class="octicon octicon-x" viewBox="0 0 12 16" version="1.1"
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.48
8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6
6.52l3.75-3.75 1.48 1.48z"/></svg>
</button>
</div>
</div>
<div class="Popover js-hovercard-content position-absolute" style="display:
none; outline: none;" tabindex="0">
<div class="Popover-message Popover-message--bottom-left
Popover-message--large Box box-shadow-large" style="width:360px;">
</div>
</div>
<div id="hovercard-aria-description" class="sr-only">
Press h to open a hovercard with more details.
</div>
</body>
</html>
_______________________________________________
lxc-devel mailing list
[email protected]
http://lists.linuxcontainers.org/listinfo/lxc-devel
![https://github.com/fluidicon.png"](https://github.com/fluidicon.png"){kind=link}
![https://assets-cdn.github.com/pinned-octocat.svg"](https://assets-cdn.github.com/pinned-octocat.svg"){kind=link}