The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/2309
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
This is already done in do_lxcapi_start{l}() so a) no need to do it again here
and b) this would close the state socket pair sockets and corrupt memory.
Signed-off-by: Christian Brauner <[email protected]>
From 76078401a1a8a9699be04e265ca74aa3a80a6977 Mon Sep 17 00:00:00 2001
From: Christian Brauner <[email protected]>
Date: Tue, 8 May 2018 17:58:36 +0200
Subject: [PATCH] execute: do not check inherited fds again
This is already done in do_lxcapi_start{l}() so a) no need to do it again here
and b) this would close the state socket pair sockets and corrupt memory.
Signed-off-by: Christian Brauner <[email protected]>
---
src/lxc/execute.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/lxc/execute.c b/src/lxc/execute.c
index c7320ab2d..d2a6edc64 100644
--- a/src/lxc/execute.c
+++ b/src/lxc/execute.c
@@ -116,9 +116,6 @@ int lxc_execute(const char *name, char *const argv[], int
quiet,
{
struct execute_args args = {.argv = argv, .quiet = quiet};
- if (lxc_check_inherited(handler->conf, false,
&handler->conf->maincmd_fd, 1))
- return -1;
-
handler->conf->is_execute = 1;
return __lxc_start(name, handler, &execute_start_ops, &args, lxcpath,
backgrounded, error_num);
_______________________________________________
lxc-devel mailing list
[email protected]
http://lists.linuxcontainers.org/listinfo/lxc-devel
