The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/2336

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Running on both the master and on the stable-2.0, I couldn't run "make rpm".  I would get the following error:

```
Processing files: lxc-2.0.9-1.el7.centos.x86_64
error: File not found: /home/user/rpmbuild/BUILDROOT/lxc-2.0.9-1.el7.centos.x86_64/etc/bash_completion.d
```

I tried commending out the lxc.spec.in line and I got: 

```
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/user/rpmbuild/BUILDROOT/lxc-2.0.9-1.el7.centos.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/share/bash-completion/completions/lxc
```

The fix was to fix the naming.  RPM building now working for CentOS.
From 843691cad43d791da0eb07740730323f32f6c16f Mon Sep 17 00:00:00 2001
From: Molly Jo Bault <molly.jo.ba...@astronics.com>
Date: Fri, 18 May 2018 09:26:01 -0700
Subject: [PATCH] fixed_bash_completions_for_rpm

---
 configure.ac | 2 +-
 lxc.spec.in  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 218e93108..894bcb402 100644
--- a/configure.ac
+++ b/configure.ac
@@ -494,7 +494,7 @@ AM_CONDITIONAL([ENABLE_BASH], [test "x$enable_bash" = 
"xyes"])
 AM_COND_IF([ENABLE_BASH],
        [AC_MSG_CHECKING([bash completion directory])
        PKG_CHECK_VAR(bashcompdir, [bash-completion], [completionsdir], ,
-               bashcompdir="${sysconfdir}/bash_completion.d")
+               bashcompdir="/usr/share/bash-completion/completions")
        AC_MSG_RESULT([$bashcompdir])
        AC_SUBST(bashcompdir)
        ])
diff --git a/lxc.spec.in b/lxc.spec.in
index 0e64907e0..d34b491a8 100644
--- a/lxc.spec.in
+++ b/lxc.spec.in
@@ -251,7 +251,7 @@ fi
 %endif
 %{_datadir}/doc/*
 %{_datadir}/lxc/*
-%{_sysconfdir}/bash_completion.d
+%{_usr}/share/bash-completion/completions/*
 %config(noreplace) %{_sysconfdir}/lxc/*
 %config(noreplace) %{_sysconfdir}/sysconfig/*
 
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to