The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/pylxd/pull/309
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
Without this change:
```
# virtualenv test
New python executable in /home/pdecat/workspaces/thirdparty/pylxd/test/bin/python
Installing setuptools, pip, wheel...done.
# ./test/bin/python setup.py --help
Installed /home/pdecat/workspaces/thirdparty/pylxd/.eggs/requests_unixsocket-0.1.5-py2.7.egg
Searching for requests!=2.8.0,>=2.5.2
Reading https://pypi.org/simple/requests/
Downloading https://files.pythonhosted.org/packages/49/df/50aa1999ab9bde74656c2919d9c0c085fd2b3775fd3eca826012bef76d8c/requests-2.18.4-py2.py3-none-any.whl#sha256=6a1b267aa90cac58ac3a765d067950e7dbbf75b1da07
e895d1f594193a40a38b
Best match: requests 2.18.4
Processing requests-2.18.4-py2.py3-none-any.whl
Installing requests-2.18.4-py2.py3-none-any.whl to /home/pdecat/workspaces/thirdparty/pylxd/.eggs
writing requirements to /home/pdecat/workspaces/thirdparty/pylxd/.eggs/requests-2.18.4-py2.7.egg/EGG-INFO/requires.txt
Installed /home/pdecat/workspaces/thirdparty/pylxd/.eggs/requests-2.18.4-py2.7.egg
Searching for pbr>=1.8
Reading https://pypi.org/simple/pbr/
Downloading https://files.pythonhosted.org/packages/b3/5d/c196041ffdf3e34ba206db6d61d1f893a75e1f3435699ade9bd65e089a3d/pbr-4.0.4-py2.py3-none-any.whl#sha256=3747c6f017f2dc099986c325239661948f9f5176f6880d9fde
f164cb664cd665
Best match: pbr 4.0.4
Processing pbr-4.0.4-py2.py3-none-any.whl
Installing pbr-4.0.4-py2.py3-none-any.whl to /home/pdecat/workspaces/thirdparty/pylxd/.eggs
Installed /home/pdecat/workspaces/thirdparty/pylxd/.eggs/pbr-4.0.4-py2.7.egg
Searching for urllib3>=1.8
Reading https://pypi.org/simple/urllib3/
Downloading https://files.pythonhosted.org/packages/bd/c9/6fdd990019071a4a32a5e7cb78a1d92c53851ef4f56f62a3486e6a7d8ffb/urllib3-1.23-py2.py3-none-any.whl#sha256=b5725a0bd4ba422ab0e66e89e030c806576753ea3ee0855
4382c14e685d117b5
Best match: urllib3 1.23
Processing urllib3-1.23-py2.py3-none-any.whl
Installing urllib3-1.23-py2.py3-none-any.whl to /home/pdecat/workspaces/thirdparty/pylxd/.eggs
writing requirements to /home/pdecat/workspaces/thirdparty/pylxd/.eggs/urllib3-1.23-py2.7.egg/EGG-INFO/requires.txt
Installed /home/pdecat/workspaces/thirdparty/pylxd/.eggs/urllib3-1.23-py2.7.egg
Traceback (most recent call last):
File "setup.py", line 34, in <module>
pbr=True)
File "/home/pdecat/workspaces/thirdparty/pylxd/test/local/lib/python2.7/site-packages/setuptools/__init__.py", line 128, in setup
_install_setup_requires(attrs)
File "/home/pdecat/workspaces/thirdparty/pylxd/test/local/lib/python2.7/site-packages/setuptools/__init__.py", line 123, in _install_setup_requires
dist.fetch_build_eggs(dist.setup_requires)
File "/home/pdecat/workspaces/thirdparty/pylxd/test/local/lib/python2.7/site-packages/setuptools/dist.py", line 514, in fetch_build_eggs
replace_conflicting=True,
File "/home/pdecat/workspaces/thirdparty/pylxd/test/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 779, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (urllib3 1.23 (/home/pdecat/workspaces/thirdparty/pylxd/.eggs/urllib3-1.23-py2.7.egg), Requirement.parse('urllib3<1.23,>=1.21.1'), set(['requests']))
```
With this change:
```
./test/bin/python setup.py --help
/usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'pbr'
warnings.warn(msg)
Common commands: (see '--help-commands' for more)
setup.py build will build the package underneath 'build/'
setup.py install will install the package
Global options:
--verbose (-v) run verbosely (default)
--quiet (-q) run quietly (turns verbosity off)
--dry-run (-n) don't actually do anything
--help (-h) show detailed help message
--no-user-cfg ignore pydistutils.cfg in your home directory
--command-packages list of packages that provide distutils commands
Information display options (just display information, ignore any commands)
--help-commands list all available commands
--name print package name
--version (-V) print package version
--fullname print <package name>-<version>
--author print the author's name
--author-email print the author's email address
--maintainer print the maintainer's name
--maintainer-email print the maintainer's email address
--contact print the maintainer's name if known, else the author's
--contact-email print the maintainer's email address if known, else the
author's
--url print the URL for this package
--license print the license of the package
--licence alias for --license
--description print the package description
--long-description print the long package description
--platforms print the list of platforms
--classifiers print the list of classifiers
--keywords print the list of keywords
--provides print the list of packages/modules provided
--requires print the list of packages/modules required
--obsoletes print the list of packages/modules made obsolete
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
```
and
```
# ./test/bin/python setup.py egg_info
/usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'pbr'
warnings.warn(msg)
running egg_info
writing requirements to pylxd.egg-info/requires.txt
writing pylxd.egg-info/PKG-INFO
writing top-level names to pylxd.egg-info/top_level.txt
writing dependency_links to pylxd.egg-info/dependency_links.txt
reading manifest file 'pylxd.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'AUTHORS'
warning: no files found matching 'ChangeLog'
warning: no previously-included files found matching '.gitignore'
warning: no previously-included files found matching '.gitreview'
warning: no previously-included files found matching 'contrib_testing'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
writing manifest file 'pylxd.egg-info/SOURCES.txt'
```
From 9d9d911c98fbc4ff0e3f7a88199e9192c13cd779 Mon Sep 17 00:00:00 2001
From: Patrick Decat <pde...@gmail.com>
Date: Wed, 6 Jun 2018 10:11:19 +0200
Subject: [PATCH] Put runtime dependencies in install_requires (fixes #308)
---
setup.py | 2 +-
test/include/python2.7 | 1 +
test/local/include | 1 +
test/pip-selfcheck.json | 1 +
4 files changed, 4 insertions(+), 1 deletion(-)
create mode 120000 test/include/python2.7
create mode 120000 test/local/include
create mode 100644 test/pip-selfcheck.json
diff --git a/setup.py b/setup.py
index 02c0d98..43d3ccc 100644
--- a/setup.py
+++ b/setup.py
@@ -25,7 +25,7 @@
pass
setuptools.setup(
- setup_requires=[
+ install_requires=[
'pbr>=1.8',
'requests!=2.8.0,>=2.5.2',
# >= 0.1.5 needed for HTTP_PROXY support
diff --git a/test/include/python2.7 b/test/include/python2.7
new file mode 120000
index 0000000..ad4ca80
--- /dev/null
+++ b/test/include/python2.7
@@ -0,0 +1 @@
+/usr/include/python2.7
\ No newline at end of file
diff --git a/test/local/include b/test/local/include
new file mode 120000
index 0000000..208b9e2
--- /dev/null
+++ b/test/local/include
@@ -0,0 +1 @@
+/home/pdecat/workspaces/thirdparty/pylxd/test/include
\ No newline at end of file
diff --git a/test/pip-selfcheck.json b/test/pip-selfcheck.json
new file mode 100644
index 0000000..2d7379d
--- /dev/null
+++ b/test/pip-selfcheck.json
@@ -0,0 +1 @@
+{"last_check":"2018-06-06T08:08:49Z","pypi_version":"10.0.1"}
\ No newline at end of file
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel
