The following pull request was submitted through Github. It can be accessed and reviewed at: https://github.com/lxc/lxd/pull/4774
This e-mail was sent by the LXC bot, direct replies will not reach the author unless they happen to be subscribed to this list. === Description (from pull-request) === We have been taking raft snapshots agressively for a while now, to mitigate This change makes the frequency less aggressive. It shouldn't really make a difference regarding #4485, since we take a raft snapshot at daemon shutdown anyways, so the net effect is virtually the same (except in case of hard crashes). The snapshots trick will go away altogether in the new dqlite implementation. Signed-off-by: Free Ekanayaka <free.ekanay...@canonical.com>
From 02689d2c19563893bc10904d7026b18281f1f02c Mon Sep 17 00:00:00 2001 From: Free Ekanayaka <free.ekanay...@canonical.com> Date: Wed, 11 Jul 2018 14:10:08 +0000 Subject: [PATCH] Reduce the frequency of raft snapshots We have been taking raft snapshots agressively for a while now, to mitigate This change makes the frequency less aggressive. It shouldn't really make a difference regarding #4485, since we take a raft snapshot at daemon shutdown anyways, so the net effect is virtually the same (except in case of hard crashes). The snapshots trick will go away altogether in the new dqlite implementation. Signed-off-by: Free Ekanayaka <free.ekanay...@canonical.com> --- lxd/cluster/raft.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lxd/cluster/raft.go b/lxd/cluster/raft.go index b40493a20..742fa26fd 100644 --- a/lxd/cluster/raft.go +++ b/lxd/cluster/raft.go @@ -406,7 +406,7 @@ func raftConfig(latency float64) *raft.Config { // number of uncompacted raft logs low, and workaround slow // log replay when the LXD daemon starts (see #4485). A more // proper fix should be probably implemented in dqlite. - config.SnapshotThreshold = 64 + config.SnapshotThreshold = 512 config.TrailingLogs = 128 return config
_______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel