The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/2543
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
Since we switched to execveat() whenever possible in
commit 4b5b3a2a299b ("execute: use execveat() syscall if supported")
it is unlikely that remove_self() has any job to do at all. So dumb down the
error levels.
Closes #2536.
Signed-off-by: Christian Brauner <[email protected]>
From 694756df3a768c4fd700b4a209f2ae6b4fa7bd7c Mon Sep 17 00:00:00 2001
From: Christian Brauner <[email protected]>
Date: Fri, 17 Aug 2018 11:47:25 +0200
Subject: [PATCH] lxc_init: s/SYSDEBUG()/SYSERROR()/g in remove_self
Since we switched to execveat() whenever possible in
commit 4b5b3a2a299b ("execute: use execveat() syscall if supported")
it is unlikely that remove_self() has any job to do at all. So dumb down the
error levels.
Closes #2536.
Signed-off-by: Christian Brauner <[email protected]>
---
src/lxc/cmd/lxc_init.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lxc/cmd/lxc_init.c b/src/lxc/cmd/lxc_init.c
index 7f47cbddb..17d93f80b 100644
--- a/src/lxc/cmd/lxc_init.c
+++ b/src/lxc/cmd/lxc_init.c
@@ -201,20 +201,20 @@ static void remove_self(void)
n = readlink("/proc/self/exe", path, sizeof(path));
if (n < 0 || n >= MAXPATHLEN) {
- SYSERROR("Failed to readlink \"/proc/self/exe\"");
+ SYSDEBUG("Failed to readlink \"/proc/self/exe\"");
return;
}
path[n] = '\0';
ret = umount2(path, MNT_DETACH);
if (ret < 0) {
- SYSERROR("Failed to unmount \"%s\"", path);
+ SYSDEBUG("Failed to unmount \"%s\"", path);
return;
}
ret = unlink(path);
if (ret < 0) {
- SYSERROR("Failed to unlink \"%s\"", path);
+ SYSDEBUG("Failed to unlink \"%s\"", path);
return;
}
}
_______________________________________________
lxc-devel mailing list
[email protected]
http://lists.linuxcontainers.org/listinfo/lxc-devel
