[lxc-devel] [lxcfs/master] bindings: prevent double free

brauner on Github Fri, 17 Aug 2018 08:34:25 -0700

The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxcfs/pull/253


This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Closes #252.

Signed-off-by: Christian Brauner <[email protected]>






<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
  <link rel="dns-prefetch" href="https://assets-cdn.github.com";>
  <link rel="dns-prefetch" href="https://avatars0.githubusercontent.com";>
  <link rel="dns-prefetch" href="https://avatars1.githubusercontent.com";>
  <link rel="dns-prefetch" href="https://avatars2.githubusercontent.com";>
  <link rel="dns-prefetch" href="https://avatars3.githubusercontent.com";>
  <link rel="dns-prefetch" href="https://github-cloud.s3.amazonaws.com";>
  <link rel="dns-prefetch" href="https://user-images.githubusercontent.com/";>



  <link crossorigin="anonymous" media="all" 
integrity="sha512-Z0JAar9+DkI1NjGVdZr3GivARUgJtA0o2eHlTv7Ou2gshR5awWVf8QGsq11Ns9ZxQLEs+G5/SuARmvpOLMzulw=="
 rel="stylesheet" 
href="https://assets-cdn.github.com/assets/frameworks-95aff0b550d3fe338b645a4deebdcb1b.css";
 />
  <link crossorigin="anonymous" media="all" 
integrity="sha512-NfRWwLqRDxG2XMeqJLbhVt+Th8J1B26cmepEBBeFJi8c+uhtOYpPaWg9+QS7TIzpbuHR6pUGgFXrDp5AurNRLw=="
 rel="stylesheet" 
href="https://assets-cdn.github.com/assets/github-6f86bf736922ee659488376f8a2ce3d7.css";
 />
  
  
  <link crossorigin="anonymous" media="all" 
integrity="sha512-/YdlYmXBl0rVnTX/ANGx7YStBlWdlnfFUtRTlTr8eBpzeBkOUj1GjReYy1/BdJ4wMwOXzQEri+e91nqx5xrwGg=="
 rel="stylesheet" 
href="https://assets-cdn.github.com/assets/site-d3b91707396b15f2783f5f891bc6d36e.css";
 />
  

  <meta name="viewport" content="width=device-width">
  
  <title>bindings: prevent double free by brauner · Pull Request #253 · 
lxc/lxcfs · GitHub</title>
    <meta name="description" content="Closes #252.
Signed-off-by: Christian Brauner [email protected]">
    <link rel="search" type="application/opensearchdescription+xml" 
href="/opensearch.xml" title="GitHub">
  <link rel="fluid-icon" href="https://github.com/fluidicon.png"; title="GitHub">
  <meta property="fb:app_id" content="1401488693436528">

    
    <meta property="og:image" 
content="https://avatars1.githubusercontent.com/u/7353573?s=400&amp;v=4"; 
/><meta property="og:site_name" content="GitHub" /><meta property="og:type" 
content="object" /><meta property="og:title" content="bindings: prevent double 
free by brauner · Pull Request #253 · lxc/lxcfs" /><meta property="og:url" 
content="https://github.com/lxc/lxcfs/pull/253"; /><meta 
property="og:description" content="Closes #252.
Signed-off-by: Christian Brauner [email protected]" />

  <link rel="assets" href="https://assets-cdn.github.com/";>
  
  <meta name="pjax-timeout" content="1000">
  
  <meta name="request-id" content="E1F8:0219:11930E:21B827:5B76EAEB" 
data-pjax-transient>

    <meta name="hovercard-subject-tag" content="pull_request:209184318" 
data-pjax-transient>

  

  <meta name="selected-link" value="repo_pulls" data-pjax-transient>

    <meta name="google-site-verification" 
content="KT5gs8h0wvaagLKAVWq8bbeNwnZZK1r1XQysX3xurLU">
  <meta name="google-site-verification" 
content="ZzhVyEFwb7w3e0-uOTltm8Jsck2F5StVihD0exw2fsA">
  <meta name="google-site-verification" 
content="GXs5KoUUkNCoaAZn7wPN-t01Pywp9M3sEjnt_3_ZWPc">
    <meta name="google-analytics" content="UA-3769691-2">

<meta name="octolytics-host" content="collector.githubapp.com" /><meta 
name="octolytics-app-id" content="github" /><meta name="octolytics-event-url" 
content="https://collector.githubapp.com/github-external/browser_event"; /><meta 
name="octolytics-dimension-request_id" 
content="E1F8:0219:11930E:21B827:5B76EAEB" /><meta 
name="octolytics-dimension-region_edge" content="iad" /><meta 
name="octolytics-dimension-region_render" content="iad" />
<meta name="analytics-location" 
content="/&lt;user-name&gt;/&lt;repo-name&gt;/pull_requests/show" 
data-pjax-transient="true" />




<meta class="js-ga-set" name="dimension1" content="Logged Out">


  

      <meta name="hostname" content="github.com">
    <meta name="user-login" content="">

      <meta name="expected-hostname" content="github.com">
    <meta name="js-proxy-site-detection-payload" 
content="ZTJmYjY5NDJkNzljMDY1NjU4OGFmMTg4NzRjZWE0NDhhZWMyZTA4NGY3NWNhYWFmYjQzYzM4ZTNjMDdmZjgzN3x7InJlbW90ZV9hZGRyZXNzIjoiMTQ5LjU2LjE0OC4wIiwicmVxdWVzdF9pZCI6IkUxRjg6MDIxOToxMTkzMEU6MjFCODI3OjVCNzZFQUVCIiwidGltZXN0YW1wIjoxNTM0NTIwMDQ0LCJob3N0IjoiZ2l0aHViLmNvbSJ9">

    <meta name="enabled-features" 
content="DASHBOARD_V2_LAYOUT_OPT_IN,EXPLORE_DISCOVER_REPOSITORIES,UNIVERSE_BANNER,FREE_TRIALS,MARKETPLACE_INSIGHTS,MARKETPLACE_PLAN_RESTRICTION_EDITOR,MARKETPLACE_SEARCH,MARKETPLACE_INSIGHTS_CONVERSION_PERCENTAGES">

  <meta name="html-safe-nonce" 
content="f90b8e55d0c58fdef80ad04b6b1d3f3ea685d3b0">

  <meta http-equiv="x-pjax-version" content="8a425f055100472b2a505b649378ab1e">
  

      <link 
href="https://github.com/lxc/lxcfs/commits/2018-08-17/prevent_double_free.atom"; 
rel="alternate" title="Recent Commits to lxcfs:2018-08-17/prevent_double_free" 
type="application/atom+xml">

  <meta name="go-import" content="github.com/lxc/lxcfs git 
https://github.com/lxc/lxcfs.git";>

  <meta name="octolytics-dimension-user_id" content="2301756" /><meta 
name="octolytics-dimension-user_login" content="lxc" /><meta 
name="octolytics-dimension-repository_id" content="27918935" /><meta 
name="octolytics-dimension-repository_nwo" content="lxc/lxcfs" /><meta 
name="octolytics-dimension-repository_public" content="true" /><meta 
name="octolytics-dimension-repository_is_fork" content="false" /><meta 
name="octolytics-dimension-repository_network_root_id" content="27918935" 
/><meta name="octolytics-dimension-repository_network_root_nwo" 
content="lxc/lxcfs" /><meta 
name="octolytics-dimension-repository_explore_github_marketplace_ci_cta_shown" 
content="false" />




  <meta name="browser-stats-url" 
content="https://api.github.com/_private/browser/stats";>

  <meta name="browser-errors-url" 
content="https://api.github.com/_private/browser/errors";>

  <link rel="mask-icon" href="https://assets-cdn.github.com/pinned-octocat.svg"; 
color="#000000">
  <link rel="icon" type="image/x-icon" class="js-site-favicon" 
href="https://assets-cdn.github.com/favicon.ico";>

<meta name="theme-color" content="#1e2327">



  <link rel="manifest" href="/manifest.json" crossOrigin="use-credentials">

  </head>

  <body class="logged-out env-production">
    

  <div class="position-relative js-header-wrapper ">
    <a href="#start-of-content" tabindex="1" class="px-2 py-4 bg-blue 
text-white show-on-focus js-skip-to-content">Skip to content</a>
    <div id="js-pjax-loader-bar" class="pjax-loader-bar"><div 
class="progress"></div></div>

    
    
    



        


  <header class="Header header-logged-out  position-relative f4 py-3" 
role="banner" >
    <div class="container-lg d-flex px-3">
      <div class="d-flex flex-justify-between flex-items-center">
        <a class="header-logo-invertocat my-0" href="https://github.com/"; 
aria-label="Homepage" data-ga-click="(Logged out) Header, go to homepage, 
icon:logo-wordmark; experiment:site_header_dropdowns; group:control">
          <svg height="32" class="octicon octicon-mark-github" viewBox="0 0 16 
16" version="1.1" width="32" aria-hidden="true"><path fill-rule="evenodd" d="M8 
0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 
0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01
 1.08.58 1.23.82.72 1.21 1.87.87 
2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 
0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 
1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 
2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 
1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0 0 16 
8c0-4.42-3.58-8-8-8z"/></svg>
        </a>

      </div>

      <div class="HeaderMenu d-flex flex-justify-between flex-auto">
          <nav class="mt-0">
            <ul class="d-flex list-style-none">
                <li class="ml-2">
                  <a class="js-selected-navigation-item HeaderNavlink px-0 py-2 
m-0" data-ga-click="Header, click, Nav menu - item:features; 
experiment:site_header_dropdowns; group:control" data-selected-links="/features 
/features/project-management /features/code-review /features/project-management 
/features/integrations /features" href="/features">
                    Features
</a>                </li>
                <li class="ml-4">
                  <a class="js-selected-navigation-item HeaderNavlink px-0 py-2 
m-0" data-ga-click="Header, click, Nav menu - item:business; 
experiment:site_header_dropdowns; group:control" data-selected-links="/business 
/business/security /business/customers /business" href="/business">
                    Business
</a>                </li>

                <li class="ml-4">
                  <a class="js-selected-navigation-item HeaderNavlink px-0 py-2 
m-0" data-ga-click="Header, click, Nav menu - item:explore; 
experiment:site_header_dropdowns; group:control" data-selected-links="/explore 
/trending /trending/developers /integrations /integrations/feature/code 
/integrations/feature/collaborate /integrations/feature/ship showcases 
showcases_search showcases_landing /explore" href="/explore">
                    Explore
</a>                </li>

                <li class="ml-4">
                      <a class="js-selected-navigation-item HeaderNavlink px-0 
py-2 m-0" data-ga-click="Header, click, Nav menu - item:marketplace; 
experiment:site_header_dropdowns; group:control" data-selected-links=" 
/marketplace" href="/marketplace">
                        Marketplace
</a>                </li>
                <li class="ml-4">
                  <a class="js-selected-navigation-item HeaderNavlink px-0 py-2 
m-0" data-ga-click="Header, click, Nav menu - item:pricing; 
experiment:site_header_dropdowns; group:control" data-selected-links="/pricing 
/pricing/developer /pricing/team /pricing/business-hosted 
/pricing/business-enterprise /pricing" href="/pricing">
                    Pricing
</a>                </li>
            </ul>
          </nav>

        <div class="d-flex">
            <div class="d-lg-flex flex-items-center mr-3">
              <div class="header-search scoped-search site-scoped-search 
js-site-search position-relative js-jump-to"
  role="search combobox"
  aria-owns="jump-to-results"
  aria-label="Search or jump to"
  aria-haspopup="listbox"
  aria-expanded="true"
>
  <div class="position-relative">
    <!-- '"` --><!-- </textarea></xmp> --></option></form><form 
class="js-site-search-form" data-scope-type="Repository" 
data-scope-id="27918935" data-scoped-search-url="/lxc/lxcfs/search" 
data-unscoped-search-url="/search" action="/lxc/lxcfs/search" 
accept-charset="UTF-8" method="get"><input name="utf8" type="hidden" 
value="&#x2713;" />
      <label class="form-control header-search-wrapper 
header-search-wrapper-jump-to position-relative d-flex flex-justify-between 
flex-items-center js-chromeless-input-container">
        <input type="text"
          class="form-control header-search-input jump-to-field 
js-jump-to-field js-site-search-focus js-site-search-field is-clearable"
          data-hotkey="s,/"
          name="q"
          value=""
          placeholder="Search"
          data-unscoped-placeholder="Search GitHub"
          data-scoped-placeholder="Search"
          autocapitalize="off"
          aria-autocomplete="list"
          aria-controls="jump-to-results"
          
data-jump-to-suggestions-path="/_graphql/GetSuggestedNavigationDestinations#csrf-token=d1KuRnaKyXZ1iugfF2JYD1Dys/Yj98QezOWTWUb6YaRFf5KR0CkFEAZAD0R4yOFuEcHjYjWXz08Ocu4mMi+NOw=="
          spellcheck="false"
          autocomplete="off"
          >
          <input type="hidden" class="js-site-search-type-field" name="type" >
            <img 
src="https://assets-cdn.github.com/images/search-shortcut-hint.svg"; alt="" 
class="mr-2 header-search-key-slash">

            <div class="Box position-absolute overflow-hidden d-none 
jump-to-suggestions js-jump-to-suggestions-container">
              <ul class="d-none js-jump-to-suggestions-template-container">
                <li class="d-flex flex-justify-start flex-items-center p-0 f5 
navigation-item js-navigation-item">
                  <a tabindex="-1" class="no-underline d-flex flex-auto 
flex-items-center p-2 jump-to-suggestions-path js-jump-to-suggestion-path 
js-navigation-open" href="">
                    <div class="jump-to-octicon js-jump-to-octicon mr-2 
text-center d-none"></div>
                    <img class="avatar mr-2 flex-shrink-0 
js-jump-to-suggestion-avatar" alt="" aria-label="Team" src="" width="28" 
height="28">

                    <div class="jump-to-suggestion-name 
js-jump-to-suggestion-name flex-auto overflow-hidden text-left no-wrap 
css-truncate css-truncate-target">
                    </div>

                    <div class="border rounded-1 flex-shrink-0 bg-gray px-1 
text-gray-light ml-1 f6 d-none js-jump-to-badge-search">
                      <span class="js-jump-to-badge-search-text-default d-none" 
aria-label="in this repository">
                        In this repository
                      </span>
                      <span class="js-jump-to-badge-search-text-global d-none" 
aria-label="in all of GitHub">
                        All GitHub
                      </span>
                      <span aria-hidden="true" class="d-inline-block ml-1 
v-align-middle">↵</span>
                    </div>

                    <div aria-hidden="true" class="border rounded-1 
flex-shrink-0 bg-gray px-1 text-gray-light ml-1 f6 d-none d-on-nav-focus 
js-jump-to-badge-jump">
                      Jump to
                      <span class="d-inline-block ml-1 v-align-middle">↵</span>
                    </div>
                  </a>
                </li>
                <svg height="16" width="16" class="octicon octicon-repo 
flex-shrink-0 js-jump-to-repo-octicon-template" title="Repository" 
aria-label="Repository" viewBox="0 0 12 16" version="1.1" role="img"><path 
fill-rule="evenodd" d="M4 
9H3V8h1v1zm0-3H3v1h1V6zm0-2H3v1h1V4zm0-2H3v1h1V2zm8-1v12c0 .55-.45 1-1 
1H6v2l-1.5-1.5L3 16v-2H1c-.55 0-1-.45-1-1V1c0-.55.45-1 1-1h10c.55 0 1 .45 1 
1zm-1 10H1v2h2v-1h3v1h5v-2zm0-10H2v9h9V1z"/></svg>
                <svg height="16" width="16" class="octicon octicon-project 
flex-shrink-0 js-jump-to-project-octicon-template" title="Project" 
aria-label="Project" viewBox="0 0 15 16" version="1.1" role="img"><path 
fill-rule="evenodd" d="M10 12h3V2h-3v10zm-4-2h3V2H6v8zm-4 4h3V2H2v12zm-1 
1h13V1H1v14zM14 0H1a1 1 0 0 0-1 1v14a1 1 0 0 0 1 1h13a1 1 0 0 0 1-1V1a1 1 0 0 
0-1-1z"/></svg>
                <svg height="16" width="16" class="octicon octicon-search 
flex-shrink-0 js-jump-to-search-octicon-template" title="Search" 
aria-label="Search" viewBox="0 0 16 16" version="1.1" role="img"><path 
fill-rule="evenodd" d="M15.7 13.3l-3.81-3.83A5.93 5.93 0 0 0 13 
6c0-3.31-2.69-6-6-6S1 2.69 1 6s2.69 6 6 6c1.3 0 2.48-.41 3.47-1.11l3.83 
3.81c.19.2.45.3.7.3.25 0 .52-.09.7-.3a.996.996 0 0 0 0-1.41v.01zM7 10.7c-2.59 
0-4.7-2.11-4.7-4.7 0-2.59 2.11-4.7 4.7-4.7 2.59 0 4.7 2.11 4.7 4.7 0 2.59-2.11 
4.7-4.7 4.7z"/></svg>
              </ul>
              <ul class="d-none js-jump-to-no-results-template-container">
                <li class="d-flex flex-justify-center flex-items-center p-3 f5 
d-none">
                  <span class="text-gray">No suggested jump to results</span>
                </li>
              </ul>

              <ul id="jump-to-results" class="js-navigation-container 
jump-to-suggestions-results-container js-jump-to-suggestions-results-container" 
>
                <li class="d-flex flex-justify-center flex-items-center p-0 f5">
                  <img 
src="https://assets-cdn.github.com/images/spinners/octocat-spinner-128.gif"; 
alt="Octocat Spinner Icon" class="m-2" width="28">
                </li>
              </ul>
            </div>
      </label>
</form>  </div>
</div>

            </div>

          <span class="d-inline-block">
              <div class="HeaderNavlink px-0 py-2 m-0">
                <a class="text-bold text-white no-underline" 
href="/login?return_to=%2Flxc%2Flxcfs%2Fpull%2F253" data-ga-click="(Logged out) 
Header, clicked Sign in, text:sign-in; experiment:site_header_dropdowns; 
group:control">Sign in</a>
                  <span class="text-gray">or</span>
                  <a class="text-bold text-white no-underline" 
href="/join?source=header-repo" data-ga-click="(Logged out) Header, clicked 
Sign up, text:sign-up; experiment:site_header_dropdowns; group:control">Sign 
up</a>
              </div>
          </span>
        </div>
      </div>
    </div>
  </header>

  </div>

  <div id="start-of-content" class="show-on-focus"></div>

    <div id="js-flash-container">


</div>



  <div role="main" class="application-main ">
        <div itemscope itemtype="http://schema.org/SoftwareSourceCode"; class="">
    <div id="js-repo-pjax-container" data-pjax-container >
      
<!-- base sha1: &quot;bca321395dd9595ce64e3cf43726eaef0ea8fb4d&quot; -->
<!-- head sha1: &quot;bbb508dd81b30eba95466564c9c36042e840115c&quot; -->




  



  <div class="pagehead repohead instapaper_ignore readability-menu 
experiment-repo-nav  ">
    <div class="repohead-details-container clearfix container">

      <ul class="pagehead-actions">
  <li>
      <a href="/login?return_to=%2Flxc%2Flxcfs"
    class="btn btn-sm btn-with-count tooltipped tooltipped-s"
    aria-label="You must be signed in to watch a repository" rel="nofollow">
    <svg class="octicon octicon-eye v-align-text-bottom" viewBox="0 0 16 16" 
version="1.1" width="16" height="16" aria-hidden="true"><path 
fill-rule="evenodd" d="M8.06 2C3 2 0 8 0 8s3 6 8.06 6C13 14 16 8 16 
8s-3-6-7.94-6zM8 12c-2.2 0-4-1.78-4-4 0-2.2 1.8-4 4-4 2.22 0 4 1.8 4 4 0 
2.22-1.78 4-4 4zm2-4c0 1.11-.89 2-2 2-1.11 0-2-.89-2-2 0-1.11.89-2 2-2 1.11 0 2 
.89 2 2z"/></svg>
    Watch
  </a>
  <a class="social-count" href="/lxc/lxcfs/watchers"
     aria-label="39 users are watching this repository">
    39
  </a>

  </li>

  <li>
      <a href="/login?return_to=%2Flxc%2Flxcfs"
    class="btn btn-sm btn-with-count tooltipped tooltipped-s"
    aria-label="You must be signed in to star a repository" rel="nofollow">
    <svg class="octicon octicon-star v-align-text-bottom" viewBox="0 0 14 16" 
version="1.1" width="14" height="16" aria-hidden="true"><path 
fill-rule="evenodd" d="M14 6l-4.9-.64L7 1 4.9 5.36 0 6l3.6 3.26L2.67 14 7 11.67 
11.33 14l-.93-4.74L14 6z"/></svg>
    Star
  </a>

    <a class="social-count js-social-count" href="/lxc/lxcfs/stargazers"
      aria-label="273 users starred this repository">
      273
    </a>

  </li>

  <li>
      <a href="/login?return_to=%2Flxc%2Flxcfs"
        class="btn btn-sm btn-with-count tooltipped tooltipped-s"
        aria-label="You must be signed in to fork a repository" rel="nofollow">
        <svg class="octicon octicon-repo-forked v-align-text-bottom" viewBox="0 
0 10 16" version="1.1" width="10" height="16" aria-hidden="true"><path 
fill-rule="evenodd" d="M8 1a1.993 1.993 0 0 0-1 3.72V6L5 8 3 6V4.72A1.993 1.993 
0 0 0 2 1a1.993 1.993 0 0 0-1 3.72V6.5l3 3v1.78A1.993 1.993 0 0 0 5 15a1.993 
1.993 0 0 0 1-3.72V9.5l3-3V4.72A1.993 1.993 0 0 0 8 1zM2 4.2C1.34 4.2.8 3.65.8 
3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zm3 10c-.66 
0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 
1.2zm3-10c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 
.65-.55 1.2-1.2 1.2z"/></svg>
        Fork
      </a>

    <a href="/lxc/lxcfs/network/members" class="social-count"
       aria-label="111 users forked this repository">
      111
    </a>
  </li>
</ul>

      <h1 class="public ">
  <svg class="octicon octicon-repo" viewBox="0 0 12 16" version="1.1" 
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M4 
9H3V8h1v1zm0-3H3v1h1V6zm0-2H3v1h1V4zm0-2H3v1h1V2zm8-1v12c0 .55-.45 1-1 
1H6v2l-1.5-1.5L3 16v-2H1c-.55 0-1-.45-1-1V1c0-.55.45-1 1-1h10c.55 0 1 .45 1 
1zm-1 10H1v2h2v-1h3v1h5v-2zm0-10H2v9h9V1z"/></svg>
  <span class="author" itemprop="author"><a class="url fn" rel="author" 
href="/lxc">lxc</a></span><!--
--><span class="path-divider">/</span><!--
--><strong itemprop="name"><a data-pjax="#js-repo-pjax-container" 
href="/lxc/lxcfs">lxcfs</a></strong>

</h1>

    </div>
    
<nav class="reponav js-repo-nav js-sidenav-container-pjax container"
     itemscope
     itemtype="http://schema.org/BreadcrumbList";
     role="navigation"
     data-pjax="#js-repo-pjax-container">

  <span itemscope itemtype="http://schema.org/ListItem"; 
itemprop="itemListElement">
    <a class="js-selected-navigation-item reponav-item" itemprop="url" 
data-hotkey="g c" data-selected-links="repo_source repo_downloads repo_commits 
repo_releases repo_tags repo_branches repo_packages /lxc/lxcfs" 
href="/lxc/lxcfs">
      <svg class="octicon octicon-code" viewBox="0 0 14 16" version="1.1" 
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M9.5 3L8 
4.5 11.5 8 8 11.5 9.5 13 14 8 9.5 3zm-5 0L0 8l4.5 5L6 11.5 2.5 8 6 4.5 4.5 
3z"/></svg>
      <span itemprop="name">Code</span>
      <meta itemprop="position" content="1">
</a>  </span>

    <span itemscope itemtype="http://schema.org/ListItem"; 
itemprop="itemListElement">
      <a itemprop="url" data-hotkey="g i" class="js-selected-navigation-item 
reponav-item" data-selected-links="repo_issues repo_labels repo_milestones 
/lxc/lxcfs/issues" href="/lxc/lxcfs/issues">
        <svg class="octicon octicon-issue-opened" viewBox="0 0 14 16" 
version="1.1" width="14" height="16" aria-hidden="true"><path 
fill-rule="evenodd" d="M7 2.3c3.14 0 5.7 2.56 5.7 5.7s-2.56 5.7-5.7 5.7A5.71 
5.71 0 0 1 1.3 8c0-3.14 2.56-5.7 5.7-5.7zM7 1C3.14 1 0 4.14 0 8s3.14 7 7 7 
7-3.14 7-7-3.14-7-7-7zm1 3H6v5h2V4zm0 6H6v2h2v-2z"/></svg>
        <span itemprop="name">Issues</span>
        <span class="Counter">20</span>
        <meta itemprop="position" content="2">
</a>    </span>

  <span itemscope itemtype="http://schema.org/ListItem"; 
itemprop="itemListElement">
    <a data-hotkey="g p" itemprop="url" class="js-selected-navigation-item 
selected reponav-item" data-selected-links="repo_pulls checks /lxc/lxcfs/pulls" 
href="/lxc/lxcfs/pulls">
      <svg class="octicon octicon-git-pull-request" viewBox="0 0 12 16" 
version="1.1" width="12" height="16" aria-hidden="true"><path 
fill-rule="evenodd" d="M11 11.28V5c-.03-.78-.34-1.47-.94-2.06C9.46 2.35 8.78 
2.03 8 2H7V0L4 3l3 3V4h1c.27.02.48.11.69.31.21.2.3.42.31.69v6.28A1.993 1.993 0 
0 0 10 15a1.993 1.993 0 0 0 1-3.72zm-1 2.92c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 
1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zM4 3c0-1.11-.89-2-2-2a1.993 
1.993 0 0 0-1 3.72v6.56A1.993 1.993 0 0 0 2 15a1.993 1.993 0 0 0 
1-3.72V4.72c.59-.34 1-.98 1-1.72zm-.8 10c0 .66-.55 1.2-1.2 1.2-.65 
0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2zM2 4.2C1.34 4.2.8 
3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 
1.2z"/></svg>
      <span itemprop="name">Pull requests</span>
      <span class="Counter">3</span>
      <meta itemprop="position" content="3">
</a>  </span>





  <a class="js-selected-navigation-item reponav-item" 
data-selected-links="repo_graphs repo_contributors dependency_graph pulse 
/lxc/lxcfs/pulse" href="/lxc/lxcfs/pulse">
    <svg class="octicon octicon-graph" viewBox="0 0 16 16" version="1.1" 
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M16 
14v1H0V0h1v14h15zM5 13H3V8h2v5zm4 0H7V3h2v10zm4 0h-2V6h2v7z"/></svg>
    Insights
</a>

</nav>


  </div>

<div class="container new-discussion-timeline experiment-repo-nav  ">
  <div class="repository-content ">

    
  <div class="issues-listing" data-pjax>
    
      <div class="signup-prompt-bg rounded-1">
      <div class="signup-prompt p-4 text-center mb-4 rounded-1">
        <div class="position-relative">
          <!-- '"` --><!-- </textarea></xmp> --></option></form><form 
action="/site/dismiss_signup_prompt" accept-charset="UTF-8" 
method="post"><input name="utf8" type="hidden" value="&#x2713;" /><input 
type="hidden" name="authenticity_token" 
value="NaLNxGBFhxpbcVOtq9oL/hNn5dgNidrkhVImj1/TWCsbIrriX4WeVJQ4zidLnFvoq/dS1k9kIVYYZWaBHVzg7w=="
 />
            <button type="submit" class="position-absolute top-0 right-0 
btn-link link-gray" data-ga-click="(Logged out) Sign up prompt, clicked 
Dismiss, text:dismiss">
              Dismiss
            </button>
</form>          <h3 class="pt-2">Join GitHub today</h3>
          <p class="col-6 mx-auto">GitHub is home to over 28 million developers 
working together to host and review code, manage projects, and build software 
together.</p>
          <a class="btn btn-primary" href="/join?source=prompt-pr-show" 
data-ga-click="(Logged out) Sign up prompt, clicked Sign up, text:sign-up">Sign 
up</a>
        </div>
      </div>
    </div>



  <div class="clearfix js-issues-results">
    
  <div
    id="partial-discussion-header"
    class="gh-header js-details-container Details js-socket-channel 
js-updatable-content pull request"
    data-channel="pull_request:209184318"
    data-url="/lxc/lxcfs/pull/253/show_partial?partial=pull_requests%2Ftitle">

  <div class="gh-header-show ">
      <div class="gh-header-actions">

          
<details class="details-reset details-overlay details-overlay-dark float-right" 
>
  <summary class="btn btn-sm btn-primary" aria-haspopup="dialog" 
data-ga-click="Issues, create new issue, view:issue_show location:issue_header 
style:button logged_in:false">
    
    New issue
  </summary>
  <details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in fast 
overflow-auto" aria-label="Sign up for GitHub">
    <button class="position-absolute p-4 right-0 btn-link muted-link" 
type="button" aria-label="Close dialog" data-close-dialog>
      <svg class="octicon octicon-x" viewBox="0 0 12 16" version="1.1" 
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.48 
8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 
6.52l3.75-3.75 1.48 1.48L7.48 8z"/></svg>
    </button>
    <div class="p-4 d-flex flex-column">
            <div class="mt-3 mb-2 text-center">
  <svg height="60" class="octicon octicon-comment-discussion text-blue" 
viewBox="0 0 16 16" version="1.1" width="60" aria-hidden="true"><path 
fill-rule="evenodd" d="M15 1H6c-.55 0-1 .45-1 1v2H1c-.55 0-1 .45-1 1v6c0 .55.45 
1 1 1h1v3l3-3h4c.55 0 1-.45 1-1V9h1l3 3V9h1c.55 0 1-.45 
1-1V2c0-.55-.45-1-1-1zM9 11H4.5L3 12.5V11H1V5h4v3c0 .55.45 1 1 
1h3v2zm6-3h-2v1.5L11.5 8H6V2h9v6z"/></svg>
</div>

<div class="px-4">
  <p class="text-center mb-4">
  <strong>Have a question about this project?</strong> Sign up for a free 
GitHub account to open an issue and contact its maintainers and the community.
  </p>

  <form class="js-signup-form" autocomplete="off" 
action="/join?return_to=%2Flxc%2Flxcfs%2Fissues%2Fnew" accept-charset="UTF-8" 
method="post"><input name="utf8" type="hidden" value="&#x2713;" /><input 
type="hidden" name="authenticity_token" 
value="EjZaCJ9WLl2BkCmQgeamoGWqNwwh9ps5E04/VeO4l5jQVrlJR8Sh7wfrLKIFe9d1c4xUle9OAuHgfSJejJ96Dw=="
 />    <auto-check src="/signup_check/username" 
csrf="ii89+OeIr7x+qsb1diOZ4gZpFPvFeVE+0RV8cKYdYnGtvVU6WR+XGUXrhR21HN3C+qSFcxib5VGld8sFaKeAIA==">
      <dl class="form-group"><dt class="input-label"><label name="user[login]" 
data-facebox-id="user-login-issues" autocapitalize="off" autofocus="autofocus" 
for="user_login_issues">Pick a username</label></dt><dd><input 
name="user[login]" data-facebox-id="user-login-issues" autocapitalize="off" 
autofocus="autofocus" class="form-control" type="text" id="user_login_issues" 
/></dd></dl>
    </auto-check>

    <auto-check src="/signup_check/email" 
csrf="aPjq0pbyMW/1uVhHzkMM873Djt9rXF/N1+Gv0dTIbn3GWauCBYFLCPrDjVz+nzR4KPq4ZIsty4nV8h7+E/3a1Q==">
      <dl class="form-group"><dt class="input-label"><label name="user[email]" 
data-facebox-id="user-email-issues" autocapitalize="off" 
for="user_email_issues">Email Address</label></dt><dd><input name="user[email]" 
data-facebox-id="user-email-issues" autocapitalize="off" class="form-control" 
type="text" id="user_email_issues" /></dd></dl>
    </auto-check>

    <dl class="form-group"><dt class="input-label"><label name="user[password]" 
data-facebox-id="user-password-issues" 
for="user_password_issues">Password</label></dt><dd><input 
name="user[password]" data-facebox-id="user-password-issues" 
class="form-control" type="password" id="user_password_issues" /></dd></dl>

    <input type="hidden" name="source" class="js-signup-source" 
value="modal-issues">
    <input type="text" name="required_field_786d" id="required_field_786d" 
hidden="hidden" class="form-control" />
<input type="hidden" name="timestamp" value="1534520044476" 
class="form-control" />
<input type="hidden" name="timestamp_secret" 
value="3a645e306c4fe2ca7b5f3323c7cd4dbd9cc49b02d892bdb490761633c84c41d2" 
class="form-control" />


    <button class="btn btn-primary mt-2 btn-block" type="submit" 
data-ga-click="(Logged out) New issue modal, clicked Sign up, 
text:sign-up">Sign up for GitHub</button>
</form>
  <p class="mt-4 text-gray text-center">By clicking &ldquo;Sign up for 
GitHub&rdquo;, you agree to our <a href="https://help.github.com/terms"; 
target="_blank">terms of service</a> and
  <a href="https://help.github.com/privacy"; target="_blank">privacy 
statement</a>. We’ll occasionally send you account related emails.</p>
  <p class="mt-4 text-gray text-center">Already on GitHub? <a 
href="/login?return_to=%2Flxc%2Flxcfs%2Fissues%2Fnew" data-ga-click="(Logged 
out) New issue modal, clicked Sign in, text:sign-in">Sign in</a> to your 
account</p>
</div>

</div>
  </details-dialog>
</details>
      </div>

    <h1 class="gh-header-title">
      <span class="js-issue-title">
        bindings: prevent double free
      </span>
      <span class="gh-header-number">#253</span>
    </h1>
  </div>


  <div class="TableObject gh-header-meta">
    <div class="TableObject-item">
        <div class="State State--green">
          <svg class="octicon octicon-git-pull-request" viewBox="0 0 12 16" 
version="1.1" width="12" height="16" aria-hidden="true"><path 
fill-rule="evenodd" d="M11 11.28V5c-.03-.78-.34-1.47-.94-2.06C9.46 2.35 8.78 
2.03 8 2H7V0L4 3l3 3V4h1c.27.02.48.11.69.31.21.2.3.42.31.69v6.28A1.993 1.993 0 
0 0 10 15a1.993 1.993 0 0 0 1-3.72zm-1 2.92c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 
1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zM4 3c0-1.11-.89-2-2-2a1.993 
1.993 0 0 0-1 3.72v6.56A1.993 1.993 0 0 0 2 15a1.993 1.993 0 0 0 
1-3.72V4.72c.59-.34 1-.98 1-1.72zm-.8 10c0 .66-.55 1.2-1.2 1.2-.65 
0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2zM2 4.2C1.34 4.2.8 
3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 
1.2z"/></svg>
          Open
        </div>
    </div>
    <div class="TableObject-item TableObject-item--primary">
          <a class="author pull-header-username css-truncate 
css-truncate-target expandable" data-hovercard-user-id="7353573" 
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" 
href="/brauner">brauner</a>
   wants to merge 1 commit into



  <span title="lxc/lxcfs:master" class="commit-ref css-truncate 
user-select-contain expandable base-ref"><span class="css-truncate-target 
user">lxc</span>:<span class="css-truncate-target">master</span></span>

  <div class="commit-ref-dropdown">
    <div class="select-menu js-menu-container js-select-menu 
commitish-suggester js-load-contents" 
data-contents-url="/lxc/lxcfs/pull/253/show_partial?partial=pull_requests%2Fdescription_branches_dropdown">
      <button class="btn btn-sm select-menu-button js-menu-target branch" 
type="button" aria-label="Choose a base branch" aria-haspopup="true" 
aria-expanded="false">
        <i>base:</i>
        <span class="js-select-button css-truncate css-truncate-target" 
title="base: master">master</span>
      </button>
      <div class="select-menu-modal-holder js-menu-content 
js-navigation-container">
        <div class="select-menu-modal">
          <div class="js-select-menu-deferred-content"></div>
          <div class="select-menu-loading-overlay anim-pulse">
            <svg height="32" class="octicon octicon-octoface" viewBox="0 0 16 
16" version="1.1" width="32" aria-hidden="true"><path fill-rule="evenodd" 
d="M14.7 5.34c.13-.32.55-1.59-.13-3.31 0 0-1.05-.33-3.44 
1.3-1-.28-2.07-.32-3.13-.32s-2.13.04-3.13.32c-2.39-1.64-3.44-1.3-3.44-1.3-.68 
1.72-.26 2.99-.13 3.31C.49 6.21 0 7.33 0 8.69 0 13.84 3.33 15 7.98 15S16 13.84 
16 8.69c0-1.36-.49-2.48-1.3-3.35zM8 14.02c-3.3 0-5.98-.15-5.98-3.35 
0-.76.38-1.48 1.02-2.07 1.07-.98 2.9-.46 4.96-.46 2.07 0 3.88-.52 4.96.46.65.59 
1.02 1.3 1.02 2.07 0 3.19-2.68 3.35-5.98 3.35zM5.49 9.01c-.66 0-1.2.8-1.2 
1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8 1.2-1.79s-.54-1.78-1.2-1.78zm5.02 0c-.66 
0-1.2.79-1.2 1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8 
1.2-1.79s-.53-1.78-1.2-1.78z"/></svg>
          </div>
        </div>
      </div>
    </div>
  </div>

from

<span title="brauner/lxcfs:2018-08-17/prevent_double_free" class="commit-ref 
css-truncate user-select-contain expandable head-ref"><span 
class="css-truncate-target user">brauner</span>:<span 
class="css-truncate-target">2018-08-17/prevent_double_free</span></span>



    </div>
  </div>
</div>


      
<div class="tabnav tabnav-pr">
    <div class="tabnav-extra float-right">
      <span class="diffstat" id="diffstat">
        <span class="text-green">
          +1
        </span>
        <span class="text-red">
          −0
        </span>
        <span class="tooltipped tooltipped-s" aria-label="1 lines changed">
          <span class="block-diff-added"></span><span 
class="block-diff-neutral"></span><span class="block-diff-neutral"></span><span 
class="block-diff-neutral"></span><span class="block-diff-neutral"></span>
        </span>
      </span>
    </div>

  <nav class="tabnav-tabs">
    <a href="/lxc/lxcfs/pull/253" class="tabnav-tab selected 
js-pjax-history-navigate">
      <svg class="octicon octicon-comment-discussion" viewBox="0 0 16 16" 
version="1.1" width="16" height="16" aria-hidden="true"><path 
fill-rule="evenodd" d="M15 1H6c-.55 0-1 .45-1 1v2H1c-.55 0-1 .45-1 1v6c0 .55.45 
1 1 1h1v3l3-3h4c.55 0 1-.45 1-1V9h1l3 3V9h1c.55 0 1-.45 
1-1V2c0-.55-.45-1-1-1zM9 11H4.5L3 12.5V11H1V5h4v3c0 .55.45 1 1 
1h3v2zm6-3h-2v1.5L11.5 8H6V2h9v6z"/></svg>
      Conversation

      <span id="conversation_tab_counter" class="Counter">
        0
      </span>
    </a>

    <a href="/lxc/lxcfs/pull/253/commits" class="tabnav-tab  
js-pjax-history-navigate">
      <svg class="octicon octicon-git-commit" viewBox="0 0 14 16" version="1.1" 
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M10.86 
7c-.45-1.72-2-3-3.86-3-1.86 0-3.41 1.28-3.86 3H0v2h3.14c.45 1.72 2 3 3.86 3 
1.86 0 3.41-1.28 3.86-3H14V7h-3.14zM7 10.2c-1.22 0-2.2-.98-2.2-2.2 
0-1.22.98-2.2 2.2-2.2 1.22 0 2.2.98 2.2 2.2 0 1.22-.98 2.2-2.2 2.2z"/></svg>
      Commits

      <span id="commits_tab_counter" class="Counter">
        1
      </span>
    </a>

    <a href="/lxc/lxcfs/pull/253/checks" class="tabnav-tab " data-skip-pjax>
      <svg class="octicon octicon-checklist" viewBox="0 0 16 16" version="1.1" 
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M16 
8.5l-6 6-3-3L8.5 10l1.5 1.5L14.5 7 16 8.5zM5.7 12.2l.8.8H2c-.55 
0-1-.45-1-1V3c0-.55.45-1 1-1h7c.55 0 1 .45 1 
1v6.5l-.8-.8c-.39-.39-1.03-.39-1.42 0L5.7 10.8a.996.996 0 0 0 0 1.41v-.01zM4 
4h5V3H4v1zm0 2h5V5H4v1zm0 2h3V7H4v1zM3 
9H2v1h1V9zm0-2H2v1h1V7zm0-2H2v1h1V5zm0-2H2v1h1V3z"/></svg>
      Checks

      <span id="checks_tab_counter" class="Counter">
        0
      </span>
    </a>

      <link rel="pjax-prefetch" href="/lxc/lxcfs/pull/253/files">
    <a href="/lxc/lxcfs/pull/253/files" class="tabnav-tab  
js-pjax-history-navigate">
      <svg class="octicon octicon-diff" viewBox="0 0 13 16" version="1.1" 
width="13" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M6 
7h2v1H6v2H5V8H3V7h2V5h1v2zm-3 6h5v-1H3v1zM7.5 2L11 5.5V15c0 .55-.45 1-1 
1H1c-.55 0-1-.45-1-1V3c0-.55.45-1 1-1h6.5zM10 6L7 3H1v12h9V6zM8.5 0H3v1h5l4 
4v8h1V4.5L8.5 0z"/></svg>
      Files changed

        <span id="files_tab_counter" class="Counter">
            1
        </span>
    </a>
  </nav>
</div>



    <h2 class="sr-only">Conversation</h2>
      <div id="discussion_bucket" class="clearfix pull-request-tab-content 
is-visible">
      
<div class="discussion-sidebar">
  <div id="partial-discussion-sidebar"
  class="js-socket-channel js-updatable-content"
  data-channel="pull_request:209184318"
  data-url="/lxc/lxcfs/issues/253/show_partial?partial=issues%2Fsidebar">

    <div class="discussion-sidebar-item sidebar-assignee 
js-discussion-sidebar-item position-relative">
  <!-- '"` --><!-- </textarea></xmp> --></option></form><form 
class="js-issue-sidebar-form" 
action="/lxc/lxcfs/pull/253/review-requests?pr_global_id=MDExOlB1bGxSZXF1ZXN0MjA5MTg0MzE4"
 accept-charset="UTF-8" method="post"><input name="utf8" type="hidden" 
value="&#x2713;" /><input type="hidden" name="authenticity_token" 
value="tPckMBUrZCf0HZ0GIWqJZCvlwJVCeGPh53jfsRR7ndkGPdr/RvqdJGMBiPrG9WUDfc9yOENGNQKGEaalc+Xx9w=="
 />
    

  <div class="discussion-sidebar-heading text-bold">
    Reviewers
  </div>

    <span class="css-truncate">
    No reviews
</span>

</form></div>


  <div class="discussion-sidebar-item sidebar-assignee 
js-discussion-sidebar-item">
  <!-- '"` --><!-- </textarea></xmp> --></option></form><form 
class="js-issue-sidebar-form" 
action="/lxc/lxcfs/issues/253?partial=issues%2Fsidebar%2Fshow%2Fassignees" 
accept-charset="UTF-8" method="post"><input name="utf8" type="hidden" 
value="&#x2713;" /><input type="hidden" name="_method" value="put" /><input 
type="hidden" name="authenticity_token" 
value="JMHAcryKcgGH0K3bbkwPG8YUmEiT46LrNaxf6eae4ORKyVhrm/Kn59o+SZScxhIOYrQhep634QjEqXHSle/ZAw=="
 />
    

  <div class="discussion-sidebar-heading text-bold">
    Assignees
  </div>

    <span class="css-truncate">
    No one assigned
</span>

</form></div>

  <div class="discussion-sidebar-item sidebar-labels 
js-discussion-sidebar-item">
  


  <div class="discussion-sidebar-heading text-bold">
    Labels
  </div>

  <div aria-live="polite" aria-label="Labels">
    <div class="labels css-truncate">
    None yet
</div>

  </div>
</div>

  <div class="discussion-sidebar-item sidebar-milestone 
js-discussion-sidebar-item">
  <!-- '"` --><!-- </textarea></xmp> --></option></form><form 
class="js-issue-sidebar-form" 
action="/lxc/lxcfs/issues/253/set_milestone?partial=issues%2Fsidebar%2Fshow%2Fmilestone"
 accept-charset="UTF-8" method="post"><input name="utf8" type="hidden" 
value="&#x2713;" /><input type="hidden" name="_method" value="put" /><input 
type="hidden" name="authenticity_token" 
value="etN/DjNmrtL3tFs0KrLp18oWfmZV0kKHQ+au+NfVoktTEM6yj5BkA7y6tDXn/Y4oI8XGDCY7GcK7BVBV7EW5RQ=="
 />
    

  <div class="discussion-sidebar-heading text-bold">
    Milestone
  </div>

      No milestone

</form></div>

  
  <div id="partial-users-participants" class="discussion-sidebar-item">
  <div class="participation">

    <div class="discussion-sidebar-heading text-bold">
      1 participant
    </div>
    <div class="participation-avatars d-flex flex-wrap">
        <a class="participant-avatar" data-hovercard-user-id="7353573" 
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" 
href="/brauner">
          <img class="avatar" 
src="https://avatars2.githubusercontent.com/u/7353573?s=52&amp;v=4"; width="26" 
height="26" alt="@brauner" /> 
</a>    </div>
  </div>
</div>


  

</div>


</div>

<div class="discussion-timeline pull-discussion-timeline 
js-pull-discussion-timeline js-quote-selection-container 
js-review-state-classes " >
  <div class="js-discussion js-socket-channel" 
data-channel="marked-as-read:pull-request:209184318">

    <div class="timeline-comment-wrapper js-comment-container mt-0">
      

<div class="avatar-parent-child timeline-comment-avatar">
    <a class="d-inline-block" data-hovercard-user-id="7353573" 
data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" 
href="/brauner"><img class="avatar rounded-1" height="44" width="44" 
alt="@brauner" 
src="https://avatars1.githubusercontent.com/u/7353573?s=88&amp;v=4"; /></a>

</div>


      
<div class="timeline-comment-group js-minimizable-comment-group" 
id="issue-209184318">
  <div class="unminimized-comment comment previewable-edit js-comment 
js-task-list-container timeline-comment  "
       data-body-version="9a96bbf50e741a7db0231ee66e58cbfc"
       
data-unfurl-authenticity-token="AgeBN/1K+miKmiUClOApWt52Wo1X3PAAO17DHwSPLKIn0WcXjVXYg++yqDs4t37IzFWms078+EU+/qw1Aphxkg==">

    
<div class="timeline-comment-header clearfix">
  <div class="timeline-comment-actions">
    






  </div>

    
    <span class="timeline-comment-label text-bold tooltipped 
tooltipped-multiline tooltipped-s" aria-label="This user is a member of the LXC 
- Linux Containers organization.">
      Member
    </span>



  <h3 class="timeline-comment-header-text f5 text-normal">

    <strong class="css-truncate">
      

  <a class="author text-inherit css-truncate-target" 
data-hovercard-user-id="7353573" data-octo-click="hovercard-link-click" 
data-octo-dimensions="link_type:self" href="/brauner">brauner</a>
  

    </strong>

    commented

    <a href="#issue-209184318" class="timestamp"><relative-time 
datetime="2018-08-17T15:34:02Z">Aug 17, 2018</relative-time></a>


    <span class="js-comment-fragment">
      <include-fragment class="js-comment-edit-history d-inline">
      </include-fragment>
    </span>
  </h3>
</div>


    <div class="edit-comment-hide">

      
<task-lists disabled sortable>
<table class="d-block">
  <tbody class="d-block">
    <tr class="d-block">
      <td class="d-block comment-body markdown-body  js-comment-body">

          <p><span class="issue-keyword tooltipped tooltipped-se" 
aria-label="This pull request closes issue #252.">Closes</span> <a 
class="issue-link js-issue-link" data-error-text="Failed to load issue title" 
data-id="351607862" data-permission-text="Issue title is private" 
data-url="https://github.com/lxc/lxcfs/issues/252"; 
href="https://github.com/lxc/lxcfs/issues/252";>#252</a>.</p>
<p>Signed-off-by: Christian Brauner <a 
href="mailto:[email protected]";>[email protected]</a></p>
      </td>
    </tr>
  </tbody>
</table>
</task-lists>


        

<div class="comment-reactions  js-reactions-container "

    >
</div>

    </div>

  </div>
</div>

    </div>

    

  <div id="js-timeline-progressive-loader" 
data-timeline-item-src="lxc/lxcfs/timeline?id=MDExOlB1bGxSZXF1ZXN0MjA5MTg0MzE4&amp;variables%5Bafter%5D=Y3Vyc29yOnYyOpPPAAABZUiFBdAH2gAyMjA5MTg0MzE4OmJiYjUwOGRkODFiMzBlYmE5NTQ2NjU2NGM5YzM2MDQyZTg0MDExNWM%3D&amp;variables%5Bfirst%5D=80"
 ></div>


  
<div class="js-timeline-item js-timeline-progressive-focus-container" 
data-gid="MDE3OlB1bGxSZXF1ZXN0Q29tbWl0MjA5MTg0MzE4OmJiYjUwOGRkODFiMzBlYmE5NTQ2NjU2NGM5YzM2MDQyZTg0MDExNWM=">
    
<div class="discussion-item discussion-commits" id="commits-pushed-bbb508d">
  <div class="discussion-item-body">
    <div class="timeline-commits ">
        

<div class="commit js-details-container Details js-socket-channel 
js-updatable-content no-wrap d-flex mb-2"
     
data-channel="repo:27918935:commit:bbb508dd81b30eba95466564c9c36042e840115c"
     
data-url="/_render_node/MDE3OlB1bGxSZXF1ZXN0Q29tbWl0MjA5MTg0MzE4OmJiYjUwOGRkODFiMzBlYmE5NTQ2NjU2NGM5YzM2MDQyZTg0MDExNWM=/commit/pull_condensed">

  <div class="commit-icon mr-3">
    <svg class="octicon octicon-git-commit" viewBox="0 0 14 16" version="1.1" 
width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M10.86 
7c-.45-1.72-2-3-3.86-3-1.86 0-3.41 1.28-3.86 3H0v2h3.14c.45 1.72 2 3 3.86 3 
1.86 0 3.41-1.28 3.86-3H14V7h-3.14zM7 10.2c-1.22 0-2.2-.98-2.2-2.2 
0-1.22.98-2.2 2.2-2.2 1.22 0 2.2.98 2.2 2.2 0 1.22-.98 2.2-2.2 2.2z"/></svg>
  </div>

  
<div class="AvatarStack flex-self-start ">
  <div class="AvatarStack-body" aria-label="brauner">

        <a class="avatar" data-skip-pjax="true" 
data-hovercard-user-id="7353573" data-octo-click="hovercard-link-click" 
data-octo-dimensions="link_type:self" href="/brauner">
          <img height="20" width="20" alt="@brauner" 
src="https://avatars0.githubusercontent.com/u/7353573?s=60&amp;v=4"; />
</a>  </div>
</div>



  <div class="commit-message pr-1">
    <code>
      <a title="bindings: prevent double free

Closes #252.

Signed-off-by: Christian Brauner &lt;[email protected]&gt;" 
data-pjax="true" class="message" 
href="/lxc/lxcfs/pull/253/commits/bbb508dd81b30eba95466564c9c36042e840115c">bindings:
 prevent double free</a>
    </code>

      <span class="hidden-text-expander inline">
        <button type="button" class="ellipsis-expander js-details-target" 
aria-expanded="false">&hellip;</button>
      </span>
      <div class="commit-desc"><pre><span class="issue-keyword tooltipped 
tooltipped-se" aria-label="This commit closes issue #252.">Closes</span> <a 
class="issue-link js-issue-link" data-error-text="Failed to load issue title" 
data-id="351607862" data-permission-text="Issue title is private" 
data-url="https://github.com/lxc/lxcfs/issues/252"; 
href="https://github.com/lxc/lxcfs/issues/252";>#252</a>.

Signed-off-by: Christian Brauner 
&lt;[email protected]&gt;</pre></div>

  </div>

  <div class="commit-sig-status text-right pr-1">
    
    <details class="dropdown dropdown-signed-commit details-reset 
details-overlay js-dropdown-details d-inline-block">
        <summary class="signed-commit-badge signed-commit-badge-small verified"
          aria-label="View commit signature"
          aria-haspopup="true">
            Verified
        </summary>
        <div class="anim-scale-in" style="position: relative; z-index: 200;">
          <div class="dropdown-menu dropdown-menu-w py-0 text-gray-dark 
text-left">
            <div class="signed-commit-header TableObject">
              <div class="TableObject-item">
                <svg height="32" class="octicon octicon-verified mr-2" 
viewBox="0 0 16 16" version="1.1" width="32" aria-hidden="true"><path 
fill-rule="evenodd" d="M15.67 7.066l-1.08-1.34a1.5 1.5 0 0 
1-.309-.77l-.19-1.698a1.51 1.51 0 0 
0-1.329-1.33l-1.699-.19c-.3-.03-.56-.159-.78-.329L8.945.33a1.504 1.504 0 0 
0-1.878 0l-1.34 1.08a1.5 1.5 0 0 1-.77.31l-1.698.19c-.7.08-1.25.63-1.33 
1.329l-.19 1.699c-.03.3-.159.56-.329.78L.33 7.055a1.504 1.504 0 0 0 0 
1.878l1.08 1.34c.17.22.28.48.31.77l.19 1.698c.08.7.63 1.25 1.329 
1.33l1.699.19c.3.03.56.159.78.329l1.339 1.08c.55.439 1.329.439 1.878 
0l1.34-1.08c.22-.17.48-.28.77-.31l1.698-.19c.7-.08 1.25-.63 
1.33-1.329l.19-1.699c.03-.3.159-.56.329-.78l1.08-1.339a1.504 1.504 0 0 0 
0-1.878zm-9.164 4.936L3.008 8.505l1.5-1.5 1.998 2 4.997-4.997 1.499 1.549-6.496 
6.445z"/></svg>
              </div>
              <div class="TableObject-item--primary">
                    This commit was signed with a <strong 
class="signed-commit-verified-label">verified signature</strong>.
              </div>
            </div>

              <div class="signed-commit-signer TableObject">
                <a class="TableObject-item" aria-label="brauner" 
href="/brauner">
                  <img 
src="https://avatars0.githubusercontent.com/u/7353573?s=64&amp;v=4"; width="32" 
height="32" alt="@brauner" class="avatar mr-2">
                </a>
                <span class="signed-commit-signer-name 
TableObject-item--primary">
                  <a class="signer" href="/brauner">brauner</a>
                  Christian Brauner
                </span>
              </div>

            <div class="signed-commit-footer">
                <span class="d-block">GPG key ID: <span 
class="text-gray">8EB056D53EECB12D</span></span>
              <a 
href="https://help.github.com/articles/signing-commits-with-gpg/";>Learn about 
signing commits</a>
            </div>
          </div>
        </div>
    </details>

  </div>

  <div class="commit-ci-status pr-1">
  </div>

  <div class="commit-meta text-right">
    <code>
      <a 
href="/lxc/lxcfs/pull/253/commits/bbb508dd81b30eba95466564c9c36042e840115c" 
class="commit-id">bbb508d</a>
    </code>
  </div>
</div>


    </div>
  </div>
</div>

</div>






<!-- Rendered timeline since 2018-08-17 08:33:22 -->
<div id="partial-timeline"
      class="js-timeline-marker js-socket-channel js-updatable-content"
      data-channel="pull_request:209184318"
      
data-url="/_render_node/MDExOlB1bGxSZXF1ZXN0MjA5MTg0MzE4/pull_requests/timeline?variables%5BhasFocusedReviewComment%5D=false&amp;variables%5BhasFocusedReviewThread%5D=false&amp;variables%5BsyntaxHighlightingEnabled%5D=true&amp;variables%5BtimelinePageSize%5D=40&amp;variables%5BtimelineSince%5D=2018-08-17T15%3A33%3A22Z"
      data-last-modified="Fri, 17 Aug 2018 15:33:22 GMT">
  <!-- '"` --><!-- </textarea></xmp> --></option></form><form class="d-none 
js-timeline-marker-form" action="/_graphql/MarkNotificationSubjectAsRead" 
accept-charset="UTF-8" data-remote="true" method="post"><input name="utf8" 
type="hidden" value="&#x2713;" /><input type="hidden" name="authenticity_token" 
value="E93uO8XYKiMEefdQEKL5fD6THabSaLbGOV+Y9RNPJH9cZwWiNCCkr43TyPEu1XAOWdxiGXcNJVwVe5EOdYWItw=="
 />
    <input type="hidden" name="variables[subjectId]" 
value="MDExOlB1bGxSZXF1ZXN0MjA5MTg0MzE4">
</form></div>


  </div>

  <div class="discussion-timeline-actions">
          <div class="flash flash-warn mt-3">
    <a rel="nofollow" class="btn btn-primary" 
href="/join?source=comment-repo">Sign up for free</a>
    <strong>to join this conversation on GitHub</strong>.
    Already have an account?
    <a rel="nofollow" 
href="/login?return_to=https%3A%2F%2Fgithub.com%2Flxc%2Flxcfs%2Fpull%2F253">Sign
 in to comment</a>
</div>


  </div>
</div>

    </div>
  </div>

  </div>

  </div>
  <div class="modal-backdrop js-touch-events"></div>
</div>

    </div>
  </div>

  </div>

        
<div class="footer container-lg px-3" role="contentinfo">
  <div class="position-relative d-flex flex-justify-between pt-6 pb-2 mt-6 f6 
text-gray border-top border-gray-light ">
    <ul class="list-style-none d-flex flex-wrap ">
      <li class="mr-3">&copy; 2018 <span title="1.42748s from 
unicorn-646f848648-ddqtv">GitHub</span>, Inc.</li>
        <li class="mr-3"><a data-ga-click="Footer, go to terms, text:terms" 
href="https://github.com/site/terms";>Terms</a></li>
        <li class="mr-3"><a data-ga-click="Footer, go to privacy, text:privacy" 
href="https://github.com/site/privacy";>Privacy</a></li>
        <li class="mr-3"><a 
href="https://help.github.com/articles/github-security/"; data-ga-click="Footer, 
go to security, text:security">Security</a></li>
        <li class="mr-3"><a href="https://status.github.com/"; 
data-ga-click="Footer, go to status, text:status">Status</a></li>
        <li><a data-ga-click="Footer, go to help, text:help" 
href="https://help.github.com";>Help</a></li>
    </ul>

    <a aria-label="Homepage" title="GitHub" class="footer-octicon" 
href="https://github.com";>
      <svg height="24" class="octicon octicon-mark-github" viewBox="0 0 16 16" 
version="1.1" width="24" aria-hidden="true"><path fill-rule="evenodd" d="M8 
0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 
0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01
 1.08.58 1.23.82.72 1.21 1.87.87 
2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 
0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 
1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 
2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 
1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0 0 16 
8c0-4.42-3.58-8-8-8z"/></svg>
</a>
   <ul class="list-style-none d-flex flex-wrap ">
        <li class="mr-3"><a data-ga-click="Footer, go to contact, text:contact" 
href="https://github.com/contact";>Contact GitHub</a></li>
        <li class="mr-3"><a href="/pricing" data-ga-click="Footer, go to 
Pricing, text:Pricing">Pricing</a></li>
      <li class="mr-3"><a href="https://developer.github.com"; 
data-ga-click="Footer, go to api, text:api">API</a></li>
      <li class="mr-3"><a href="https://training.github.com"; 
data-ga-click="Footer, go to training, text:training">Training</a></li>
        <li class="mr-3"><a href="https://blog.github.com"; 
data-ga-click="Footer, go to blog, text:blog">Blog</a></li>
        <li><a data-ga-click="Footer, go to about, text:about" 
href="https://github.com/about";>About</a></li>

    </ul>
  </div>
  <div class="d-flex flex-justify-center pb-6">
    <span class="f6 text-gray-light"></span>
  </div>
</div>



  <div id="ajax-error-message" class="ajax-error-message flash flash-error">
    <svg class="octicon octicon-alert" viewBox="0 0 16 16" version="1.1" 
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M8.893 
1.5c-.183-.31-.52-.5-.887-.5s-.703.19-.886.5L.138 13.499a.98.98 0 0 0 0 
1.001c.193.31.53.501.886.501h13.964c.367 0 .704-.19.877-.5a1.03 1.03 0 0 0 
.01-1.002L8.893 1.5zm.133 
11.497H6.987v-2.003h2.039v2.003zm0-3.004H6.987V5.987h2.039v4.006z"/></svg>
    <button type="button" class="flash-close js-ajax-error-dismiss" 
aria-label="Dismiss error">
      <svg class="octicon octicon-x" viewBox="0 0 12 16" version="1.1" 
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.48 
8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 
6.52l3.75-3.75 1.48 1.48L7.48 8z"/></svg>
    </button>
    You can’t perform that action at this time.
  </div>


    <script crossorigin="anonymous" 
integrity="sha512-2VdGgXQE8W5ONZ4OsrbEo/noennUZaqXkevD9R8juTHiCsjT0HFTTF6MoBfySUc8G+eFqUcDgd7v+CAu8Gjxlg=="
 type="application/javascript" 
src="https://assets-cdn.github.com/assets/compat-f849c975b0ffaa01d6ca305e48417d08.js";></script>
    <script crossorigin="anonymous" 
integrity="sha512-DH27tJskdVAW+yNbiGrR9seVyKp/gttcUm4MfkojBsODLMqn0QYPM+dqWDdKkejbz+3Ua2HnjyEmcp/S2WbuJw=="
 type="application/javascript" 
src="https://assets-cdn.github.com/assets/frameworks-a91844e9c18d25a09b535450a2115c71.js";></script>
    
    <script crossorigin="anonymous" async="async" 
integrity="sha512-CfEuLTEEfQDJFTRxXr62rxZDTDmgYUB9w5GQe3j5sOFki9QSFWXp6pXgUrltyKRdwoINhqh2DsE0rgz+k5F3Vg=="
 type="application/javascript" 
src="https://assets-cdn.github.com/assets/github-1693766cf66fd2e2aad2aa45a8c9edde.js";></script>
    
    
    
  <div class="js-stale-session-flash stale-session-flash flash flash-warn 
flash-banner d-none">
    <svg class="octicon octicon-alert" viewBox="0 0 16 16" version="1.1" 
width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M8.893 
1.5c-.183-.31-.52-.5-.887-.5s-.703.19-.886.5L.138 13.499a.98.98 0 0 0 0 
1.001c.193.31.53.501.886.501h13.964c.367 0 .704-.19.877-.5a1.03 1.03 0 0 0 
.01-1.002L8.893 1.5zm.133 
11.497H6.987v-2.003h2.039v2.003zm0-3.004H6.987V5.987h2.039v4.006z"/></svg>
    <span class="signed-in-tab-flash">You signed in with another tab or window. 
<a href="">Reload</a> to refresh your session.</span>
    <span class="signed-out-tab-flash">You signed out in another tab or window. 
<a href="">Reload</a> to refresh your session.</span>
  </div>
  <div class="facebox" id="facebox" style="display:none;">
  <div class="facebox-popup">
    <div class="facebox-content" role="dialog" aria-labelledby="facebox-header" 
aria-describedby="facebox-description">
    </div>
    <button type="button" class="facebox-close js-facebox-close" 
aria-label="Close modal">
      <svg class="octicon octicon-x" viewBox="0 0 12 16" version="1.1" 
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.48 
8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 
6.52l3.75-3.75 1.48 1.48L7.48 8z"/></svg>
    </button>
  </div>
</div>

  <template id="site-details-dialog">
  <details class="details-reset details-overlay details-overlay-dark lh-default 
text-gray-dark" open>
    <summary aria-haspopup="dialog" aria-label="Close dialog"></summary>
    <details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in 
fast">
      <button class="m-3 btn-octicon position-absolute right-0 top-0" 
type="button" aria-label="Close dialog" data-close-dialog>
        <svg class="octicon octicon-x" viewBox="0 0 12 16" version="1.1" 
width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.48 
8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 
6.52l3.75-3.75 1.48 1.48L7.48 8z"/></svg>
      </button>
      <div class="octocat-spinner my-6 js-details-dialog-spinner"></div>
    </details-dialog>
  </details>
</template>

  <div class="Popover js-hovercard-content position-absolute" style="display: 
none; outline: none;" tabindex="0">
  <div class="Popover-message Popover-message--bottom-left 
Popover-message--large Box box-shadow-large" style="width:360px;">
  </div>
</div>

<div id="hovercard-aria-description" class="sr-only">
  Press h to open a hovercard with more details.
</div>


  </body>
</html>

_______________________________________________
lxc-devel mailing list
[email protected]
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxcfs/master] bindings: prevent double free

Reply via email to