Branch: refs/heads/stable-2.0 Home: https://github.com/lxc/lxc Commit: 5867fecc36552e3840a1476b76b40d332715170e https://github.com/lxc/lxc/commit/5867fecc36552e3840a1476b76b40d332715170e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018)
Changed paths: M src/lxc/utils.h Log Message: ----------- utils: include linux/types.h Closes #2178. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 286e5180dba60754726b74f7e26f8c7a89eb2064 https://github.com/lxc/lxc/commit/286e5180dba60754726b74f7e26f8c7a89eb2064 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/cgroups/cgfsng.c Log Message: ----------- cgfsng: fix off-by-one error Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: c4d5d860d29dd7f1b56f284a6923bfa06da93826 https://github.com/lxc/lxc/commit/c4d5d860d29dd7f1b56f284a6923bfa06da93826 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_start() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 26f6e199cb0d77b20d0f95f9389cccdb92fd05b7 https://github.com/lxc/lxc/commit/26f6e199cb0d77b20d0f95f9389cccdb92fd05b7 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_create() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 78a54613a5c8fc2499995d084cdc2a23b1391e64 https://github.com/lxc/lxc/commit/78a54613a5c8fc2499995d084cdc2a23b1391e64 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_get_interfaces() thread-safety: s/exit()/_exit/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 7a9f5834e5ffed5ada8b88276c98bc2ae632a346 https://github.com/lxc/lxc/commit/7a9f5834e5ffed5ada8b88276c98bc2ae632a346 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_get_ips() thread-safety: s/exit/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 06e3cd0b499db91deb1f6301a9383c2cb9fb8ae8 https://github.com/lxc/lxc/commit/06e3cd0b499db91deb1f6301a9383c2cb9fb8ae8 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_clone() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 9717124c1353f481be108eb9ef975ca7afa0dd7b https://github.com/lxc/lxc/commit/9717124c1353f481be108eb9ef975ca7afa0dd7b Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_add_remove_node() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 87011905f9f6396eb4c2ebe16ea1c20ec8e1bf6c https://github.com/lxc/lxc/commit/87011905f9f6396eb4c2ebe16ea1c20ec8e1bf6c Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_detach_interface() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 1ba7d9bf98fd0bf2514f01ee122b1358f7f6fc9b https://github.com/lxc/lxc/commit/1ba7d9bf98fd0bf2514f01ee122b1358f7f6fc9b Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxclock.c Log Message: ----------- lxclock: {un}lock_mutex() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: f7b5b0e93919534bd6b363630b3b15984d629d57 https://github.com/lxc/lxc/commit/f7b5b0e93919534bd6b363630b3b15984d629d57 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/utils.c Log Message: ----------- utils: lxc_popen() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 7f5fb0b369a232df2ab58f65d9dfaeb66aef8bc1 https://github.com/lxc/lxc/commit/7f5fb0b369a232df2ab58f65d9dfaeb66aef8bc1 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/utils.c Log Message: ----------- utils: run_command() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 9024eaa696ca0a0c10671688827ad0191badb59a https://github.com/lxc/lxc/commit/9024eaa696ca0a0c10671688827ad0191badb59a Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/network.c Log Message: ----------- network: lxc_create_network_unpriv_exec() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: f1a4b7f66c5c79716e58114a041a4b61e5a5ef19 https://github.com/lxc/lxc/commit/f1a4b7f66c5c79716e58114a041a4b61e5a5ef19 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/network.c Log Message: ----------- network: lxc_delete_network_unpriv_exec() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: d6ed2b26826e722462cbb08978133432fffabcbf https://github.com/lxc/lxc/commit/d6ed2b26826e722462cbb08978133432fffabcbf Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: config_file_exists() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 9d074e638b039fad9d2c4cf10b3c18464c6b712e https://github.com/lxc/lxc/commit/9d074e638b039fad9d2c4cf10b3c18464c6b712e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: ongoing_create() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 7f15d3140b214f5e00a3d7dcf1c834bd77ca5b30 https://github.com/lxc/lxc/commit/7f15d3140b214f5e00a3d7dcf1c834bd77ca5b30 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: create_partial() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: de487bb3fa426914add1a9757a27b406f2bcae1e https://github.com/lxc/lxc/commit/de487bb3fa426914add1a9757a27b406f2bcae1e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: create_partial() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 0a278fab7646d9846474ce7fd070b5b7f5c6a92e https://github.com/lxc/lxc/commit/0a278fab7646d9846474ce7fd070b5b7f5c6a92e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: lxc_container_free() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: ecdb5b75a4555effd0989cd5bd06012b8c22b93d https://github.com/lxc/lxc/commit/ecdb5b75a4555effd0989cd5bd06012b8c22b93d Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: lxc_container_{get,put}() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 9c3a0ce674142f6a1b5e4043cfb44d89d05746ed https://github.com/lxc/lxc/commit/9c3a0ce674142f6a1b5e4043cfb44d89d05746ed Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_is_defined() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 07b0e033ac9bcb5fd6f2e25709e7e8191a25cd46 https://github.com/lxc/lxc/commit/07b0e033ac9bcb5fd6f2e25709e7e8191a25cd46 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_state() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: cd1f4defb2129c4718c07bdfdac0a41b1749e2c3 https://github.com/lxc/lxc/commit/cd1f4defb2129c4718c07bdfdac0a41b1749e2c3 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: is_stopped() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 64da8de94321af027d40a4ec179c6ac4fd1d69e5 https://github.com/lxc/lxc/commit/64da8de94321af027d40a4ec179c6ac4fd1d69e5 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_is_running() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 46bdf7f194fbef1f233655f3e64763d9a42a922d https://github.com/lxc/lxc/commit/46bdf7f194fbef1f233655f3e64763d9a42a922d Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_freeze() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: fedf72a6c7836dbc3fdc5bca1f9fdb2d133b3c4e https://github.com/lxc/lxc/commit/fedf72a6c7836dbc3fdc5bca1f9fdb2d133b3c4e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_unfreeze() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: b2abfe8fc8da45c2f667e21a355693d1226f17b7 https://github.com/lxc/lxc/commit/b2abfe8fc8da45c2f667e21a355693d1226f17b7 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_console_getfd() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 10190e200dfb8156868426635f171364a9854313 https://github.com/lxc/lxc/commit/10190e200dfb8156868426635f171364a9854313 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: lxcapi_console() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 1c154b2380666d88cdef4a84afc997d975c0ff01 https://github.com/lxc/lxc/commit/1c154b2380666d88cdef4a84afc997d975c0ff01 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: load_config_locked() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: ed057bb95807c004d14e8b0d1f9fed372411796e https://github.com/lxc/lxc/commit/ed057bb95807c004d14e8b0d1f9fed372411796e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_load_config() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 76cee3b4302d948c23efe22c21d308759d293ecb https://github.com/lxc/lxc/commit/76cee3b4302d948c23efe22c21d308759d293ecb Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_want_daemonize() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 642da155f692dd216a368c37d0768e021e6f91b5 https://github.com/lxc/lxc/commit/642da155f692dd216a368c37d0768e021e6f91b5 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_want_close_all_fds() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: a92d5faa61b6aec3dca167fdfbd44236fad27a4d https://github.com/lxc/lxc/commit/a92d5faa61b6aec3dca167fdfbd44236fad27a4d Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_lxcapi_wait() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 1d2d8eb036f9fbeb171f7487441368b0412cff24 https://github.com/lxc/lxc/commit/1d2d8eb036f9fbeb171f7487441368b0412cff24 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: am_single_threaded() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 8c97eae0830a64d10de4cf6524c3e7dcffc5cfd4 https://github.com/lxc/lxc/commit/8c97eae0830a64d10de4cf6524c3e7dcffc5cfd4 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: push_arg() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 9a65270cc2f2c5f4af1823348d75f66923f7486e https://github.com/lxc/lxc/commit/9a65270cc2f2c5f4af1823348d75f66923f7486e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: split_init_cmd() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 69d46442437c7e825d4dea5e385086495e1d91b1 https://github.com/lxc/lxc/commit/69d46442437c7e825d4dea5e385086495e1d91b1 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: free_init_cmd() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 05583a24b045939f3d4339b12666957616d41c8e https://github.com/lxc/lxc/commit/05583a24b045939f3d4339b12666957616d41c8e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: lxcapi_start() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 9a007b4349810f9f17a6c62ab5818d98b742ab26 https://github.com/lxc/lxc/commit/9a007b4349810f9f17a6c62ab5818d98b742ab26 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: lxcapi_startl() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: f9bd2344b9545569fa5ce4e883545065cf8e1b56 https://github.com/lxc/lxc/commit/f9bd2344b9545569fa5ce4e883545065cf8e1b56 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do_create_container_dir() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: f6aa5dc680557b57e0827a62b014eacccd5cd122 https://github.com/lxc/lxc/commit/f6aa5dc680557b57e0827a62b014eacccd5cd122 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: create_container_dir() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: a7d1eef759195929e1cacd79769391116404f266 https://github.com/lxc/lxc/commit/a7d1eef759195929e1cacd79769391116404f266 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/criu.c Log Message: ----------- criu: criu_version_ok() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 28eafc46ea227d022076835b9d88cda103f75592 https://github.com/lxc/lxc/commit/28eafc46ea227d022076835b9d88cda103f75592 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/criu.c Log Message: ----------- criu: do_restore() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 3a2b6caed7cf5607bea76fc157233ca35cbe3c25 https://github.com/lxc/lxc/commit/3a2b6caed7cf5607bea76fc157233ca35cbe3c25 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/criu.c Log Message: ----------- criu: du_dump() thread-safety: s/exit()/_exit()/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 39a30bc9090ebc49019142e2b5aac3afd2345a8e https://github.com/lxc/lxc/commit/39a30bc9090ebc49019142e2b5aac3afd2345a8e Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/cgroups/cgfsng.c Log Message: ----------- cgfsng: fix get_hierarchy() for unified hierarchy Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 1f3ae603f69227434fcb29f89c9b0d1d5ee71b1e https://github.com/lxc/lxc/commit/1f3ae603f69227434fcb29f89c9b0d1d5ee71b1e Author: Stuart Cardall <develo...@it-offshore.co.uk> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M templates/lxc-download.in Log Message: ----------- fix download template for /tmp as tmpfs or noexec * prepend $LXC_PATH to $DOWNLOAD_TEMP on systems with /tmp mounted securely as a small tmpfs / noexec * gpg_setup() creates $DOWNLOAD_TEMP so remove superflous mkdir * fixes https://github.com/lxc/lxc/issues/516 Signed-off-by: Stuart Cardall <develo...@it-offshore.co.uk> Commit: a6123af191c048e7cc96e73b00e517347e82964d https://github.com/lxc/lxc/commit/a6123af191c048e7cc96e73b00e517347e82964d Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M CODING_STYLE.md Log Message: ----------- CODING_STYLE: add section about _exit() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: c5f35c3a2229528e2ab7e20c17065c093bc82a5c https://github.com/lxc/lxc/commit/c5f35c3a2229528e2ab7e20c17065c093bc82a5c Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/commands.c M src/lxc/commands_utils.c M src/lxc/start.c Log Message: ----------- commands: remove mutex from state client list I was thinking about the locking here yesterday and it dawned on me that we actually don't need this at all: - possible contention between traversing list to send states to state clients and adding new state clients to the list: It is the command handler that adds new state clients to the state client list. The command handler and the code that actually sends out the container states run in the same process so there's not contention and thus no locking needed. - adding state clients to the list from multiple threads: The command handler itself is single-threaded so only one thread's request can be served at the same time so no locking is needed. - sending out the state to state clients via the command handler itself: The state client also adds and removes state clients from the state client list so there's no locking needed. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 071b170479c62ef682d7c1aebaac56fb1949667b https://github.com/lxc/lxc/commit/071b170479c62ef682d7c1aebaac56fb1949667b Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/lxc/tools/lxc_snapshot.c Log Message: ----------- lxc-snapshot: fix segfault https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1751780 Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Compare: https://github.com/lxc/lxc/compare/5eb45428b312...071b170479c6 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
_______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel