The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxcfs/pull/268

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
This reverts commit 0108dc1cc6eab76392d228ee4ca844729096473d.

I am still experiencing hangs in lxcfs even with this patch.

I redid this PR to remove some of the extra history that had been included in the last one.

CC @brauner @Blub 
From ba8351c4cf1e3dff8046e49a995c6d9a58f2007d Mon Sep 17 00:00:00 2001
From: tomponline <[email protected]>
Date: Tue, 22 Jan 2019 12:38:25 +0000
Subject: [PATCH] Revert "bindings: protect do_release_file_info() with mutex"

This reverts commit 0108dc1cc6eab76392d228ee4ca844729096473d.

I am still experiencing hangs in lxcfs even with this patch.
---
 bindings.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/bindings.c b/bindings.c
index 29855d5..097ca81 100644
--- a/bindings.c
+++ b/bindings.c
@@ -2169,16 +2169,11 @@ int cg_readdir(const char *path, void *buf, 
fuse_fill_dir_t filler, off_t offset
        return ret;
 }
 
-static pthread_mutex_t do_release_file_info_lock = PTHREAD_MUTEX_INITIALIZER;
-
 static void do_release_file_info(struct fuse_file_info *fi)
 {
-       lock_mutex(&do_release_file_info_lock);
-
        struct file_info *f = (struct file_info *)fi->fh;
 
        if (!f)
-               unlock_mutex(&do_release_file_info_lock);
                return;
 
        fi->fh = 0;
@@ -2193,8 +2188,6 @@ static void do_release_file_info(struct fuse_file_info 
*fi)
        f->buf = NULL;
        free(f);
        f = NULL;
-
-       unlock_mutex(&do_release_file_info_lock);
 }
 
 int cg_releasedir(const char *path, struct fuse_file_info *fi)
_______________________________________________
lxc-devel mailing list
[email protected]
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to