The following pull request was submitted through Github. It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/2891
This e-mail was sent by the LXC bot, direct replies will not reach the author unless they happen to be subscribed to this list. === Description (from pull-request) === Signed-off-by: Christian Brauner <[email protected]> Acked-by: Donghwa Jeong <[email protected]>
From ddaa52263abd45e14020bf445c3231087ece8d41 Mon Sep 17 00:00:00 2001 From: Christian Brauner <[email protected]> Date: Sun, 3 Mar 2019 14:11:55 +0100 Subject: [PATCH 1/4] commands_utils.c: fix wrong licensing liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <[email protected]> Donghwa Jeong <[email protected]> Signed-off-by: Christian Brauner <[email protected]> Acked-by: Donghwa Jeong <[email protected]> --- src/lxc/commands_utils.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/lxc/commands_utils.c b/src/lxc/commands_utils.c index ce167961d0..ff57a9976f 100644 --- a/src/lxc/commands_utils.c +++ b/src/lxc/commands_utils.c @@ -1,20 +1,21 @@ /* liblxcapi * - * Copyright © 2017 Christian Brauner <[email protected]>. - * Copyright © 2017 Canonical Ltd. + * Copyright © 2019 Christian Brauner <[email protected]>. + * Copyright © 2019 Canonical Ltd. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2, as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + + * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + + * You should have received a copy of the GNU Lesser General Public License + * along with this library; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef _GNU_SOURCE From 0fb44ac949d3cd2ddf0e7e4d5f7c16bf710fcd5f Mon Sep 17 00:00:00 2001 From: Christian Brauner <[email protected]> Date: Sun, 3 Mar 2019 14:18:41 +0100 Subject: [PATCH 2/4] commands_utils.h: fix wrong licensing liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <[email protected]> Donghwa Jeong <[email protected]> Signed-off-by: Christian Brauner <[email protected]> Acked-by: Donghwa Jeong <[email protected]> --- src/lxc/commands_utils.h | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/lxc/commands_utils.h b/src/lxc/commands_utils.h index c1583b785c..efb4bcfef6 100644 --- a/src/lxc/commands_utils.h +++ b/src/lxc/commands_utils.h @@ -1,20 +1,21 @@ /* liblxcapi * - * Copyright © 2017 Christian Brauner <[email protected]>. - * Copyright © 2017 Canonical Ltd. + * Copyright © 2019 Christian Brauner <[email protected]>. + * Copyright © 2019 Canonical Ltd. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2, as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + + * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + + * You should have received a copy of the GNU Lesser General Public License + * along with this library; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef __LXC_COMMANDS_UTILS_H From 8d01f531c22f71f62dc1c53e18ed4a6703324e1c Mon Sep 17 00:00:00 2001 From: Christian Brauner <[email protected]> Date: Sun, 3 Mar 2019 14:15:04 +0100 Subject: [PATCH 3/4] file_utils.c: fix wrong licensing liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <[email protected]> Donghwa Jeong <[email protected]> Signed-off-by: Christian Brauner <[email protected]> Acked-by: Donghwa Jeong <[email protected]> --- src/lxc/file_utils.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/lxc/file_utils.c b/src/lxc/file_utils.c index f80aa64219..603c0ace66 100644 --- a/src/lxc/file_utils.c +++ b/src/lxc/file_utils.c @@ -1,20 +1,21 @@ /* liblxcapi * - * Copyright © 2018 Christian Brauner <[email protected]>. - * Copyright © 2018 Canonical Ltd. + * Copyright © 2019 Christian Brauner <[email protected]>. + * Copyright © 2019 Canonical Ltd. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2, as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + + * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + + * You should have received a copy of the GNU Lesser General Public License + * along with this library; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef _GNU_SOURCE From 601b35e7ac0b19adc870cab79e01d3905ef9a0b7 Mon Sep 17 00:00:00 2001 From: Christian Brauner <[email protected]> Date: Sun, 3 Mar 2019 14:16:31 +0100 Subject: [PATCH 4/4] string_utils.c: fix wrong licensing liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <[email protected]> Donghwa Jeong <[email protected]> Signed-off-by: Christian Brauner <[email protected]> Acked-by: Donghwa Jeong <[email protected]> --- src/lxc/string_utils.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/lxc/string_utils.c b/src/lxc/string_utils.c index eb83f55051..9588a9cd23 100644 --- a/src/lxc/string_utils.c +++ b/src/lxc/string_utils.c @@ -1,20 +1,21 @@ /* liblxcapi * - * Copyright © 2018 Christian Brauner <[email protected]>. - * Copyright © 2018 Canonical Ltd. + * Copyright © 2019 Christian Brauner <[email protected]>. + * Copyright © 2019 Canonical Ltd. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2, as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + + * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + + * You should have received a copy of the GNU Lesser General Public License + * along with this library; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef _GNU_SOURCE
_______________________________________________ lxc-devel mailing list [email protected] http://lists.linuxcontainers.org/listinfo/lxc-devel
