Branch: refs/heads/stable-3.0 Home: https://github.com/lxc/lxc Commit: 8470bf1ce48951dadff63c2cba480bae2628973f https://github.com/lxc/lxc/commit/8470bf1ce48951dadff63c2cba480bae2628973f Author: tomponline <t...@tomp.uk> Date: 2019-05-18 (Sat, 18 May 2019)
Changed paths: M .travis.yml Log Message: ----------- Travis: Adds -Wall and -Werror gcc flags to automatic build. Signed-off-by: tomponline <t...@tomp.uk> Commit: 2d2df5af015c52c2f3a11b05fa85b5dafda5a944 https://github.com/lxc/lxc/commit/2d2df5af015c52c2f3a11b05fa85b5dafda5a944 Author: tomponline <t...@tomp.uk> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M .travis.yml Log Message: ----------- travis: Attempt to fix src/lxc/cmd/lxc_init.c:251: undefined reference to `pthread_sigmask Signed-off-by: tomponline <t...@tomp.uk> Commit: c5aab2fcb9bf7adadf1bf7bea0b64f4617b30ada https://github.com/lxc/lxc/commit/c5aab2fcb9bf7adadf1bf7bea0b64f4617b30ada Author: tomponline <t...@tomp.uk> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/storage/lvm.c M src/lxc/utils.c M src/lxc/utils.h Log Message: ----------- lvm: Updates lvcreate to wipe signatures if supported, fallbacks to old command if not. Signed-off-by: tomponline <t...@tomp.uk> Commit: 3c5b6e30d850be2aa52afd78b1a63bb2e34b00f3 https://github.com/lxc/lxc/commit/3c5b6e30d850be2aa52afd78b1a63bb2e34b00f3 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/network.c Log Message: ----------- network: fix network device removal Closes #2849. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: e6a19decfae1f7da51e314debba24ef2e5806110 https://github.com/lxc/lxc/commit/e6a19decfae1f7da51e314debba24ef2e5806110 Author: Felix Abecassis <fabecas...@nvidia.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/start.c Log Message: ----------- Fix user namespace pdeathsig handling Signed-off-by: Felix Abecassis <fabecas...@nvidia.com> Commit: 217a336c16f99b31b9a19fe00ae1342ea6074366 https://github.com/lxc/lxc/commit/217a336c16f99b31b9a19fe00ae1342ea6074366 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/cmd/lxc_user_nic.c Log Message: ----------- lxc-user-nic: small tweaks Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Cc: Akihiro Suda <suda.akih...@lab.ntt.co.jp> Commit: 45bfff5bb00121afa3624ccec7a2c43c353b2c73 https://github.com/lxc/lxc/commit/45bfff5bb00121afa3624ccec7a2c43c353b2c73 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M doc/lxc-user-nic.sgml.in Log Message: ----------- doc: update lxc-user-nic manpage Closes #1823. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Cc: Akihiro Suda <suda.akih...@lab.ntt.co.jp> Commit: 7c0312523439f4017f1020d3af23380103e969ae https://github.com/lxc/lxc/commit/7c0312523439f4017f1020d3af23380103e969ae Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/cmd/lxc_user_nic.c Log Message: ----------- lxc-user-nic: validate request Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Cc: Akihiro Suda <suda.akih...@lab.ntt.co.jp> Commit: c9ca5d6b220bb7054aadf1d364c0910062610a8a https://github.com/lxc/lxc/commit/c9ca5d6b220bb7054aadf1d364c0910062610a8a Author: KATOH Yasufumi <ka...@jazz.email.ne.jp> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M doc/ja/lxc-user-nic.sgml.in Log Message: ----------- doc: update Japanese lxc-user-nic manpage Update for commit db74bbd Signed-off-by: KATOH Yasufumi <ka...@jazz.email.ne.jp> Commit: a689c4afcc5a410cd0e793b398a57057102aac34 https://github.com/lxc/lxc/commit/a689c4afcc5a410cd0e793b398a57057102aac34 Author: yosukesan <y.otsuk...@gmail.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M doc/api/Makefile.am Log Message: ----------- fix: #2927 api doc generation fails under out of source build. Signed-off-by: yosukesan <y.otsuk...@gmail.com> Commit: e93cd8c5b6d4266cd35c7520f5f886518500e612 https://github.com/lxc/lxc/commit/e93cd8c5b6d4266cd35c7520f5f886518500e612 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/storage/btrfs.c Log Message: ----------- storage: prevent unitialized variable warning We can simply fix this issue by switching to our cleanup macros instead of manually freeing the memory. Closes #2912. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 404b9449789d2ab00358699d1ad381e857959080 https://github.com/lxc/lxc/commit/404b9449789d2ab00358699d1ad381e857959080 Author: pgauret <pgau...@yahoo.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/storage/zfs.c Log Message: ----------- storage: update zfs Change zfs arguments. This also works with older zfs versions, tested with zfs 0.7.9-3 on Ubuntu 18.10. Closes #2916. Signed-off-by: Paul Gauret <pgau...@yahoo.com> [christian.brau...@ubuntu.com: adapt commit message and add Signed-off-by for Paul] Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 6203554bdc8f2b9f8d1a027b4ffb73cb21eb1aa4 https://github.com/lxc/lxc/commit/6203554bdc8f2b9f8d1a027b4ffb73cb21eb1aa4 Author: Felix Abecassis <fabecas...@nvidia.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/conf.c Log Message: ----------- conf: do lxc.mount.entry mounts right after lxc.mount.fstab These configuration options use the same syntax and therefore it seems more intuitive to have the same behavior for both of them, which is not the case today since mount hooks and autodev mounts are called between the two. See: https://github.com/lxc/lxc/issues/2932 Signed-off-by: Felix Abecassis <fabecas...@nvidia.com> Commit: 72dd37ab8c1863ed9acabc737d7870827d028359 https://github.com/lxc/lxc/commit/72dd37ab8c1863ed9acabc737d7870827d028359 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/include/netns_ifaddrs.c M src/lxc/macro.h Log Message: ----------- netns_getifaddrs: adapt to kernel changes s/NETLINK_DUMP_STRICT_CHK/NETLINK_GET_STRICT_CHK/g Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: b089ff62cddb7e43dc6385c89e8da39f70df8726 https://github.com/lxc/lxc/commit/b089ff62cddb7e43dc6385c89e8da39f70df8726 Author: Tycho Andersen <ty...@tycho.ws> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/tools/lxc_start.c Log Message: ----------- lxc-start: remove bad doc We don't in fact exit(1) if this is not specified, and it wouldn't make sense to, since most people probably don't specify this. Signed-off-by: Tycho Andersen <ty...@tycho.ws> Commit: f3d279cc990794d515b75dd119272e742bf294ba https://github.com/lxc/lxc/commit/f3d279cc990794d515b75dd119272e742bf294ba Author: pgauret <pgau...@yahoo.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/storage/zfs.c Log Message: ----------- Fix 'zfs get' command order Another case of calling 'zfs get' which requires reordering arguments to work with latest zfs. Signed-off-by: Paul Gauret <pgau...@yahoo.com> Commit: 857147910fb867008870671e5ad032dcd665905c https://github.com/lxc/lxc/commit/857147910fb867008870671e5ad032dcd665905c Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/af_unix.c M src/lxc/attach.c M src/lxc/commands.c M src/lxc/commands.h M src/lxc/lxccontainer.c M src/lxc/macro.h M src/lxc/start.c Log Message: ----------- commands: partially backport seccomp notify This backports seccomp notify into various parts of the codebase as a pure nop to make maintenance easier. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 548b3229d8d3bc18ddc11291aaafa32e0f479f64 https://github.com/lxc/lxc/commit/548b3229d8d3bc18ddc11291aaafa32e0f479f64 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/af_unix.c M src/lxc/af_unix.h Log Message: ----------- af_unix: backport helper functions This backports various helpers associated with seccomp notify to make maintenance easier. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 1e9963ac1f56f30c7674b8f1a85e97644693d44b https://github.com/lxc/lxc/commit/1e9963ac1f56f30c7674b8f1a85e97644693d44b Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/start.c Log Message: ----------- start: silence clang Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 8a9a1a02dd0cebd5ecdda884a5f11dfc74ab910c https://github.com/lxc/lxc/commit/8a9a1a02dd0cebd5ecdda884a5f11dfc74ab910c Author: tomponline <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/network.c Log Message: ----------- network: Fixes a little typo in an error message Signed-off-by: tomponline <thomas.parr...@canonical.com> Commit: 2b73a79090a719caabf8820102668fc6df9851dd https://github.com/lxc/lxc/commit/2b73a79090a719caabf8820102668fc6df9851dd Author: tomponline <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/network.c Log Message: ----------- network: Adds upscript handling for vlan network type Signed-off-by: tomponline <thomas.parr...@canonical.com> Commit: 0fef58cfa97d9c800678d6b898ffdd0cce661f0b https://github.com/lxc/lxc/commit/0fef58cfa97d9c800678d6b898ffdd0cce661f0b Author: tomponline <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/network.c Log Message: ----------- network: Fixes vlan hook script Signed-off-by: tomponline <thomas.parr...@canonical.com> Commit: 1350fc845f1a78bf0a2ba6d22826a7fc220a0113 https://github.com/lxc/lxc/commit/1350fc845f1a78bf0a2ba6d22826a7fc220a0113 Author: tomponline <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M .gitignore Log Message: ----------- tests: Updates .gitignore to ignore test build artefacts Signed-off-by: tomponline <thomas.parr...@canonical.com> Commit: a533ec463c52313255e73985f62eb0aea20c6396 https://github.com/lxc/lxc/commit/a533ec463c52313255e73985f62eb0aea20c6396 Author: tomponline <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/confile_utils.c Log Message: ----------- network: Fixes bug in macvlan mode selection Signed-off-by: tomponline <thomas.parr...@canonical.com> Commit: 7b0aa99bdf60a7b4b682444ff0166a323e085258 https://github.com/lxc/lxc/commit/7b0aa99bdf60a7b4b682444ff0166a323e085258 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/af_unix.c Log Message: ----------- seccomp: notifier fixes Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 0dfb9453e3067ca9093e198ef799e0c69c03e6a1 https://github.com/lxc/lxc/commit/0dfb9453e3067ca9093e198ef799e0c69c03e6a1 Author: Serge Hallyn <shal...@cisco.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/confile_utils.c Log Message: ----------- namespaces: allow a pathname to a nsfd for namespace to share Signed-off-by: Serge Hallyn <shal...@cisco.com> Commit: 45760f6200dfbf0b4d8835946a23464c5d8ab396 https://github.com/lxc/lxc/commit/45760f6200dfbf0b4d8835946a23464c5d8ab396 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/af_unix.c M src/lxc/network.c M src/lxc/nl.c Log Message: ----------- tree-wide: make socket SOCK_CLOEXEC Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 84721447b92a8a77c26d00cd1880d24e36723195 https://github.com/lxc/lxc/commit/84721447b92a8a77c26d00cd1880d24e36723195 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/compiler.h M src/lxc/raw_syscalls.c Log Message: ----------- compiler: add __returns_twice attribute The returns_twice attribute tells the compiler that a function may return more than one time. The compiler will ensure that all registers are dead before calling such a function and will emit a warning about the variables that may be clobbered after the second return from the function. Examples of such functions are setjmp and vfork. The longjmp-like counterpart of such function, if any, might need to be marked with the noreturn attribute. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 4f464a77f4f1a55a675593db7cad7e6274a39547 https://github.com/lxc/lxc/commit/4f464a77f4f1a55a675593db7cad7e6274a39547 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/raw_syscalls.c M src/lxc/raw_syscalls.h M src/lxc/start.c M src/lxc/start.h Log Message: ----------- raw_syscalls: add initial support for pidfd_send_signal() Well, I added this syscall so we better use it. :) Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: c9ecca0781d836cfca3b4c9f430dddf8908817c8 https://github.com/lxc/lxc/commit/c9ecca0781d836cfca3b4c9f430dddf8908817c8 Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M templates/lxc-busybox.in Log Message: ----------- Devices created in rootfs instead of rootfs/dev Added /dev in the mknod commands. Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Commit: 47576a3f633096734459712858c2708c4a5a26b7 https://github.com/lxc/lxc/commit/47576a3f633096734459712858c2708c4a5a26b7 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/macro.h M src/lxc/utils.c Log Message: ----------- utils: improve switch_to_ns() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: ceda5ac37679a7da75f22506e507b0428de1b31d https://github.com/lxc/lxc/commit/ceda5ac37679a7da75f22506e507b0428de1b31d Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/raw_syscalls.c Log Message: ----------- raw_syscalls: simplify assembly Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Co-developed-by: David Howells <dhowe...@redhat.com> Signed-off-by: David Howells <dhowe...@redhat.com> Commit: df5644f3a7fc6d46118abeb6e6c83c09770edd28 https://github.com/lxc/lxc/commit/df5644f3a7fc6d46118abeb6e6c83c09770edd28 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/attach.c M src/lxc/conf.c M src/lxc/raw_syscalls.c M src/lxc/raw_syscalls.h M src/lxc/start.c M src/lxc/utils.c M src/tests/lxc_raw_clone.c Log Message: ----------- clone: add infrastructure for CLONE_PIDFD https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=eac7078a0fff1e72cf2b641721e3f55ec7e5e21e Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: ded425a688daa55ad1a87877b0d5065dead3e4bd https://github.com/lxc/lxc/commit/ded425a688daa55ad1a87877b0d5065dead3e4bd Author: Thomas Parrott <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/network.c Log Message: ----------- network: Adds mtu support for phys and macvlan types Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com> Commit: 463334b7fb3c98d359d4724063e3de9807de9925 https://github.com/lxc/lxc/commit/463334b7fb3c98d359d4724063e3de9807de9925 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/conf.c M src/lxc/namespace.c M src/lxc/namespace.h M src/lxc/start.c M src/lxc/storage/nbd.c M src/lxc/tools/lxc_unshare.c Log Message: ----------- namespace: support CLONE_PIDFD with lxc_clone() Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 3ef7f2c0a2fac971e34aa13a3b310c1f4790e2dd https://github.com/lxc/lxc/commit/3ef7f2c0a2fac971e34aa13a3b310c1f4790e2dd Author: Thomas Parrott <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/network.c M src/lxc/network.h Log Message: ----------- network: Restores phys device MTU on container shutdown The phys devices will now have their original MTUs recorded at start and restored at shutdown. This is to protect the original phys device from having any container level MTU customisation being applied to the device once it is restored to the host. Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com> Commit: e77c83f65e32a115b9bb7446ada8e53a53f7ca55 https://github.com/lxc/lxc/commit/e77c83f65e32a115b9bb7446ada8e53a53f7ca55 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/start.c M src/lxc/start.h Log Message: ----------- start: use CLONE_PIDFD Use CLONE_PIDFD when possible. Note the clone() syscall ignores unknown flags which is usually a design mistake. However, for us this bug is a feature since we can just pass the flag along and see whether the kernel has given us a pidfd. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: dcf5c826501910285af07c34eda05375d25d51a1 https://github.com/lxc/lxc/commit/dcf5c826501910285af07c34eda05375d25d51a1 Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M templates/lxc-busybox.in Log Message: ----------- Redirect error messages to stderr Some error messages were not redirected to stderr. Moreover, do "exit 0" instead of "exit 1" when "help" option is passed. Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Commit: 4e6bfc48f51761564948676248c2bfe9c9c505fc https://github.com/lxc/lxc/commit/4e6bfc48f51761564948676248c2bfe9c9c505fc Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M CODING_STYLE.md Log Message: ----------- coding style: update Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 46dde5277ca0b4bd22f664eea87713ccb8163e87 https://github.com/lxc/lxc/commit/46dde5277ca0b4bd22f664eea87713ccb8163e87 Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M templates/lxc-busybox.in Log Message: ----------- New --bbpath option and unecessary --rootfs checks . Add the "--bbpath" option to pass an alternate busybox pathname instead of the one found from ${PATH}. . Take this opportunity to add some formatting in the usage display . As a try is done to pick rootfs from the config file and set it to ${path}/rootfs, it is unnecessary to make it mandatory Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Commit: cd2ca8a1ddaf919cd00a9288f3014b171a8f6449 https://github.com/lxc/lxc/commit/cd2ca8a1ddaf919cd00a9288f3014b171a8f6449 Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: do not display if missing privileges lxc-ls without root privileges on privileged containers should not display information. In lxc_container_new(), ongoing_create()'s result is not checked for all possible returned values. Hence, an unprivileged user can send command messages to the container's monitor. For example: $ lxc-ls -P /.../tests -f NAME STATE AUTOSTART GROUPS IPV4 IPV6 UNPRIVILEGED ctr - 0 - - - false $ sudo lxc-ls -P /.../tests -f NAME STATE AUTOSTART GROUPS IPV4 IPV6 UNPRIVILEGED ctr RUNNING 0 - 10.0.3.51 - false After this change: $ lxc-ls -P /.../tests -f <-------- No more display without root privileges $ sudo lxc-ls -P /.../tests -f NAME STATE AUTOSTART GROUPS IPV4 IPV6 UNPRIVILEGED ctr RUNNING 0 - 10.0.3.37 - false $ Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 09f55bc4be0491c9e1f3a1c14a900d39bf70f2b7 https://github.com/lxc/lxc/commit/09f55bc4be0491c9e1f3a1c14a900d39bf70f2b7 Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M templates/lxc-busybox.in Log Message: ----------- Option --busybox-path instead of --bbpath As suggested during the review. Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Commit: d3accb17510346ec29edfbef6e75a6cf1c3a07c9 https://github.com/lxc/lxc/commit/d3accb17510346ec29edfbef6e75a6cf1c3a07c9 Author: Radostin Stoyanov <rstoyan...@gmail.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/criu.c Log Message: ----------- criu: Use -v4 instead of -vvvvvv CRIU has only 4 levels of verbosity (errors, warnings, info, debug). Thus, using `-v4` is more appropriate. https://criu.org/Logging Signed-off-by: Radostin Stoyanov <rstoyan...@gmail.com> Commit: b526996b6f4f83a8cbb7d12abeff113c278b3697 https://github.com/lxc/lxc/commit/b526996b6f4f83a8cbb7d12abeff113c278b3697 Author: Rikard Falkeborn <rikard.falkeb...@gmail.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/criu.c Log Message: ----------- criu: Remove unnecessary return after _exit() Since _exit() will terminate, the return statement is dead code. Also, returning -1 from a function with bool as return type is confusing. Detected with cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeb...@gmail.com> Commit: c5e6088f4c3403a2edbd844dac216975bc6f11cf https://github.com/lxc/lxc/commit/c5e6088f4c3403a2edbd844dac216975bc6f11cf Author: Rikard Falkeborn <rikard.falkeb...@gmail.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/storage/lvm.c Log Message: ----------- lvm: Fix return value if lvm_create_clone fails Returning -1 in a function with return type bool is the same as returning true. Change to return false to indicate error properly. Detected with cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeb...@gmail.com> Commit: 3cd861392a01e17f2fb4694c587876d6cc7f01c0 https://github.com/lxc/lxc/commit/3cd861392a01e17f2fb4694c587876d6cc7f01c0 Author: Rikard Falkeborn <rikard.falkeb...@gmail.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/storage/zfs.c Log Message: ----------- zfs: Fix return value on zfs_snapshot error Returning -1 in a function with return type bool is the same as returning true. Change to return false to indicate error properly. Detected with cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeb...@gmail.com> Commit: 22c8f39b9d34fffff100f16a8d457759fbc03842 https://github.com/lxc/lxc/commit/22c8f39b9d34fffff100f16a8d457759fbc03842 Author: Rikard Falkeborn <rikard.falkeb...@gmail.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/initutils.c Log Message: ----------- initutils: Fix memleak on realloc failure Signed-off-by: Rikard Falkeborn <rikard.falkeb...@gmail.com> Commit: 7d1a06e52e57457b9a89eaa59524d345c6648bfd https://github.com/lxc/lxc/commit/7d1a06e52e57457b9a89eaa59524d345c6648bfd Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M configure.ac Log Message: ----------- Config: check for %m availability GLIBC supports %m to avoid calling strerror(). Using it saves some code space. ==> This check will define HAVE_M_FORMAT to be use wherever possible (e.g. log.h) Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Commit: 5d27c86ad1f59bacb685007330f39e48cd5845a6 https://github.com/lxc/lxc/commit/5d27c86ad1f59bacb685007330f39e48cd5845a6 Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/log.h Log Message: ----------- Use %m instead of strerror() when available Use %m under HAVE_M_FORMAT instead of strerror() Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Commit: 0b8deb656f352354e830b77e288a33b042a14cc7 https://github.com/lxc/lxc/commit/0b8deb656f352354e830b77e288a33b042a14cc7 Author: Rachid Koucha <47061324+rachid-kou...@users.noreply.github.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/log.h Log Message: ----------- Error prone semicolon Suppressed error prone semicolon in SYSTRACE() macro. Signed-off-by: Rachid Koucha <rachid.kou...@gmail.com> Commit: eabeaa394f886e1847f4495099f0f2d6731e552f https://github.com/lxc/lxc/commit/eabeaa394f886e1847f4495099f0f2d6731e552f Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M configure.ac Log Message: ----------- configure: handle checks when cross-compiling Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: c0c0d9ec538eeebb2385d56acd992862d59aeb12 https://github.com/lxc/lxc/commit/c0c0d9ec538eeebb2385d56acd992862d59aeb12 Author: Thomas Parrott <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/macro.h M src/lxc/network.c Log Message: ----------- network: move phys netdevs back to monitor's net ns rather than pid 1's Updates lxc_restore_phys_nics_to_netns() to move phys netdevs back to the monitor's network namespace rather than the previously hardcoded PID 1 net ns. This is to fix instances where LXC is started inside a net ns different from PID 1 and physical devices are moved back to a different net ns when the container is shutdown than the net ns than where the container was started from. Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com> Commit: d880b03482b01e35b7f5af11121f1b3b2f2ad258 https://github.com/lxc/lxc/commit/d880b03482b01e35b7f5af11121f1b3b2f2ad258 Author: Thomas Parrott <thomas.parr...@canonical.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/network.c Log Message: ----------- network: Fixes bug that stopped down hook from running for phys netdevs Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com> Commit: b748fa8f2cd211e3713593ebf2b5e541106ba50a https://github.com/lxc/lxc/commit/b748fa8f2cd211e3713593ebf2b5e541106ba50a Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/attach.c M src/lxc/attach.h M src/lxc/lxccontainer.c Log Message: ----------- attach: do not reload container Let lxc_attach() reuse the already initialized container. Closes https://github.com/lxc/lxd/issues/5755. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Commit: 89f59fa2567314eedb66af5d8ca7ad2e0ad468b5 https://github.com/lxc/lxc/commit/89f59fa2567314eedb66af5d8ca7ad2e0ad468b5 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-18 (Sat, 18 May 2019) Changed paths: M src/lxc/lxccontainer.c Log Message: ----------- lxccontainer: cleanup attach functions Specifically, refloat function arguments and remove useless comments. Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> Compare: https://github.com/lxc/lxc/compare/9e5d932ccd88...89f59fa25673 _______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel