The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxd/pull/6786
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com>
From 94c45dcac77f48122b3f15d6fd82369436f3b180 Mon Sep 17 00:00:00 2001
From: Thomas Parrott <thomas.parr...@canonical.com>
Date: Mon, 27 Jan 2020 11:28:39 +0000
Subject: [PATCH] lxd/migration/migration/volumes: Adds support for
pre-bidirectional negotiation targets
Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com>
---
lxd/migration/migration_volumes.go | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lxd/migration/migration_volumes.go
b/lxd/migration/migration_volumes.go
index aff1691510..0ed03c3219 100644
--- a/lxd/migration/migration_volumes.go
+++ b/lxd/migration/migration_volumes.go
@@ -128,6 +128,12 @@ func MatchTypes(offer MigrationHeader, fallbackType
MigrationFSType, ourTypes []
offeredFeatures = offer.GetZfsFeaturesSlice()
} else if offerFSType == MigrationFSType_RSYNC {
offeredFeatures = offer.GetRsyncFeaturesSlice()
+ if !shared.StringInSlice("bidirectional",
offeredFeatures) {
+ // If no bi-directional support, this
means we are getting a response from
+ // an old LXD server that doesn't
support bidirectional negotiation, so
+ // assume LXD 3.7 level. NOTE: Do NOT
extend this list of arguments.
+ offeredFeatures = []string{"xattrs",
"delete", "compress"}
+ }
}
// Find common features in both our type and offered
type.
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel
