The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxd/pull/6845

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Signed-off-by: Stéphane Graber <stgra...@ubuntu.com>
From 5b42e6bb991b4fc15b7432a9f943aeb3f2479a72 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Graber?= <stgra...@ubuntu.com>
Date: Wed, 5 Feb 2020 18:46:15 -0500
Subject: [PATCH] lxd/device: Async CEPH unmap
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Stéphane Graber <stgra...@ubuntu.com>
---
 lxd/device/disk.go | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lxd/device/disk.go b/lxd/device/disk.go
index 6e33a5b4ff..9e1e6f96a1 100644
--- a/lxd/device/disk.go
+++ b/lxd/device/disk.go
@@ -18,6 +18,7 @@ import (
        deviceConfig "github.com/lxc/lxd/lxd/device/config"
        "github.com/lxc/lxd/lxd/instance"
        "github.com/lxc/lxd/lxd/instance/instancetype"
+       "github.com/lxc/lxd/lxd/project"
        storagePools "github.com/lxc/lxd/lxd/storage"
        "github.com/lxc/lxd/lxd/util"
        "github.com/lxc/lxd/shared"
@@ -819,10 +820,13 @@ func (d *disk) postStop() error {
 
        if strings.HasPrefix(d.config["source"], "ceph:") {
                v := d.volatileGet()
-               err := diskCephRbdUnmap(v["ceph_rbd"])
-               if err != nil {
-                       return err
-               }
+
+               go func() {
+                       err := diskCephRbdUnmap(v["ceph_rbd"])
+                       if err != nil {
+                               logger.Errorf("Failed to unmap RBD volume '%s' 
for '%s': %v", v["ceph_rbd"], project.Prefix(d.inst.Project(), d.inst.Name()), 
err)
+                       }
+               }()
        }
 
        return nil
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to