The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/3378

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com>
From ec4d463d0ff5b1a4c0838de0aaa5cd51d5797c8d Mon Sep 17 00:00:00 2001
From: Christian Brauner <christian.brau...@ubuntu.com>
Date: Mon, 13 Apr 2020 14:39:18 +0200
Subject: [PATCH] cgroups: adhere to boolean return

Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com>
---
 src/lxc/cgroups/cgfsng.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/lxc/cgroups/cgfsng.c b/src/lxc/cgroups/cgfsng.c
index 522eb412d7..a6ee6875e3 100644
--- a/src/lxc/cgroups/cgfsng.c
+++ b/src/lxc/cgroups/cgfsng.c
@@ -1194,11 +1194,9 @@ static bool cgroup_tree_create(struct cgroup_ops *ops, 
struct lxc_conf *conf,
                 * line, which is not possible once a subdirectory has been
                 * created.
                 */
-               if (string_in_list(h->controllers, "devices")) {
-                       ret = ops->setup_limits_legacy(ops, conf, true);
-                       if (ret < 0)
-                               return ret;
-               }
+               if (string_in_list(h->controllers, "devices") &&
+                   !ops->setup_limits_legacy(ops, conf, true))
+                       return log_error(false, "Failed to setup legacy device 
limits");
        }
 
        ret = mkdir_eexist_on_last(path, 0755);
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to