The following pull request was submitted through Github. It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/3540
This e-mail was sent by the LXC bot, direct replies will not reach the author unless they happen to be subscribed to this list. === Description (from pull-request) === … EPERM ``` FAIL: lxc-tests: lxc-test-usernsexec (1s) --- as test-userns executing /tmp/autopkgtest.waGEXj/build.Hm3/src/src/tests/lxc-test-usernsexec uid=1001 gid=1001 name=test-userns subuid=165536 subgid=165536 ver=1:4.0.4-0ubuntu3 lxc-utils=1:4.0.4-0ubuntu3 kver=5.8.0-19-generic USERNSEXEC=lxc-usernsexec nouidgid: PASS myuidgid: FAIL - runtest failed 1 $ lxc-usernsexec -mu:0:1001:1 -mg:0:1001:1 -- /tmp/autopkgtest.waGEXj/build.Hm3/src/src/tests/lxc-test-usernsexec inside f0 lxc 20200914222824.562 ERROR utils - utils.c:lxc_setgroups:1363 - Operation not permitted - Failed to setgroups() kid 73112 is gone 1 subuidgid: PASS bothsets: PASS mismatch: PASS ERRORS: myuidgid --- ``` Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com>
From d4b725ac8b561f1339b99fa01bcc287e8bc47221 Mon Sep 17 00:00:00 2001 From: Christian Brauner <christian.brau...@ubuntu.com> Date: Thu, 17 Sep 2020 17:44:26 +0200 Subject: [PATCH] lxc-usernsexec: setgroups() similar to other places shouldn't fail on EPERM FAIL: lxc-tests: lxc-test-usernsexec (1s) --- as test-userns executing /tmp/autopkgtest.waGEXj/build.Hm3/src/src/tests/lxc-test-usernsexec uid=1001 gid=1001 name=test-userns subuid=165536 subgid=165536 ver=1:4.0.4-0ubuntu3 lxc-utils=1:4.0.4-0ubuntu3 kver=5.8.0-19-generic USERNSEXEC=lxc-usernsexec nouidgid: PASS myuidgid: FAIL - runtest failed 1 $ lxc-usernsexec -mu:0:1001:1 -mg:0:1001:1 -- /tmp/autopkgtest.waGEXj/build.Hm3/src/src/tests/lxc-test-usernsexec inside f0 lxc 20200914222824.562 ERROR utils - utils.c:lxc_setgroups:1363 - Operation not permitted - Failed to setgroups() kid 73112 is gone 1 subuidgid: PASS bothsets: PASS mismatch: PASS ERRORS: myuidgid --- Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com> --- src/lxc/cmd/lxc_usernsexec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/cmd/lxc_usernsexec.c b/src/lxc/cmd/lxc_usernsexec.c index 5c12dad3b8..c22a33bb41 100644 --- a/src/lxc/cmd/lxc_usernsexec.c +++ b/src/lxc/cmd/lxc_usernsexec.c @@ -88,7 +88,7 @@ static int do_child(void *vargv) int ret; char **argv = (char **)vargv; - if (!lxc_setgroups(0, NULL)) + if (!lxc_setgroups(0, NULL) && errno != EPERM) return -1; /* Assume we want to become root */
_______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel