On 03/11/2011 11:06 PM, Daniel Lezcano wrote:
>> And we really, REALLY need to set default log level to
>> be at least warning instead of error, or else these
>> useful warnings goes nowhere.
>
> Everybody ok with this change ?
>
> extern int lxc_log_init(const char *file, const char *priority,
> const char *prefix, int quiet)
> {
> - int lxc_priority = LXC_LOG_PRIORITY_ERROR;
> + int lxc_priority = LXC_LOG_PRIORITY_WARN;
here's a quick survey on the WARN messages :
src/lxc/stop.c: WARN("failed to send answer to the peer");
src/lxc/console.c: WARN("failed to set old terminal settings");
src/lxc/console.c: WARN("console input disabled");
src/lxc/utils.c: WARN("failed to unmount %s : %s", target,
strerror(errno));
src/lxc/lxc_attach.c: WARN("could not change directory to '%s'",
curdir);
src/lxc/conf.c: WARN("unexpected error for ioctl on '%s': %m",
src/lxc/conf.c: WARN("failed to close directory");
src/lxc/conf.c: WARN("failed to mount '%s'->'%s'",
src/lxc/conf.c: WARN("failed to unmount '%s'", (char *)iterator->elem);
src/lxc/conf.c: WARN("can't remove mountpoint '%s': %m", pivotdir);
src/lxc/conf.c: WARN("rootfs specified but no console found at '%s'",
path);
src/lxc/conf.c: WARN("ignoring mount point '%s'", mntent->mnt_dir);
src/lxc/commands.c: WARN("partial request, ignored");
src/lxc/state.c: WARN("'%s' has stopped before sending its
state", name);
src/lxc/state.c: WARN("failed to send answer to the peer");
src/lxc/utmp.c: WARN("'%s' not found", path);
src/lxc/start.c: WARN("failed to open directory: %m");
src/lxc/start.c: WARN("invalid pid for SIGCHLD");
src/lxc/start.c: WARN("failed to send answer to the peer");
src/lxc/start.c: WARN("failed to restore sigprocmask");
src/lxc/log.c: WARN("truncated next event from %d to %zd bytes", n,
src/lxc/cgroup.c: WARN("using deprecated ns_cgroup");
maybe a few of them should be ERROR messages.
C.
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel
